8258584: java/util/HexFormat/HexFormatTest.java fails on x86_32

[DamonFool]

Hi all,

java/util/HexFormat/HexFormatTest.java fails on x86_32 due to '-Xmx4G'.
The reason is that -Xmx4G is invalid maximum heap size for 32-bit platforms.
The current implementation only supports maximum 3800M on 32-bit systems [1].

I've tried to reduce the -Xmx size, but it still fails even with -Xmx2G.
So this test seems to be brittle on 32-bit platforms since 2G is already larger than 3800M/2=1900M.
The fix just skips the test for 32-bit systems.

Thanks.
Best regards,
Jie

[1] https://github.com/openjdk/jdk/blob/master/src/hotspot/os/posix/os_posix.cpp#L567

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8258584: java/util/HexFormat/HexFormatTest.java fails on x86_32

Reviewers

• Roger Riggs (@RogerRiggs - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1817/head:pull/1817
$ git checkout pull/1817

[DamonFool]

/issue add JDK-8258584
/test
/label add core-libs
/cc core-libs

[bridgekeeper]

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@DamonFool This issue is referenced in the PR title - it will now be updated.

[openjdk]

@DamonFool
The core-libs label was successfully added.

[openjdk]

@DamonFool The core-libs label was already applied.

[mlbridge]

Webrevs

• 02: Full - Incremental (83cbdaa)
• 01: Full - Incremental (38d4d01)
• 00: Full (6b32101)

[RogerRiggs]

Disabling all of the tests on 32 bit is not a good idea.

Instead the HexFormatTest.testOOME test should be skipped or the OOME should be ignored.
Checking Runtime.getRuntime().maxMemory() should provide enough info to skip it.

[DamonFool]

Disabling all of the tests on 32 bit is not a good idea.

Instead the HexFormatTest.testOOME test should be skipped or the OOME should be ignored.
Checking Runtime.getRuntime().maxMemory() should provide enough info to skip it.

Thanks @RogerRiggs for your review and comments.
Let's ignore the OOME for testOOME.
What do you think of the updated change?
Thanks.

[RogerRiggs]

Completely ignoring the exception will leave no trace that the test was skipped or why.
Please retain the printing of the memory limits and instead of rethrowing the oome add:
throw new SkipException("Insufficient Memory to test OOME");
(It will need an import of org.testng.SkipException).
Throwing SkipException will flag the test as being skipped in the Jtreg summary.

[DamonFool]

Completely ignoring the exception will leave no trace that the test was skipped or why.
Please retain the printing of the memory limits and instead of rethrowing the oome add:
throw new SkipException("Insufficient Memory to test OOME");
(It will need an import of org.testng.SkipException).
Throwing SkipException will flag the test as being skipped in the Jtreg summary.

Updated.
Thanks for your help.

[RogerRiggs]

Looks fine. Thanks

[openjdk]

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258584: java/util/HexFormat/HexFormatTest.java fails on x86_32

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 58 new commits pushed to the master branch:

• 30b9ff6: 8258653: CallJavaNode::_bci is not in use
• 12297a0: 8258736: No break in the loop
• 01d51a1: 8231622: SuppressWarning("serial") ignored on field serialVersionUID
• a06cea5: 8258396: SIGILL in jdk.jfr.internal.PlatformRecorder.rotateDisk()
• d234388: Merge
• e680ebe: 8258007: Add instrumentation to NativeLibraryTest
• c04c7e1: 8258002: Update "type" terminology in generated docs
• 45bd3b9: 8223607: --override-methods=summary ignores some signature changes
• 59ae054: 8258687: Build broken on Windows after fix for JDK-8258134
• 1cc98bd: 8256693: getAnnotatedReceiverType parameterizes types too eagerly
• ... and 48 more: https://git.openjdk.java.net/jdk/compare/83be8a902cee867c0e9d400e762f61896eb6df80...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[DamonFool]

/integrate

[openjdk]

@DamonFool Since your change was applied there have been 58 commits pushed to the master branch:

• 30b9ff6: 8258653: CallJavaNode::_bci is not in use
• 12297a0: 8258736: No break in the loop
• 01d51a1: 8231622: SuppressWarning("serial") ignored on field serialVersionUID
• a06cea5: 8258396: SIGILL in jdk.jfr.internal.PlatformRecorder.rotateDisk()
• d234388: Merge
• e680ebe: 8258007: Add instrumentation to NativeLibraryTest
• c04c7e1: 8258002: Update "type" terminology in generated docs
• 45bd3b9: 8223607: --override-methods=summary ignores some signature changes
• 59ae054: 8258687: Build broken on Windows after fix for JDK-8258134
• 1cc98bd: 8256693: getAnnotatedReceiverType parameterizes types too eagerly
• ... and 48 more: https://git.openjdk.java.net/jdk/compare/83be8a902cee867c0e9d400e762f61896eb6df80...master

Your commit was automatically rebased without conflicts.

Pushed as commit 1594372.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.