Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8327716: RISC-V: Change type of vector_length param of several assembler functions from int to uint #18175

Closed
wants to merge 2 commits into from

Conversation

zifeihan
Copy link
Member

@zifeihan zifeihan commented Mar 9, 2024

Hi, we noticed that the return type of Matcher::vector_length is uint, But the type of vector_length param of several assembler functions is int, which is not consistent. This should not affect functionality, but we should change type of vector_length param of several assembler functions from int to uint to make the code clean.

Tests

  • Run tier1-3 tests on on LicheePI 4A (release)
  • Run tier1-3 tests with -XX:+UseRVV on qemu 8.1.0 (release)

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8327716: RISC-V: Change type of vector_length param of several assembler functions from int to uint (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18175/head:pull/18175
$ git checkout pull/18175

Update a local copy of the PR:
$ git checkout pull/18175
$ git pull https://git.openjdk.org/jdk.git pull/18175/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18175

View PR using the GUI difftool:
$ git pr show -t 18175

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18175.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 9, 2024

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 9, 2024

@zifeihan The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Mar 9, 2024
@zifeihan zifeihan marked this pull request as ready for review March 11, 2024 02:35
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 11, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 11, 2024

Webrevs

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@openjdk
Copy link

openjdk bot commented Mar 11, 2024

@zifeihan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327716: RISC-V: Change type of vector_length param of several assembler functions from int to uint

Reviewed-by: fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • 586396c: 8327705: Remove mention of "applet" from java.text package description
  • 41450e9: 8314250: CDS dump error message: Invoker type parameter must start and end with Object: L3I_L
  • 0a6e64e: 8327424: ProblemList serviceability/sa/TestJmapCore.java on all platforms with ZGC
  • c65d308: 8327812: JFR: Remove debug message in Function.Maximum
  • b9bc31f: 8327790: Improve javadoc for ResolvedJavaType.hasFinalizableSubclass
  • 18de932: 8325991: Accelerate Poly1305 on x86_64 using AVX2 instructions
  • d74b907: 8327093: Add truncate function to BitMap API
  • ffd43c9: 8327461: KeyStore getEntry is not thread-safe
  • 680ac2c: 8327689: RISC-V: adjust test filters of zfh extension
  • 570ad67: 8269428: java/util/concurrent/ConcurrentHashMap/ToArray.java timed out
  • ... and 4 more: https://git.openjdk.org/jdk/compare/243cb098d48741e9bd6308ef7609c9a4637a5e07...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 11, 2024
@zifeihan
Copy link
Member Author

@RealFYang : Thanks for your review.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 12, 2024
@openjdk
Copy link

openjdk bot commented Mar 12, 2024

@zifeihan
Your change (at version 5cee6f9) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 12, 2024

Going to push as commit 4d6235e.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 586396c: 8327705: Remove mention of "applet" from java.text package description
  • 41450e9: 8314250: CDS dump error message: Invoker type parameter must start and end with Object: L3I_L
  • 0a6e64e: 8327424: ProblemList serviceability/sa/TestJmapCore.java on all platforms with ZGC
  • c65d308: 8327812: JFR: Remove debug message in Function.Maximum
  • b9bc31f: 8327790: Improve javadoc for ResolvedJavaType.hasFinalizableSubclass
  • 18de932: 8325991: Accelerate Poly1305 on x86_64 using AVX2 instructions
  • d74b907: 8327093: Add truncate function to BitMap API
  • ffd43c9: 8327461: KeyStore getEntry is not thread-safe
  • 680ac2c: 8327689: RISC-V: adjust test filters of zfh extension
  • 570ad67: 8269428: java/util/concurrent/ConcurrentHashMap/ToArray.java timed out
  • ... and 4 more: https://git.openjdk.org/jdk/compare/243cb098d48741e9bd6308ef7609c9a4637a5e07...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 12, 2024
@openjdk openjdk bot closed this Mar 12, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 12, 2024
@openjdk
Copy link

openjdk bot commented Mar 12, 2024

@RealFYang @zifeihan Pushed as commit 4d6235e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@zifeihan zifeihan deleted the JDK-8327716 branch March 31, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants