8327748: Convert javax/swing/JFileChooser/6798062/bug6798062.java applet test to main by prsadhuk · Pull Request #18180 · openjdk/jdk

prsadhuk · 2024-03-11T06:22:22Z

Conversion of manual applet test to main based using PassFailJFrame manual framework

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8327748: Convert javax/swing/JFileChooser/6798062/bug6798062.java applet test to main (Bug - P4)

Reviewers

Alexey Ivanov (@aivanov-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18180/head:pull/18180
$ git checkout pull/18180

Update a local copy of the PR:
$ git checkout pull/18180
$ git pull https://git.openjdk.org/jdk.git pull/18180/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18180

View PR using the GUI difftool:
$ git pr show -t 18180

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18180.diff

Webrev

Link to Webrev Comment

…let test to main

bridgekeeper · 2024-03-11T06:22:53Z

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-03-11T06:24:28Z

@prsadhuk The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-03-11T06:27:15Z

Webrevs

kumarabhi006 · 2024-03-11T09:38:49Z

test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java

+
+public class bug6798062 {
+
+    private static final String instructionsText = """


instructionsText may be capitalize as using capital letter is common convention for final variables.

That is for constant, IIRC...

Either way is fine… And instructionsText is a constant but it's not public.

kumarabhi006 · 2024-03-11T09:39:13Z

test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java

+            4. Press the Start button in the test window
+            5. Wait several minutes and observe in the Windows Task Manager
+               that Memory Usage of java process is not increasing
+            If menory usage is increasing, click Fail else click Pass .  """;


Suggested change

If menory usage is increasing, click Fail else click Pass . """;

If memory usage is increasing, click Fail else click Pass . """;

aivanov-jdk · 2024-03-11T14:37:42Z

test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java

+                .columns(35)
+                .build();
+
+        SwingUtilities.invokeAndWait(() -> {


I suggest using the testUI method of the builder which accepts a lambda expression that returns a frame. Calling the passed method reference or lambda expression on EDT, registering the frame with PassFailJFrame and its positioning is handled automatically.

ok..updated...

aivanov-jdk · 2024-03-11T14:39:28Z

test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java

+        passFailJFrame.awaitAndCheck();
    }

    private JComponent initialize() {


I suggest creating the files in the current directory instead of temp or home. When run with jtreg, the current directory is set to scratch which is automatically removed by jtreg, which ensures no files are left behind if the test fails to clean them up for whatever reason.

aivanov-jdk · 2024-03-11T14:43:07Z

test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java

Likely, all the catch blocks which simply print stack traces should propagate the exception or rather in addition to printing the stack trace call PassFailJFrame.forceFail with a corresponding message.

The fail method of the test should also call PassFailJFrame.forceFail to fail the test.

aivanov-jdk · 2024-03-11T14:52:04Z

test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java

-    public void init() {
-        add(initialize());
+    public static void main(String[] args) throws Exception {
+         PassFailJFrame passFailJFrame = new PassFailJFrame.Builder()


Please use the builder helper method instead of new.

TejeshR13 · 2024-03-12T10:18:06Z

test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java

+            If memory usage is increasing, click Fail else click Pass .  """;
+
+    private static JSlider slider;
+    private static JFrame frame;


frame Can be moved inside createUI().

TejeshR13 · 2024-03-12T10:19:23Z

test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java

+
+    private static JSlider slider;
+    private static JFrame frame;
+    private static JTextField tfLink;


tfLink and btnGC can be initialized inside initialize() and moved there.

As I understood, testUI calls the passed method in EDT so I think it's better to init the swing variables there..

As I understood, testUI calls the passed method in EDT so I think it's better to init the swing variables there..

Yes, that's true, if you pass a lambda expression to testUI, it is called on EDT.

Since initialize is called from createUI, both methods will be called on EDT.

aivanov-jdk · 2024-03-12T10:59:48Z

test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java

+            1. Create a link
+            2. Copy path to the link into TextField


I understand the instructions aren't new but I can't comprehend what it's required.

Does it mean a Windows shortcut, .lnk file? Seems like it's the case because getLinkLocation is called which resolves a shortcut to its original file.

Can the text field be pre-populated with a default? There could be shortcuts on Desktop, there are many shortcuts in the Start menu.

Could you amend the instructions to clarify them?

Define what is a link.

It seems a Windows shortcut is crucial to reproducing the original problem, if it is, the handler for the Start button could show an error message about this fact.

Perhaps, if this link cannot be converted to a file in MyThread constructor, FileNotFoundException should be propagated and caught in the Start button actionPerformed handler to show an error message and let the tester use another Windows shortcut.

SInce this exercise is just to convert applet to main, I tried to keep the instructions same (although I agree it seems ambiguous and I also am not clear what needs to be done) which seems to be ok with the tester since 2009 when the test was written.
I think whatever test change needs to be done should be done in JDK-8146446 as till then this test will not be run..

ELse if you disagree, what you propose to be written in the "instructions"?

Create a new bug to improve and to clean up the test then.

At the same time, I think you should use the term “shortcut (.lnk file)” in the instructions so that it's clear.

The thing is .lnk files are known as shortcuts for most users, even though in Windows Shell API uses link internally which is reflected in the file extension.

Create a new bug to improve and to clean up the test then.

I see, there's an existing bug—JDK-8146446—against this test. Although the bug describes that memory usage somewhat grows while the background thread is running, it actually does. It has just grown for me from 100MB to 300MB. Running System.gc reduces the memory consumption to 200 MB.

aivanov-jdk · 2024-03-12T11:00:13Z

test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java

+            4. Press the Start button in the test window
+            5. Wait several minutes and observe in the Windows Task Manager
+               that Memory Usage of java process is not increasing
+            If memory usage is increasing, click Fail else click Pass .  """;


Suggested change

If memory usage is increasing, click Fail else click Pass . """;

If memory usage is increasing, click Fail else click Pass.""";

aivanov-jdk · 2024-03-12T11:00:55Z

test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java

+import javax.swing.JPanel;
+import javax.swing.JSlider;
+import javax.swing.JTextField;
+import javax.swing.SwingUtilities;


SwingUtilities is unused now.

aivanov-jdk · 2024-03-12T11:06:30Z

test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java

+
+    private static JSlider slider;
+    private static JFrame frame;
+    private static JTextField tfLink;


As I understood, testUI calls the passed method in EDT so I think it's better to init the swing variables there..

Yes, that's true, if you pass a lambda expression to testUI, it is called on EDT.

Since initialize is called from createUI, both methods will be called on EDT.

aivanov-jdk · 2024-03-12T11:09:17Z

test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java

-            folder = ShellFolder.getShellFolder(new File(tempDir));
+            folder = ShellFolder.getShellFolder(new File("."));


I wonder if it was expected that there are files in the directory. Like yes, so I could be wrong. I assumed files were created but no file is created, instead the files in this directory is listed. The expected result is that each file in the directory creates a new ShellFolder instance.

I think it's needed to have some files in the directory..
This test is problemlisted actually and as per this comment it needs to be tested on a directory with some files in it but sometimes, in CI system temp folder may have thousand of files so I think we should revert back to "java.io.tmpdir" for this test sprint and figure out the fix for the tmpdir in JDK-8146446...Any objection?

One way to handle it is to create a number of files in the current directory, the scratch directory that jtreg provides and then rely on jtreg to remove it. Or to create a temp directory in the current directory and create files there.

We have no control over how many files are in the temporary directory, however, in most cases it's not empty.

I think we should revert back to "java.io.tmpdir" for this test sprint and figure out the fix for the tmpdir in JDK-8146446...Any objection?

Sounds reasonable.

aivanov-jdk · 2024-03-12T11:09:47Z

test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java

+        PassFailJFrame.forceFail();
        throw new RuntimeException(msg);


Suggested change

PassFailJFrame.forceFail();

throw new RuntimeException(msg);

PassFailJFrame.forceFail(msg);

forceFail will throw the exception on the main thread.

aivanov-jdk · 2024-03-12T11:15:41Z

test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java

+                .instructions(INSTRUCTIONS)
+                .rows(10)


Suggested change

.instructions(INSTRUCTIONS)

.rows(10)

.instructions(INSTRUCTIONS)

.testTimeOut(10)

.rows(10)

This test will benefit from a longer time out.

openjdk · 2024-03-12T13:58:00Z

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327748: Convert javax/swing/JFileChooser/6798062/bug6798062.java applet test to main

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 94 new commits pushed to the master branch:

0776fff: 8327794: RISC-V: enable extension features based on impid (Rivos specific change)
cfd9209: 8327751: Convert javax/swing/JInternalFrame/6726866/bug6726866.java applet test to main
2cf3524: 8325433: Type annotations on primitive types are not linked
5056902: 8327361: Update some comments after JDK-8139457
78beb03: 8327750: Convert javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java applet test to main
1f43fa0: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS
013aff8: 8326606: Test javax/swing/text/BoxView/6494356/bug6494356.java performs a synchronization on a value based class
b92440f: 8247972: incorrect implementation of JVM TI GetObjectMonitorUsage
139681a: 8326497: Window.toFront() fails for iconified windows on Linux
9f7aff4: 8327788: G1: Improve concurrent reference processing documentation
... and 84 more: https://git.openjdk.org/jdk/compare/b7540df6a4279c63e69d32b9d9834f7a427478d1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

prsadhuk · 2024-03-12T15:15:57Z

/integrate

openjdk · 2024-03-12T15:16:58Z

Going to push as commit 782206b.
Since your change was applied there have been 94 commits pushed to the master branch:

0776fff: 8327794: RISC-V: enable extension features based on impid (Rivos specific change)
cfd9209: 8327751: Convert javax/swing/JInternalFrame/6726866/bug6726866.java applet test to main
2cf3524: 8325433: Type annotations on primitive types are not linked
5056902: 8327361: Update some comments after JDK-8139457
78beb03: 8327750: Convert javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java applet test to main
1f43fa0: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS
013aff8: 8326606: Test javax/swing/text/BoxView/6494356/bug6494356.java performs a synchronization on a value based class
b92440f: 8247972: incorrect implementation of JVM TI GetObjectMonitorUsage
139681a: 8326497: Window.toFront() fails for iconified windows on Linux
9f7aff4: 8327788: G1: Improve concurrent reference processing documentation
... and 84 more: https://git.openjdk.org/jdk/compare/b7540df6a4279c63e69d32b9d9834f7a427478d1...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-03-12T15:17:04Z

@prsadhuk Pushed as commit 782206b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8327748: Convert javax/swing/JFileChooser/6798062/bug6798062.java app…

0164adc

…let test to main

openjdk bot added the rfr Pull request is ready for review label Mar 11, 2024

openjdk bot added the client client-libs-dev@openjdk.org label Mar 11, 2024

kumarabhi006 reviewed Mar 11, 2024

View reviewed changes

typo

0c8ae3a

aivanov-jdk suggested changes Mar 11, 2024

View reviewed changes

aivanov-jdk reviewed Mar 11, 2024

View reviewed changes

Review comment update

71d387b

TejeshR13 reviewed Mar 12, 2024

View reviewed changes

move frame init in createUI

abd16b4

aivanov-jdk reviewed Mar 12, 2024

View reviewed changes

prsadhuk added 3 commits March 12, 2024 13:29

Revert to tempDir

d2da657

review comment update

8c8d1b9

instruction update

e994fcd

aivanov-jdk approved these changes Mar 12, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Mar 12, 2024

openjdk bot added the integrated Pull request has been integrated label Mar 12, 2024

openjdk bot closed this Mar 12, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 12, 2024

prsadhuk deleted the JDK-8327748 branch March 12, 2024 15:18


		public class bug6798062 {

		private static final String instructionsText = """

	If menory usage is increasing, click Fail else click Pass . """;
	If memory usage is increasing, click Fail else click Pass . """;

		folder = ShellFolder.getShellFolder(new File(tempDir));
		folder = ShellFolder.getShellFolder(new File("."));

	PassFailJFrame.forceFail();
	throw new RuntimeException(msg);
	PassFailJFrame.forceFail(msg);

Conversation

prsadhuk commented Mar 11, 2024 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Webrev

Uh oh!

bridgekeeper bot commented Mar 11, 2024

Uh oh!

openjdk bot commented Mar 11, 2024

Uh oh!

mlbridge bot commented Mar 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aivanov-jdk Mar 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

prsadhuk commented Mar 11, 2024 •

edited by openjdk bot

Loading

mlbridge bot commented Mar 11, 2024 •

edited

Loading

aivanov-jdk Mar 12, 2024 •

edited

Loading