Skip to content

Conversation

@prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Mar 11, 2024

Conversion of manual applet test to main based using PassFailJFrame manual framework


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8327751: Convert javax/swing/JInternalFrame/6726866/bug6726866.java applet test to main (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18186/head:pull/18186
$ git checkout pull/18186

Update a local copy of the PR:
$ git checkout pull/18186
$ git pull https://git.openjdk.org/jdk.git pull/18186/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18186

View PR using the GUI difftool:
$ git pr show -t 18186

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18186.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 11, 2024

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 11, 2024
@openjdk
Copy link

openjdk bot commented Mar 11, 2024

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 11, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 11, 2024

Webrevs

PassFailJFrame passFailJFrame = new PassFailJFrame.Builder()
.title("JInternalFrame Instructions")
.instructions(instructionsText)
.testTimeOut(5)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default timeout can be omitted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

frame.setUndecorated(true);
setWindowNonOpaque(frame);
public static void main(String[] args) throws Exception {
PassFailJFrame passFailJFrame = new PassFailJFrame.Builder()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the builder helper method instead of using new explicitly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated...

@openjdk
Copy link

openjdk bot commented Mar 12, 2024

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327751: Convert javax/swing/JInternalFrame/6726866/bug6726866.java applet test to main

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 90 new commits pushed to the master branch:

  • 78beb03: 8327750: Convert javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java applet test to main
  • 1f43fa0: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS
  • 013aff8: 8326606: Test javax/swing/text/BoxView/6494356/bug6494356.java performs a synchronization on a value based class
  • b92440f: 8247972: incorrect implementation of JVM TI GetObjectMonitorUsage
  • 139681a: 8326497: Window.toFront() fails for iconified windows on Linux
  • 9f7aff4: 8327788: G1: Improve concurrent reference processing documentation
  • 251347b: 8326139: C2 SuperWord: split packs (match use/def packs, implemented, mutual independence)
  • e21da4c: 8327486: java/util/Properties/PropertiesStoreTest.java fails "Text 'xxx' could not be parsed at index 20" after 8174269
  • 4d6235e: 8327716: RISC-V: Change type of vector_length param of several assembler functions from int to uint
  • 586396c: 8327705: Remove mention of "applet" from java.text package description
  • ... and 80 more: https://git.openjdk.org/jdk/compare/b7540df6a4279c63e69d32b9d9834f7a427478d1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 12, 2024
@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 12, 2024

Going to push as commit cfd9209.
Since your change was applied there have been 92 commits pushed to the master branch:

  • 2cf3524: 8325433: Type annotations on primitive types are not linked
  • 5056902: 8327361: Update some comments after JDK-8139457
  • 78beb03: 8327750: Convert javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java applet test to main
  • 1f43fa0: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS
  • 013aff8: 8326606: Test javax/swing/text/BoxView/6494356/bug6494356.java performs a synchronization on a value based class
  • b92440f: 8247972: incorrect implementation of JVM TI GetObjectMonitorUsage
  • 139681a: 8326497: Window.toFront() fails for iconified windows on Linux
  • 9f7aff4: 8327788: G1: Improve concurrent reference processing documentation
  • 251347b: 8326139: C2 SuperWord: split packs (match use/def packs, implemented, mutual independence)
  • e21da4c: 8327486: java/util/Properties/PropertiesStoreTest.java fails "Text 'xxx' could not be parsed at index 20" after 8174269
  • ... and 82 more: https://git.openjdk.org/jdk/compare/b7540df6a4279c63e69d32b9d9834f7a427478d1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 12, 2024
@openjdk openjdk bot closed this Mar 12, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 12, 2024
@openjdk
Copy link

openjdk bot commented Mar 12, 2024

@prsadhuk Pushed as commit cfd9209.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8327751 branch March 12, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants