-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8327751: Convert javax/swing/JInternalFrame/6726866/bug6726866.java applet test to main #18186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…pplet test to main
|
👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into |
Webrevs
|
| PassFailJFrame passFailJFrame = new PassFailJFrame.Builder() | ||
| .title("JInternalFrame Instructions") | ||
| .instructions(instructionsText) | ||
| .testTimeOut(5) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default timeout can be omitted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
| frame.setUndecorated(true); | ||
| setWindowNonOpaque(frame); | ||
| public static void main(String[] args) throws Exception { | ||
| PassFailJFrame passFailJFrame = new PassFailJFrame.Builder() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the builder helper method instead of using new explicitly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated...
|
@prsadhuk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 90 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit cfd9209.
Your commit was automatically rebased without conflicts. |
Conversion of manual applet test to main based using PassFailJFrame manual framework
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18186/head:pull/18186$ git checkout pull/18186Update a local copy of the PR:
$ git checkout pull/18186$ git pull https://git.openjdk.org/jdk.git pull/18186/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18186View PR using the GUI difftool:
$ git pr show -t 18186Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18186.diff
Webrev
Link to Webrev Comment