-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8327794: RISC-V: enable extension features based on impid (Rivos specific change) #18191
Conversation
👋 Welcome back mli! A progress list of the required criteria for merging this PR into |
@Hamlin-Li The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
Hi Hamlin, Could you please merge master? That will retrigger the GHA testing automatically and hopefully pass linux-cross-compile for linux-riscv64. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@Hamlin-Li This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change the title of the issue + PR to mention it's a Rivos specific change?
Done. |
Done. |
Hmm ... Seems that the new GHA run blocked. But the changes looks OK. |
Thanks everyone for your reviewing! /integrate |
Going to push as commit 0776fff.
Your commit was automatically rebased without conflicts. |
@Hamlin-Li Pushed as commit 0776fff. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi,
Can you review the patch? it enables extension features based on impid.
Thanks!
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18191/head:pull/18191
$ git checkout pull/18191
Update a local copy of the PR:
$ git checkout pull/18191
$ git pull https://git.openjdk.org/jdk.git pull/18191/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18191
View PR using the GUI difftool:
$ git pr show -t 18191
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18191.diff
Webrev
Link to Webrev Comment