Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8327794: RISC-V: enable extension features based on impid (Rivos specific change) #18191

Closed
wants to merge 2 commits into from

Conversation

Hamlin-Li
Copy link

@Hamlin-Li Hamlin-Li commented Mar 11, 2024

Hi,
Can you review the patch? it enables extension features based on impid.
Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8327794: RISC-V: enable extension features based on impid (Rivos specific change) (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18191/head:pull/18191
$ git checkout pull/18191

Update a local copy of the PR:
$ git checkout pull/18191
$ git pull https://git.openjdk.org/jdk.git pull/18191/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18191

View PR using the GUI difftool:
$ git pr show -t 18191

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18191.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 11, 2024

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 11, 2024
@openjdk
Copy link

openjdk bot commented Mar 11, 2024

@Hamlin-Li The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Mar 11, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 11, 2024

Webrevs

@RealFYang
Copy link
Member

RealFYang commented Mar 11, 2024

Hi Hamlin, Could you please merge master? That will retrigger the GHA testing automatically and hopefully pass linux-cross-compile for linux-riscv64.

Copy link
Contributor

@robehn robehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@openjdk
Copy link

openjdk bot commented Mar 11, 2024

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327794: RISC-V: enable extension features based on impid (Rivos specific change)

Reviewed-by: rehn, luhenry, gli, tonyp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 11, 2024
Copy link
Member

@luhenry luhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the title of the issue + PR to mention it's a Rivos specific change?

@Hamlin-Li Hamlin-Li changed the title 8327794: RISC-V: enable extension features based on impid 8327794: RISC-V: enable extension features based on impid (Rivos specific change) Mar 11, 2024
@Hamlin-Li
Copy link
Author

Hi Hamlin, Could you please merge master? That will retrigger the GHA testing automatically and hopefully pass linux-cross-compile for linux-riscv64.

Done.

@Hamlin-Li
Copy link
Author

Can you change the title of the issue + PR to mention it's a Rivos specific change?

Done.

@RealFYang
Copy link
Member

Hi Hamlin, Could you please merge master? That will retrigger the GHA testing automatically and hopefully pass linux-cross-compile for linux-riscv64.

Done.

Hmm ... Seems that the new GHA run blocked. But the changes looks OK.

@Hamlin-Li
Copy link
Author

Thanks everyone for your reviewing!

/integrate

@openjdk
Copy link

openjdk bot commented Mar 12, 2024

Going to push as commit 0776fff.
Since your change was applied there have been 20 commits pushed to the master branch:

  • cfd9209: 8327751: Convert javax/swing/JInternalFrame/6726866/bug6726866.java applet test to main
  • 2cf3524: 8325433: Type annotations on primitive types are not linked
  • 5056902: 8327361: Update some comments after JDK-8139457
  • 78beb03: 8327750: Convert javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java applet test to main
  • 1f43fa0: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS
  • 013aff8: 8326606: Test javax/swing/text/BoxView/6494356/bug6494356.java performs a synchronization on a value based class
  • b92440f: 8247972: incorrect implementation of JVM TI GetObjectMonitorUsage
  • 139681a: 8326497: Window.toFront() fails for iconified windows on Linux
  • 9f7aff4: 8327788: G1: Improve concurrent reference processing documentation
  • 251347b: 8326139: C2 SuperWord: split packs (match use/def packs, implemented, mutual independence)
  • ... and 10 more: https://git.openjdk.org/jdk/compare/680ac2cebecf93e5924a441a5de6918cd7adf118...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 12, 2024
@openjdk openjdk bot closed this Mar 12, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 12, 2024
@openjdk
Copy link

openjdk bot commented Mar 12, 2024

@Hamlin-Li Pushed as commit 0776fff.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Hamlin-Li Hamlin-Li deleted the march-mimp-ids branch March 19, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

6 participants