Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8327790: Improve javadoc for ResolvedJavaType.hasFinalizableSubclass #18192

Closed
wants to merge 2 commits into from

Conversation

dougxc
Copy link
Member

@dougxc dougxc commented Mar 11, 2024

This PR fixes and clarifies the javadoc for ResolvedJavaType.hasFinalizableSubclass().


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8327790: Improve javadoc for ResolvedJavaType.hasFinalizableSubclass (Enhancement - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18192/head:pull/18192
$ git checkout pull/18192

Update a local copy of the PR:
$ git checkout pull/18192
$ git pull https://git.openjdk.org/jdk.git pull/18192/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18192

View PR using the GUI difftool:
$ git pr show -t 18192

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18192.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 11, 2024

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 11, 2024

@dougxc The following labels will be automatically applied to this pull request:

  • graal
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels Mar 11, 2024
@dougxc dougxc marked this pull request as ready for review March 11, 2024 13:05
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 11, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 11, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 11, 2024

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327790: Improve javadoc for ResolvedJavaType.hasFinalizableSubclass

Reviewed-by: gdub, never

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 18de932: 8325991: Accelerate Poly1305 on x86_64 using AVX2 instructions
  • d74b907: 8327093: Add truncate function to BitMap API
  • ffd43c9: 8327461: KeyStore getEntry is not thread-safe
  • 680ac2c: 8327689: RISC-V: adjust test filters of zfh extension
  • 570ad67: 8269428: java/util/concurrent/ConcurrentHashMap/ToArray.java timed out

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 11, 2024
@tkrodriguez
Copy link
Contributor

Fix is a trivial improvement to JavaDoc.

@dougxc
Copy link
Member Author

dougxc commented Mar 11, 2024

Thanks for the reviews.

/integrate

@openjdk
Copy link

openjdk bot commented Mar 11, 2024

Going to push as commit b9bc31f.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 18de932: 8325991: Accelerate Poly1305 on x86_64 using AVX2 instructions
  • d74b907: 8327093: Add truncate function to BitMap API
  • ffd43c9: 8327461: KeyStore getEntry is not thread-safe
  • 680ac2c: 8327689: RISC-V: adjust test filters of zfh extension
  • 570ad67: 8269428: java/util/concurrent/ConcurrentHashMap/ToArray.java timed out

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 11, 2024
@openjdk openjdk bot closed this Mar 11, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 11, 2024
@openjdk
Copy link

openjdk bot commented Mar 11, 2024

@dougxc Pushed as commit b9bc31f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants