Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258396: SIGILL in jdk.jfr.internal.PlatformRecorder.rotateDisk() #1823

Closed
wants to merge 1 commit into from

Conversation

jbachorik
Copy link

@jbachorik jbachorik commented Dec 17, 2020

Please, review this simple change which prevents SIGILL on musl libc systems caused by using memcpy on possibly overlapping memory regions.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258396: SIGILL in jdk.jfr.internal.PlatformRecorder.rotateDisk()

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1823/head:pull/1823
$ git checkout pull/1823

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 17, 2020

👋 Welcome back jbachorik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 17, 2020

@jbachorik The following labels will be automatically applied to this pull request:

  • build
  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build build-dev@openjdk.org hotspot-jfr hotspot-jfr-dev@openjdk.org labels Dec 17, 2020
@jbachorik
Copy link
Author

/label remove build

@openjdk openjdk bot removed the build build-dev@openjdk.org label Dec 17, 2020
@openjdk
Copy link

openjdk bot commented Dec 17, 2020

@jbachorik
The build label was successfully removed.

@jbachorik jbachorik marked this pull request as ready for review December 17, 2020 16:35
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 17, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 17, 2020

Webrevs

Copy link

@mgronlun mgronlun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Dec 21, 2020

@jbachorik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258396: SIGILL in jdk.jfr.internal.PlatformRecorder.rotateDisk()

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • d234388: Merge
  • e680ebe: 8258007: Add instrumentation to NativeLibraryTest
  • c04c7e1: 8258002: Update "type" terminology in generated docs
  • 45bd3b9: 8223607: --override-methods=summary ignores some signature changes
  • 59ae054: 8258687: Build broken on Windows after fix for JDK-8258134
  • 1cc98bd: 8256693: getAnnotatedReceiverType parameterizes types too eagerly
  • 1ce2e94: 8256843: [PPC64] runtime/logging/RedefineClasses.java fails with assert: registers not saved on stack
  • 45a150b: 8258134: assert(size == calc_size) failed: incorrect size calculation on x86_32 with AVX512 machines
  • 38593a4: 8257974: Regression 21% in DaCapo-lusearch-large after JDK-8236926
  • 7afb01d: 8258373: Update the text handling in the JPasswordField
  • ... and 5 more: https://git.openjdk.java.net/jdk/compare/fa50877c2e86d1a4e00724dd29d934f52d51f42c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 21, 2020
@jbachorik
Copy link
Author

/integrate

@openjdk openjdk bot closed this Dec 21, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 21, 2020
@openjdk
Copy link

openjdk bot commented Dec 21, 2020

@jbachorik Since your change was applied there have been 15 commits pushed to the master branch:

  • d234388: Merge
  • e680ebe: 8258007: Add instrumentation to NativeLibraryTest
  • c04c7e1: 8258002: Update "type" terminology in generated docs
  • 45bd3b9: 8223607: --override-methods=summary ignores some signature changes
  • 59ae054: 8258687: Build broken on Windows after fix for JDK-8258134
  • 1cc98bd: 8256693: getAnnotatedReceiverType parameterizes types too eagerly
  • 1ce2e94: 8256843: [PPC64] runtime/logging/RedefineClasses.java fails with assert: registers not saved on stack
  • 45a150b: 8258134: assert(size == calc_size) failed: incorrect size calculation on x86_32 with AVX512 machines
  • 38593a4: 8257974: Regression 21% in DaCapo-lusearch-large after JDK-8236926
  • 7afb01d: 8258373: Update the text handling in the JPasswordField
  • ... and 5 more: https://git.openjdk.java.net/jdk/compare/fa50877c2e86d1a4e00724dd29d934f52d51f42c...master

Your commit was automatically rebased without conflicts.

Pushed as commit a06cea5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jbachorik jbachorik deleted the jb/8258396_memmove branch December 21, 2020 11:47
@jbachorik
Copy link
Author

/backport jdk16u

@openjdk
Copy link

openjdk bot commented Jan 12, 2021

@jbachorik Unknown command backport - for a list of valid commands use /help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
2 participants