8327980: Convert javax/swing/JToggleButton/4128979/bug4128979.java applet test to main #18233

kumarabhi006 · 2024-03-12T12:49:06Z

Conversion of manual applet test to main based using PassFailJFrame manual framework

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8327980: Convert javax/swing/JToggleButton/4128979/bug4128979.java applet test to main (Bug - P4)

Reviewers

Harshitha Onkar (@honkar-jdk - Reviewer)
Tejesh R (@TejeshR13 - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18233/head:pull/18233
$ git checkout pull/18233

Update a local copy of the PR:
$ git checkout pull/18233
$ git pull https://git.openjdk.org/jdk.git pull/18233/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18233

View PR using the GUI difftool:
$ git pr show -t 18233

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18233.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-03-12T12:49:53Z

👋 Welcome back abhiscxk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-03-12T12:50:50Z

@kumarabhi006 The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-03-12T12:56:20Z

Webrevs

honkar-jdk · 2024-03-13T01:19:39Z

test/jdk/javax/swing/JToggleButton/4128979/bug4128979.java

+        frame.getContentPane().add(label);
+        frame.setSize(600, 250);
+        frame.setDefaultCloseOperation(WindowConstants.EXIT_ON_CLOSE);
+        frame.setVisible(true);


frame.setVisible(true); redundant can be removed.

honkar-jdk · 2024-03-13T01:20:05Z

test/jdk/javax/swing/JToggleButton/4128979/bug4128979.java

-
-        setLayout(new FlowLayout());
+    public static JFrame createAndShowUI() {
+        frame = new JFrame("Test window");


Frame title can be more descriptive.

openjdk · 2024-03-13T20:10:08Z

@kumarabhi006 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327980: Convert javax/swing/JToggleButton/4128979/bug4128979.java applet test to main

Reviewed-by: honkar, tr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 212 new commits pushed to the master branch:

4d36c4a: 8328285: GetOwnedMonitorInfo functions should use JvmtiHandshake
0efd9dc: 8328398: Convert java/awt/im/4490692/bug4490692.html applet test to main
46809b3: 8324736: Invalid end positions for EMPTY_STATEMENT
f7f291c: 8328301: Convert Applet test ManualHTMLDataFlavorTest.java to main program
771f6a2: 8327704: Update nsk/jdi tests to use driver instead of othervm
4210e50: 8320362: Load anchor certificates from Keychain keystore
ab183e4: 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main
ab28045: 8328316: Finisher cannot emit if stream is sequential and integrator returned false
ba05c6d: 8328368: Convert java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet test to main
fa823bd: 8328540: test javax/swing/JSplitPane/4885629/bug4885629.java fails on windows hidpi
... and 202 more: https://git.openjdk.org/jdk/compare/f2b5ffdb8ea3c766f14bab1dfd7c3865cffa2ce8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

kumarabhi006 · 2024-03-14T16:07:34Z

@honkar-jdk Updated as per last review. Please take a look.

honkar-jdk

Please remove unused imports

honkar-jdk · 2024-03-14T17:04:22Z

test/jdk/javax/swing/JToggleButton/bug4128979.java

+            the test fails. """;
+
+    public static void main(String[] args) throws Exception {
+        UIManager.setLookAndFeel("com.sun.java.swing.plaf.windows.WindowsClassicLookAndFeel");


As the test is for Windows only it is good to have OS check along with the @requires (os.family == "windows") and throw skipped exception otherwise.

Since it is followed by setting WindowsClassicLookAndFeel all the more reason to include this check.

Suggested change

UIManager.setLookAndFeel("com.sun.java.swing.plaf.windows.WindowsClassicLookAndFeel");

if (OSInfo.getOSType() != OSInfo.OSType.WINDOWS) {

throw new SkippedException("This test is for Windows only");

}

UIManager.setLookAndFeel("com.sun.java.swing.plaf.windows.WindowsClassicLookAndFeel");

You can remove the OS check here if you would like to, since it is not strictly required when run as jtreg test (which is essentially the case here).

I will keep this check as of now.

kumarabhi006 · 2024-03-18T11:53:29Z

@honkar-jdk Please take a look.

TejeshR13 · 2024-03-20T06:32:26Z

test/jdk/javax/swing/JToggleButton/bug4128979.java

+ * @build PassFailJFrame jtreg.SkippedException
+ * @summary Tests that background changes correctly in WinLF for JToggleButton when pressed
+ * @run main/manual bug4128979
+ */


Move it after imports.

Updated but placing of imports is still confusing.

TejeshR13 · 2024-03-20T06:37:13Z

test/jdk/javax/swing/JToggleButton/bug4128979.java

-        applet.init();
-        applet.start();
+public class bug4128979 {
+    private static JFrame frame;


frame can be moved inside createAndShowUI().

TejeshR13 · 2024-03-20T06:38:23Z

test/jdk/javax/swing/JToggleButton/bug4128979.java

-        } catch (Exception e) {
-            throw new RuntimeException("Couldn't set look and feel");
+            If the background color does not change correctly for at least one button,
+            the test fails. """;


Getting a white space after fails., can you check once.

Not a problem though since it is part of instruction. Anyways removed extra space.

kumarabhi006 · 2024-03-21T07:29:27Z

@honkar-jdk @TejeshR13 Test is updated. Please take a look.

TejeshR13

Looks good now.

honkar-jdk

Updated changes look good.

kumarabhi006 · 2024-03-22T03:39:55Z

/integrate

openjdk · 2024-03-22T03:40:35Z

Going to push as commit 256d48b.
Since your change was applied there have been 214 commits pushed to the master branch:

177b8a2: 8327840: Automate javax/swing/border/Test4129681.java
da00921: 8320404: Double whitespace in SubTypeCheckNode::dump_spec output
4d36c4a: 8328285: GetOwnedMonitorInfo functions should use JvmtiHandshake
0efd9dc: 8328398: Convert java/awt/im/4490692/bug4490692.html applet test to main
46809b3: 8324736: Invalid end positions for EMPTY_STATEMENT
f7f291c: 8328301: Convert Applet test ManualHTMLDataFlavorTest.java to main program
771f6a2: 8327704: Update nsk/jdi tests to use driver instead of othervm
4210e50: 8320362: Load anchor certificates from Keychain keystore
ab183e4: 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main
ab28045: 8328316: Finisher cannot emit if stream is sequential and integrator returned false
... and 204 more: https://git.openjdk.org/jdk/compare/f2b5ffdb8ea3c766f14bab1dfd7c3865cffa2ce8...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-03-22T03:40:43Z

@kumarabhi006 Pushed as commit 256d48b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Applet test converted to main manual

0151984

openjdk bot added the client client-libs-dev@openjdk.org label Mar 12, 2024

whitespace fix

104ad50

openjdk bot added the rfr Pull request is ready for review label Mar 12, 2024

honkar-jdk suggested changes Mar 13, 2024

View reviewed changes

Review comment fix

6131896

honkar-jdk suggested changes Mar 14, 2024

View reviewed changes

kumarabhi006 added 2 commits March 14, 2024 23:27

Added OS check and remove unused imports

bd1aaf2

jtreg manual tag update

4e5c83d

kumarabhi006 mentioned this pull request Mar 18, 2024

JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to main #18312

Closed

3 tasks

TejeshR13 reviewed Mar 20, 2024

View reviewed changes

Review comment update

90ba58c

TejeshR13 approved these changes Mar 21, 2024

View reviewed changes

honkar-jdk approved these changes Mar 22, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Mar 22, 2024

openjdk bot added the integrated Pull request has been integrated label Mar 22, 2024

openjdk bot closed this Mar 22, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8327980: Convert javax/swing/JToggleButton/4128979/bug4128979.java applet test to main #18233

8327980: Convert javax/swing/JToggleButton/4128979/bug4128979.java applet test to main #18233

kumarabhi006 commented Mar 12, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Mar 12, 2024

openjdk bot commented Mar 12, 2024

mlbridge bot commented Mar 12, 2024 •

edited

Loading

honkar-jdk Mar 13, 2024

honkar-jdk Mar 13, 2024

kumarabhi006 Mar 13, 2024

openjdk bot commented Mar 13, 2024 •

edited

Loading

kumarabhi006 commented Mar 14, 2024

honkar-jdk left a comment

honkar-jdk Mar 14, 2024 •

edited

Loading

kumarabhi006 Mar 14, 2024

honkar-jdk Mar 18, 2024

kumarabhi006 Mar 19, 2024

kumarabhi006 commented Mar 18, 2024

TejeshR13 Mar 20, 2024

kumarabhi006 Mar 20, 2024

TejeshR13 Mar 20, 2024

kumarabhi006 Mar 20, 2024

TejeshR13 Mar 20, 2024

kumarabhi006 Mar 20, 2024

kumarabhi006 commented Mar 21, 2024

TejeshR13 left a comment

honkar-jdk left a comment

kumarabhi006 commented Mar 22, 2024

openjdk bot commented Mar 22, 2024

openjdk bot commented Mar 22, 2024

8327980: Convert javax/swing/JToggleButton/4128979/bug4128979.java applet test to main #18233

8327980: Convert javax/swing/JToggleButton/4128979/bug4128979.java applet test to main #18233

Conversation

kumarabhi006 commented Mar 12, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Mar 12, 2024

openjdk bot commented Mar 12, 2024

mlbridge bot commented Mar 12, 2024 • edited Loading

Webrevs

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openjdk bot commented Mar 13, 2024 • edited Loading

kumarabhi006 commented Mar 14, 2024

honkar-jdk left a comment

Choose a reason for hiding this comment

honkar-jdk Mar 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kumarabhi006 commented Mar 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kumarabhi006 commented Mar 21, 2024

TejeshR13 left a comment

Choose a reason for hiding this comment

honkar-jdk left a comment

Choose a reason for hiding this comment

kumarabhi006 commented Mar 22, 2024

openjdk bot commented Mar 22, 2024

openjdk bot commented Mar 22, 2024

kumarabhi006 commented Mar 12, 2024 •

edited by openjdk bot

Loading

mlbridge bot commented Mar 12, 2024 •

edited

Loading

openjdk bot commented Mar 13, 2024 •

edited

Loading

honkar-jdk Mar 14, 2024 •

edited

Loading