8327989: java/net/httpclient/ManyRequest.java should not use "localhost" in URIs

[dfuch]

Please find here a trivial test fix that removes usage of "localhost" from ManyRequest.java.
Use of "localhost" in test URIs is problematic as it leaves the test open to random failure when running on machines that have custom mappings for "localhost". The fix is to use the IP literal of the loopback address instead.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8327989: java/net/httpclient/ManyRequest.java should not use "localhost" in URIs (Sub-task - P4)

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer) ⚠️ Review applies to 9b82022d
• Daniel Jeliński (@djelinski - Reviewer)
• Guoxiong Li (@lgxbslgx - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18239/head:pull/18239
$ git checkout pull/18239

Update a local copy of the PR:
$ git checkout pull/18239
$ git pull https://git.openjdk.org/jdk.git pull/18239/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18239

View PR using the GUI difftool:
$ git pr show -t 18239

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18239.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dfuch The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (e2dc2b4f)
• 01: Full - Incremental (9b82022d)
• 00: Full (2c6ec79a)

[jaikiran]

The change looks good to me. The copyright year on the file would need an update before integrating.

[openjdk]

@dfuch This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327989: java/net/httpclient/ManyRequest.java should not use "localhost" in URIs

Reviewed-by: jpai, djelinski, gli

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

• 5d4bfad: 8327693: C1: LIRGenerator::_instruction_for_operand is only read by assertion code
• f3d0c45: 8327829: [JVMCI] runtime/ClassUnload/ConstantPoolDependsTest.java fails on libgraal
• d5b95a0: 8327631: Update IANA Language Subtag Registry to Version 2024-03-07
• 966a42f: 8324868: debug agent does not properly handle interrupts of a virtual thread
• 22f10e0: 8327856: Convert applet test SpanishDiacriticsTest.java to a main program
• 7283c8b: 8327972: Convert java/awt/FileDialog/SaveFileNameOverrideTest/SaveFileNameOverrideTest.html applet test to main
• 30249c4: 8327838: Convert java/awt/FileDialog/MultipleMode/MultipleMode.html applet test to main
• 94b4ed5: 8327096: (fc) java/nio/channels/FileChannel/Size.java fails on partition incapable of creating large files
• b9c3dc3: 8327738: Remove unused internal method sun.n.w.p.h.HttpURLConnection.setDefaultAuthenticator
• 5b41466: 8327729: Remove deprecated xxxObject methods from jdk.internal.misc.Unsafe
• ... and 5 more: https://git.openjdk.org/jdk/compare/0776fff0e321c3f541354404b3ec0aa1992923a0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dfuch]

The change looks good to me. The copyright year on the file would need an update before integrating.

Thanks Jaikiran. Done.

[dfuch]

/integrate

[openjdk]

Going to push as commit da4dd7c.
Since your change was applied there have been 21 commits pushed to the master branch:

• 49d8008: 8327452: G1: Improve scalability of Merge Log Buffers
• 0ae4fa7: 8327210: AIX: Delete obsolete parameter Use64KPagesThreshold
• 107cb53: 8327701: Remove the xlc toolchain
• 07acc0b: 8326385: [aarch64] C2: lightweight locking nodes kill the box register without specifying this effect
• cc9a8ab: 8327460: Compile tests with the same visibility rules as product code
• 3b18c5d: 8323605: Java source launcher should not require --source ... to enable preview
• 5d4bfad: 8327693: C1: LIRGenerator::_instruction_for_operand is only read by assertion code
• f3d0c45: 8327829: [JVMCI] runtime/ClassUnload/ConstantPoolDependsTest.java fails on libgraal
• d5b95a0: 8327631: Update IANA Language Subtag Registry to Version 2024-03-07
• 966a42f: 8324868: debug agent does not properly handle interrupts of a virtual thread
• ... and 11 more: https://git.openjdk.org/jdk/compare/0776fff0e321c3f541354404b3ec0aa1992923a0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dfuch Pushed as commit da4dd7c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.