Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258524: Instrumented EventHandler calls private instance method EventWriter.reset #1824

Closed
wants to merge 1 commit into from

Conversation

jiekang
Copy link
Contributor

@jiekang jiekang commented Dec 17, 2020

This resolves the issue by making the method public.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258524: Instrumented EventHandler calls private instance method EventWriter.reset

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1824/head:pull/1824
$ git checkout pull/1824

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 17, 2020

👋 Welcome back jkang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 17, 2020
@openjdk
Copy link

openjdk bot commented Dec 17, 2020

@jiekang The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Dec 17, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 17, 2020

Webrevs

Copy link

@mgronlun mgronlun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@openjdk
Copy link

openjdk bot commented Dec 17, 2020

@jiekang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258524: Instrumented EventHandler calls private instance method EventWriter.reset

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

  • 7b05439: 8258057: serviceability/attach/RemovingUnixDomainSocketTest.java doesn't ignore VM warnings
  • 143998e: 8248383: Clarify java.io.Reader.read(char[], ...) behavior for full array
  • 8251b74: 8257530: vmTestbase/metaspace/stressDictionary/StressDictionary.java timed out
  • 6aa8eed: 8258415: gtest for committed memory leaks reservation
  • 83be8a9: 8247732: validate user-input intrinsic_ids in ControlIntrinsic
  • 178c001: 8258479: Minor cleanups in VMError
  • c11525a: 8257772: Vectorizing clear memory operation using AVX-512 masked operations
  • d77b49d: 8258233: Reenable another fixed problemlisted test
  • 513269d: 8196093: javax/swing/JComboBox/8072767/bug8072767.java fails
  • 643ddc1: 8257882: Implement linkToNative intrinsic on AArch64
  • ... and 23 more: https://git.openjdk.java.net/jdk/compare/6eca29600dc6a0db8b36629f4276d52402b2cb23...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mgronlun) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 17, 2020
@jiekang
Copy link
Contributor Author

jiekang commented Dec 17, 2020

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 17, 2020
@openjdk
Copy link

openjdk bot commented Dec 17, 2020

@jiekang
Your change (at version 57c977a) is now ready to be sponsored by a Committer.

@mgronlun
Copy link

/sponsor

@openjdk openjdk bot closed this Dec 17, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 17, 2020
@openjdk
Copy link

openjdk bot commented Dec 17, 2020

@mgronlun @jiekang Since your change was applied there have been 35 commits pushed to the master branch:

  • 6e824b3: 8258408: SystemDictionary passes TRAPS to functions that don't throw exceptions
  • 9ed0b76: 8254850: Update terminology in java.awt.GridBagLayout source code comments
  • 7b05439: 8258057: serviceability/attach/RemovingUnixDomainSocketTest.java doesn't ignore VM warnings
  • 143998e: 8248383: Clarify java.io.Reader.read(char[], ...) behavior for full array
  • 8251b74: 8257530: vmTestbase/metaspace/stressDictionary/StressDictionary.java timed out
  • 6aa8eed: 8258415: gtest for committed memory leaks reservation
  • 83be8a9: 8247732: validate user-input intrinsic_ids in ControlIntrinsic
  • 178c001: 8258479: Minor cleanups in VMError
  • c11525a: 8257772: Vectorizing clear memory operation using AVX-512 masked operations
  • d77b49d: 8258233: Reenable another fixed problemlisted test
  • ... and 25 more: https://git.openjdk.java.net/jdk/compare/6eca29600dc6a0db8b36629f4276d52402b2cb23...master

Your commit was automatically rebased without conflicts.

Pushed as commit 763623d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
2 participants