8327998: Enable java/lang/ProcessBuilder/JspawnhelperProtocol.java on Mac

[elifaslan1]

This change enables to run JspawnhelperProtocol.java on MacOS.

In addition to GHA , the test has been run on macos and linux.

Test report is stored in build/macosx-x86_64-server-fastdebug/test-results/jtreg_test_jdk_java_lang_ProcessBuilder_JspawnhelperProtocol_java

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR
   jtreg:test/jdk/java/lang/ProcessBuilder/JspawnhelperProtocol.java
                                                         1     1     0     0
==============================
TEST SUCCESS

Finished building target 'test' in configuration 'macosx-x86_64-server-fastdebug'

Test report is stored in build/linux-x86_64-server-fastdebug/test-results/jtreg_test_jdk_java_lang_ProcessBuilder_JspawnhelperProtocol_java

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR
   jtreg:test/jdk/java/lang/ProcessBuilder/JspawnhelperProtocol.java
                                                         1     1     0     0
==============================
TEST SUCCESS

Stopping javac server
[ec2-user@ip-172-16-0-10 jdk]$ make test CONF=linux-x86_64-server-fastdebug TEST=test/jdk/java/lang/ProcessBuilder/JspawnhelperProtocol.java

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8327998: Enable java/lang/ProcessBuilder/JspawnhelperProtocol.java on Mac (Enhancement - P4)

Reviewers

• Guoxiong Li (@lgxbslgx - Committer)
• Aleksey Shipilev (@shipilev - Reviewer)
• Roger Riggs (@RogerRiggs - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18253/head:pull/18253
$ git checkout pull/18253

Update a local copy of the PR:
$ git checkout pull/18253
$ git pull https://git.openjdk.org/jdk.git pull/18253/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18253

View PR using the GUI difftool:
$ git pr show -t 18253

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18253.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back elifaslan1! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@elifaslan1 The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (f17db2ab)

[elifaslan1]

/approval request This change enables to run JspawnhelperProtocol.java on MacOS. In addition to GHA , the test has been run on macos and linux.

[openjdk]

@elifaslan1 Changes in this repository do not require maintainer approval.

[lgxbslgx]

/approval request This change enables to run JspawnhelperProtocol.java on MacOS. In addition to GHA , the test has been run on macos and linux.

The approval command can only be used at a backport PR. Just a reminder.

[lgxbslgx]

LGTM.

[shipilev]

Looks fine, thanks!

[openjdk]

@elifaslan1 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327998: Enable java/lang/ProcessBuilder/JspawnhelperProtocol.java on Mac

Reviewed-by: gli, shade, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 223 new commits pushed to the master branch:

• 907e30f: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket
• 70a15c7: 8328825: Google CAInterop test failures
• a1fbbff: 8328717: Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to main
• 26b2ec4: 8328824: Clean up java.base native compilation
• af15c68: 8321278: C2: Partial peeling fails with assert "last_peel <- first_not_peeled"
• 142c311: 8328744: Parallel: Parallel GC throws OOM before heap is fully expanded
• cb2a671: 8324121: SIGFPE in PhaseIdealLoop::extract_long_range_checks
• 0c1b254: 8326438: C2: assert(ld->in(1)->Opcode() == Op_LoadN) failed: Assumption invalid: input to DecodeN is not LoadN
• 29ba4b7: 8328705: GHA: Cross-compilation jobs do not require build JDK
• f67ec19: 8079786: [macosx] Test java/awt/Frame/DisposeParentGC/DisposeParentGC.java fails for Mac only
• ... and 213 more: https://git.openjdk.org/jdk/compare/22f10e045b3decdb51a3cc7644c47f911aec753d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@lgxbslgx, @shipilev, @RogerRiggs) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[RogerRiggs]

LGTM
Just a reminder to keep that the PR description is copied into every email sent so it should be concise.
Extended descriptions and additional details should be added in a separate comment.

[elifaslan1]

/integrate

[openjdk]

@elifaslan1
Your change (at version f17db2a) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit cc1800f.
Since your change was applied there have been 236 commits pushed to the master branch:

• b9c76de: 8329074: AIX build fails after JDK-8328824
• 7b1f2c8: 8327493: Update minimum Xcode version in docs
• 9d441e3: 8283223: gc/stringdedup/TestStringDeduplicationFullGC.java#Parallel failed with "RuntimeException: String verification failed"
• 44549b6: 8329012: IGV: Update required JDK version in README.md
• 5d19d15: 8325186: JVMTI VirtualThreadGetThreadStateClosure class is no longer used and should be removed
• 5f7432f: 8328758: GetCurrentContendedMonitor function should use JvmtiHandshake
• 7560dbb: 8316324: Opensource five miscellaneous Swing tests
• 4047a36: 8328730: Convert java/awt/print/bug8023392/bug8023392.html applet test to main
• 27ac39a: 8328719: Convert java/awt/print/PageFormat/SetOrient.html applet test to main
• fb8f2a0: 8328562: Convert java/awt/InputMethods/DiacriticsTest/DiacriticsTest.java applet test to main
• ... and 226 more: https://git.openjdk.org/jdk/compare/22f10e045b3decdb51a3cc7644c47f911aec753d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @elifaslan1 Pushed as commit cc1800f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.