Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8327754: Convert javax/swing/JPopupMenu/7160604/bug7160604.java applet to main #18257

Closed
wants to merge 2 commits into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Mar 13, 2024

Conversion of manual applet test to main based using PassFailJFrame manual framework


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8327754: Convert javax/swing/JPopupMenu/7160604/bug7160604.java applet to main (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18257/head:pull/18257
$ git checkout pull/18257

Update a local copy of the PR:
$ git checkout pull/18257
$ git pull https://git.openjdk.org/jdk.git pull/18257/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18257

View PR using the GUI difftool:
$ git pr show -t 18257

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18257.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 13, 2024

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 13, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 13, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 13, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327754: Convert javax/swing/JPopupMenu/7160604/bug7160604.java applet to main

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 125 new commits pushed to the master branch:

  • 5cae7d2: 8321299: runtime/logging/ClassLoadUnloadTest.java doesn't reliably trigger class unloading
  • 35b00e6: 8327824: Type annotation placed on incorrect array nesting levels
  • be344e4: 8327475: Add analysis code for JDK-8327169
  • 0db6231: 8314508: Improve how relativized pointers are printed by frame::describe
  • 0353245: 8325874: Improve checkbox-based interface in summary pages
  • 4d64467: 8328079: JDK-8326583 broke ccache compilation
  • 7e05a70: 8251330: Reorder CDS archived heap to speed up relocation
  • 7d8561d: 8327109: Refactor data graph cloning used in create_new_if_for_predicate() into separate class
  • a4a5196: 8327872: Convert javax/swing/JToolTip/4644444/bug4644444.java applet test to main
  • da4dd7c: 8327989: java/net/httpclient/ManyRequest.java should not use "localhost" in URIs
  • ... and 115 more: https://git.openjdk.org/jdk/compare/b7540df6a4279c63e69d32b9d9834f7a427478d1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 13, 2024
@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 14, 2024

Going to push as commit 628e770.
Since your change was applied there have been 132 commits pushed to the master branch:

  • 092a734: 8327753: Convert javax/swing/JOptionPane/8024926/bug8024926.java applet to main
  • 7858138: 8327752: Convert javax/swing/JOptionPane/4174551/bug4174551.java applet to main
  • 2edf408: 8328004: Minor updates to TrayIcon test DisposeInActionEventTest.java
  • 1ad3ebc: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185
  • 7f6b7eb: 8327242: Document supported CLDR versions in the javadoc
  • 8f9899b: 8325164: Named groups and signature schemes unavailable with SunPKCS11 in FIPS mode
  • eb45d5b: 8327999: Remove copy of unused registers for cpu features check in x86_64 AVX2 Poly1305 implementation
  • 5cae7d2: 8321299: runtime/logging/ClassLoadUnloadTest.java doesn't reliably trigger class unloading
  • 35b00e6: 8327824: Type annotation placed on incorrect array nesting levels
  • be344e4: 8327475: Add analysis code for JDK-8327169
  • ... and 122 more: https://git.openjdk.org/jdk/compare/b7540df6a4279c63e69d32b9d9834f7a427478d1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 14, 2024
@openjdk openjdk bot closed this Mar 14, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 14, 2024
@openjdk
Copy link

openjdk bot commented Mar 14, 2024

@prsadhuk Pushed as commit 628e770.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8327754 branch March 14, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants