Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8225072: Add LuxTrust certificate that is expiring in March 2021 to list of allowed but expired certs #1826

Closed
wants to merge 1 commit into from

Conversation

@rhalade
Copy link
Member

@rhalade rhalade commented Dec 17, 2020

… certificates


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8225072: Add LuxTrust certificate that is expiring in March 2021 to list of allowed but expired certs
  • JDK-8258630: Add expiry exception for QuoVadis root certificate

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1826/head:pull/1826
$ git checkout pull/1826

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 17, 2020

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 17, 2020

@rhalade The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security label Dec 17, 2020
@rhalade
Copy link
Member Author

@rhalade rhalade commented Dec 17, 2020

/add JDK-8258630

@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 17, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Dec 17, 2020

@rhalade Unknown command add - for a list of valid commands use /help.

@rhalade
Copy link
Member Author

@rhalade rhalade commented Dec 17, 2020

/help

@openjdk
Copy link

@openjdk openjdk bot commented Dec 17, 2020

@rhalade Available commands:

  • cc - add or remove an additional classification label
  • contributor - adds or removes additional contributors for a PR
  • covered - used when employer has signed the OCA
  • csr - require a compatibility and specification request (CSR) for this pull request
  • help - shows this text
  • integrate - performs integration of the changes in the PR
  • issue - edit the list of issues that this PR solves
  • label - add or remove an additional classification label
  • reviewer - manage additional reviewers for a PR
  • reviewers - set the number of additional required reviewers for this PR
  • signed - used after signing the OCA
  • solves - edit the list of issues that this PR solves
  • sponsor - performs integration of a PR that is authored by a non-committer
  • summary - updates the summary in the commit message
  • test - used to run tests
@rhalade
Copy link
Member Author

@rhalade rhalade commented Dec 17, 2020

/issue 8225072, 8258630

@openjdk openjdk bot changed the title 8225072, 8258630: Add expiry exception for LuxTrust and QuoVadis root certificates 8225072: Add LuxTrust certificate that is expiring in March 2021 to list of allowed but expired certs Dec 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 17, 2020

@rhalade This issue is referenced in the PR title - it will now be updated.

Adding additional issue to issue list: 8258630: Add expiry exception for QuoVadis root certificate.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 17, 2020

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8225072: Add LuxTrust certificate that is expiring in March 2021 to list of allowed but expired certs
8258630: Add expiry exception for QuoVadis root certificate

Reviewed-by: ascarpino

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • b0b70df: 8246005: KeyStoreSpi::engineStore(LoadStoreParameter) spec mismatch to its behavior
  • 763623d: 8258524: Instrumented EventHandler calls private instance method EventWriter.reset
  • 6e824b3: 8258408: SystemDictionary passes TRAPS to functions that don't throw exceptions

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 17, 2020
@rhalade
Copy link
Member Author

@rhalade rhalade commented Dec 17, 2020

/integrate

@openjdk openjdk bot closed this Dec 17, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 17, 2020

@rhalade Since your change was applied there have been 3 commits pushed to the master branch:

  • b0b70df: 8246005: KeyStoreSpi::engineStore(LoadStoreParameter) spec mismatch to its behavior
  • 763623d: 8258524: Instrumented EventHandler calls private instance method EventWriter.reset
  • 6e824b3: 8258408: SystemDictionary passes TRAPS to functions that don't throw exceptions

Your commit was automatically rebased without conflicts.

Pushed as commit 666e6c4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@rhalade rhalade deleted the rhalade:8225072 branch Dec 17, 2020
@rhalade
Copy link
Member Author

@rhalade rhalade commented Dec 17, 2020

/backport 666e6c4

@openjdk
Copy link

@openjdk openjdk bot commented Dec 17, 2020

@rhalade Unknown command backport - for a list of valid commands use /help.

@rhalade
Copy link
Member Author

@rhalade rhalade commented Dec 17, 2020

/backport jdk16

@openjdk
Copy link

@openjdk openjdk bot commented Dec 17, 2020

@rhalade Unknown command backport - for a list of valid commands use /help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants