-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8328037: Test java/util/Formatter/Padding.java has unnecessary high heap requirement after JDK-8326718 #18264
Conversation
👋 Welcome back clanger! A progress list of the required criteria for merging this PR into |
@RealCLanger The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
What about factoring out the 4 invocations of |
L.26-27 to
|
OK, I inlined the generation of the ten million character strings into the parameter generator methods. I looked a bit at the test runtime and it seems like it doesn't make a lot of difference in a test JVM with larger heap but for smaller test VMs it seems to improve things. |
I was thinking more something like
and similarly for Can you please add the bug id to Otherwise looks fine. |
@RealCLanger This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 34 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Done. I kept the tenMillion... handling. |
Thanks, @rgiulietti for reviewing this. /integrate |
Going to push as commit 128e60a.
Your commit was automatically rebased without conflicts. |
@RealCLanger Pushed as commit 128e60a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
4f33608 (JDK-8326718) added a few cases to test java/util/Formatter/Padding.java with huge Strings as arguments. Since all possible argument combinations for the test are stored in one array, nothing can be garbage collected while the test is running and the heap requirement is blown up.
In one of our test pipelines we run tier1 tests with VMs that default to 384M of heap and this is not sufficient any longer.
I'm improving this by splitting the one large @ParameterizedTest into multiple ones. With that, I could run the test successfully in a test VM with 96M of heap, e.g. by modifying
@run junit Padding
to@run junit/othervm -Xmx96m Padding
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18264/head:pull/18264
$ git checkout pull/18264
Update a local copy of the PR:
$ git checkout pull/18264
$ git pull https://git.openjdk.org/jdk.git pull/18264/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18264
View PR using the GUI difftool:
$ git pr show -t 18264
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18264.diff
Webrev
Link to Webrev Comment