8328064: Remove obsolete comments in constantPool and metadataFactory

[linade]

Clean up some obsolete comments:
After 8243287, there is no longer the concept of "pseudo-string";
After 8072061, the "read_only" argument that the comment is referring to is removed.

Cheers

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8328064: Remove obsolete comments in constantPool and metadataFactory (Enhancement - P4)

Reviewers

• Coleen Phillimore (@coleenp - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18266/head:pull/18266
$ git checkout pull/18266

Update a local copy of the PR:
$ git checkout pull/18266
$ git pull https://git.openjdk.org/jdk.git pull/18266/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18266

View PR using the GUI difftool:
$ git pr show -t 18266

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18266.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back linade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@linade The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (77849785)

[coleenp]

Looks good and also trivial. Thanks for the cleanup.

[openjdk]

@linade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328064: Remove obsolete comments in constantPool and metadataFactory

Reviewed-by: coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 99 new commits pushed to the master branch:

• 7502dc9: 8328030: Convert javax/swing/text/GlyphView/4984669/bug4984669.java applet test to main
• 357c912: 8325897: Parallel: Remove PSYoungGen::is_maximal_no_gc
• 98e4b75: 8327755: Convert javax/swing/JScrollBar/8039464/Test8039464.java applet to main
• 628e770: 8327754: Convert javax/swing/JPopupMenu/7160604/bug7160604.java applet to main
• 092a734: 8327753: Convert javax/swing/JOptionPane/8024926/bug8024926.java applet to main
• 7858138: 8327752: Convert javax/swing/JOptionPane/4174551/bug4174551.java applet to main
• 2edf408: 8328004: Minor updates to TrayIcon test DisposeInActionEventTest.java
• 1ad3ebc: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185
• 7f6b7eb: 8327242: Document supported CLDR versions in the javadoc
• 8f9899b: 8325164: Named groups and signature schemes unavailable with SunPKCS11 in FIPS mode
• ... and 89 more: https://git.openjdk.org/jdk/compare/401834122dc3afb3feb9f7b31fc785de82ba2e58...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@coleenp) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[linade]

/integrate

[openjdk]

@linade
Your change (at version 7784978) is now ready to be sponsored by a Committer.

[D-D-H]

/sponser

[openjdk]

@D-D-H Unknown command sponser - for a list of valid commands use /help.

[D-D-H]

/sponsor

[openjdk]

Going to push as commit 6f2676d.
Since your change was applied there have been 99 commits pushed to the master branch:

• 7502dc9: 8328030: Convert javax/swing/text/GlyphView/4984669/bug4984669.java applet test to main
• 357c912: 8325897: Parallel: Remove PSYoungGen::is_maximal_no_gc
• 98e4b75: 8327755: Convert javax/swing/JScrollBar/8039464/Test8039464.java applet to main
• 628e770: 8327754: Convert javax/swing/JPopupMenu/7160604/bug7160604.java applet to main
• 092a734: 8327753: Convert javax/swing/JOptionPane/8024926/bug8024926.java applet to main
• 7858138: 8327752: Convert javax/swing/JOptionPane/4174551/bug4174551.java applet to main
• 2edf408: 8328004: Minor updates to TrayIcon test DisposeInActionEventTest.java
• 1ad3ebc: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185
• 7f6b7eb: 8327242: Document supported CLDR versions in the javadoc
• 8f9899b: 8325164: Named groups and signature schemes unavailable with SunPKCS11 in FIPS mode
• ... and 89 more: https://git.openjdk.org/jdk/compare/401834122dc3afb3feb9f7b31fc785de82ba2e58...master

Your commit was automatically rebased without conflicts.

[openjdk]

@D-D-H @linade Pushed as commit 6f2676d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.