8328087: Automate javax/swing/JTable/TAB/TAB.java applet test #18274

kumarabhi006 · 2024-03-13T13:26:46Z

Conversion of manual applet test to automated test. CI testing is green. Link attached to JBS.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8328087: Automate javax/swing/JTable/TAB/TAB.java applet test (Bug - P4)

Reviewers

Harshitha Onkar (@honkar-jdk - Reviewer) ⚠️ Review applies to 0a6e5acb
Tejesh R (@TejeshR13 - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18274/head:pull/18274
$ git checkout pull/18274

Update a local copy of the PR:
$ git checkout pull/18274
$ git pull https://git.openjdk.org/jdk.git pull/18274/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18274

View PR using the GUI difftool:
$ git pr show -t 18274

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18274.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-03-13T13:27:22Z

👋 Welcome back abhiscxk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-03-13T13:28:14Z

@kumarabhi006 The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-03-13T13:31:23Z

Webrevs

openjdk · 2024-03-13T20:09:12Z

@kumarabhi006 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328087: Automate javax/swing/JTable/TAB/TAB.java applet test

Reviewed-by: honkar, tr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 109 new commits pushed to the master branch:

c05f8c7: 8316388: Opensource five Swing component related regression tests
b8dfeaf: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to automatic main test
d57bdd8: 8328165: improve assert(idx < _maxlrg) failed: oob
128e60a: 8328037: Test java/util/Formatter/Padding.java has unnecessary high heap requirement after JDK-8326718
06f4b7f: 8327756: Convert javax/swing/JSlider/4987336/bug4987336.java applet to main
605800e: 8203867: Delete test java/awt/TrayIcon/DblClickActionEventTest/DblClickActionEventTest.html
0943937: 8328218: Delete test java/awt/Window/FindOwner/FindOwner.html
f6390e5: 8328089: Automate javax/swing/JTable/4222153/bug4222153.java applet test
e8d1ba3: 8328228: Missing comma in copyright year for a few JColorChooser tests
be1dd27: 8328130: Remove applet usage from JColorChooser tests Test4759934
... and 99 more: https://git.openjdk.org/jdk/compare/f2b5ffdb8ea3c766f14bab1dfd7c3865cffa2ce8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

honkar-jdk · 2024-03-14T00:57:07Z

test/jdk/javax/swing/JTable/TAB.java

+        }
+    }
+
+    static void createAndShowUI()


There are few places where boxing (Integer(), Boolean()) is not required and can be removed as part of clean up.

honkar-jdk · 2024-03-14T00:58:28Z

test/jdk/javax/swing/JTable/TAB.java

+            robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
+            robot.mousePress(InputEvent.BUTTON1_DOWN_MASK);
+            robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
+            robot.delay(100);


Like the previous test since autoDelay() is set, this delay can be reduced or removed completely.

honkar-jdk · 2024-03-14T01:01:48Z

test/jdk/javax/swing/JTable/TAB.java

 */
-public class TAB extends JApplet
+
+public class TAB


Class name is in all-caps, Tab would be more appropriate.

kumarabhi006 · 2024-03-14T16:07:16Z

@honkar-jdk Updated as per last review. Please take a look.

honkar-jdk · 2024-03-14T17:19:33Z

test/jdk/javax/swing/JTable/Tab.java

-public class TAB extends JApplet
+
+public class Tab
 {


Minor nit: Opening brace placement

TejeshR13

Looks good to me. Does this work fine in other L&F (Like Aqua), because you have explicitly mentioned as Metal right?

kumarabhi006 · 2024-03-15T07:43:17Z

Looks good to me. Does this work fine in other L&F (Like Aqua), because you have explicitly mentioned as Metal right?

The older version of applet test also checks for MetalLookAndFeel. Since the test is just converted to main manual, didn't check explicitly on Aqua or other LAFs.

kumarabhi006 · 2024-03-15T10:48:44Z

/integrate

openjdk · 2024-03-15T10:49:22Z

Going to push as commit 5249cc0.
Since your change was applied there have been 109 commits pushed to the master branch:

c05f8c7: 8316388: Opensource five Swing component related regression tests
b8dfeaf: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to automatic main test
d57bdd8: 8328165: improve assert(idx < _maxlrg) failed: oob
128e60a: 8328037: Test java/util/Formatter/Padding.java has unnecessary high heap requirement after JDK-8326718
06f4b7f: 8327756: Convert javax/swing/JSlider/4987336/bug4987336.java applet to main
605800e: 8203867: Delete test java/awt/TrayIcon/DblClickActionEventTest/DblClickActionEventTest.html
0943937: 8328218: Delete test java/awt/Window/FindOwner/FindOwner.html
f6390e5: 8328089: Automate javax/swing/JTable/4222153/bug4222153.java applet test
e8d1ba3: 8328228: Missing comma in copyright year for a few JColorChooser tests
be1dd27: 8328130: Remove applet usage from JColorChooser tests Test4759934
... and 99 more: https://git.openjdk.org/jdk/compare/f2b5ffdb8ea3c766f14bab1dfd7c3865cffa2ce8...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-03-15T10:49:27Z

@kumarabhi006 Pushed as commit 5249cc0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Automate applet based test

6b3f50a

openjdk bot added the rfr Pull request is ready for review label Mar 13, 2024

openjdk bot added the client client-libs-dev@openjdk.org label Mar 13, 2024

Remove commented code

66d7884

honkar-jdk suggested changes Mar 14, 2024

View reviewed changes

kumarabhi006 added 3 commits March 14, 2024 10:37

class anme change and minor update

dc82c84

Rename test file

bccf8ac

Test file update

0a6e5ac

honkar-jdk reviewed Mar 14, 2024

View reviewed changes

honkar-jdk approved these changes Mar 14, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Mar 14, 2024

Minor update

04c887c

TejeshR13 reviewed Mar 15, 2024

View reviewed changes

TejeshR13 approved these changes Mar 15, 2024

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Mar 15, 2024

openjdk bot closed this Mar 15, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 15, 2024

8328087: Automate javax/swing/JTable/TAB/TAB.java applet test #18274

8328087: Automate javax/swing/JTable/TAB/TAB.java applet test #18274

Uh oh!

Conversation

kumarabhi006 commented Mar 13, 2024 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Webrev

Uh oh!

bridgekeeper bot commented Mar 13, 2024

Uh oh!

openjdk bot commented Mar 13, 2024

Uh oh!

mlbridge bot commented Mar 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

openjdk bot commented Mar 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

honkar-jdk Mar 14, 2024

Choose a reason for hiding this comment

Uh oh!

honkar-jdk Mar 14, 2024

Choose a reason for hiding this comment

Uh oh!

honkar-jdk Mar 14, 2024

Choose a reason for hiding this comment

Uh oh!

kumarabhi006 commented Mar 14, 2024

Uh oh!

honkar-jdk Mar 14, 2024

Choose a reason for hiding this comment

Uh oh!

TejeshR13 left a comment

Choose a reason for hiding this comment

Uh oh!

kumarabhi006 commented Mar 15, 2024

Uh oh!

kumarabhi006 commented Mar 15, 2024

Uh oh!

openjdk bot commented Mar 15, 2024

Uh oh!

openjdk bot commented Mar 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

kumarabhi006 commented Mar 13, 2024 •

edited by openjdk bot

Loading

mlbridge bot commented Mar 13, 2024 •

edited

Loading

openjdk bot commented Mar 13, 2024 •

edited

Loading