8328089: Automate javax/swing/JTable/4222153/bug4222153.java applet test #18275

kumarabhi006 · 2024-03-13T13:39:08Z

Conversion of manual applet test to automated test. CI testing is green. Link attached to JBS.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8328089: Automate javax/swing/JTable/4222153/bug4222153.java applet test (Bug - P4)

Reviewers

Harshitha Onkar (@honkar-jdk - Reviewer)
Tejesh R (@TejeshR13 - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18275/head:pull/18275
$ git checkout pull/18275

Update a local copy of the PR:
$ git checkout pull/18275
$ git pull https://git.openjdk.org/jdk.git pull/18275/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18275

View PR using the GUI difftool:
$ git pr show -t 18275

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18275.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-03-13T13:39:35Z

👋 Welcome back abhiscxk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-03-13T13:40:18Z

@kumarabhi006 The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-03-13T13:43:39Z

Webrevs

honkar-jdk · 2024-03-13T16:59:43Z

test/jdk/javax/swing/JTable/bug4222153.java

+    public static void main(String[] args) throws Exception {
+        UIManager.setLookAndFeel("javax.swing.plaf.metal.MetalLookAndFeel");
+        Robot robot = new Robot();
+        robot.setAutoDelay(100);


Delay can be reduced to 50ms

Delay can be reduced to 50ms

AutoDealy has been set to 100ms for many of the PRs. So, kept it as 100. Anyway, I will update to 50.

honkar-jdk · 2024-03-13T17:01:38Z

test/jdk/javax/swing/JTable/bug4222153.java

+            robot.delay(100);
+            robot.waitForIdle();


Since autodelay is already set you can remove the additional delay after key release or reduce it to a smaller number.

Suggested change

robot.delay(100);

robot.waitForIdle();

robot.waitForIdle();

robot.delay(20);

honkar-jdk · 2024-03-13T17:03:16Z

test/jdk/javax/swing/JTable/bug4222153.java

+            robot.delay(100);
+            robot.waitForIdle();


Same here and usually it is waitForIdle() followed by delay().

honkar-jdk · 2024-03-13T18:05:08Z

test/jdk/javax/swing/JTable/bug4222153.java

+            robot.keyPress(KeyEvent.VK_TAB);
+            robot.keyRelease(KeyEvent.VK_TAB);
+            robot.waitForIdle();
+            robot.delay(20);


@kumarabhi006 whitespace error detected at line#96.

honkar-jdk

Changes look good.

openjdk · 2024-03-13T18:15:24Z

@kumarabhi006 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328089: Automate javax/swing/JTable/4222153/bug4222153.java applet test

Reviewed-by: honkar, tr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 100 new commits pushed to the master branch:

be1dd27: 8328130: Remove applet usage from JColorChooser tests Test4759934
fab0edc: 8328121: Remove applet usage from JColorChooser tests Test4759306
7c6fd33: 8327857: Remove applet usage from JColorChooser tests Test4222508
89fb0f8: 8327859: Remove applet usage from JColorChooser tests Test4319113
df909e2: 8328011: Convert java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to main
87bd6ca: 8328021: Convert applet test java/awt/List/SetFontTest/SetFontTest.html to main program
2482a50: 8326898: NSK tests should listen on loopback addresses only
e6a8fdd: 8328135: javax/management/remote/mandatory/loading/MissingClassTest.java fails on libgraal
7cc1965: 8328124: Convert java/awt/Frame/ShownOnPack/ShownOnPack.html applet test to main
d4ec783: 8327873: Convert javax/swing/border/Test4247606.java applet test to main
... and 90 more: https://git.openjdk.org/jdk/compare/f2b5ffdb8ea3c766f14bab1dfd7c3865cffa2ce8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

TejeshR13 · 2024-03-14T05:33:41Z

test/jdk/javax/swing/JTable/bug4222153.java

+                frame.setSize(200, 200);
+                frame.setLocationRelativeTo(null);
+                frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
+                frame.setVisible(true);


I guess it is better to move frame initialization part into a separate method rather here.

Since the UI initialization was minimal, I kept it in main. Moved to separate method now.

TejeshR13

Looks good to me.

honkar-jdk

Updated changes look good.

kumarabhi006 · 2024-03-15T04:13:48Z

/integrate

openjdk · 2024-03-15T04:14:55Z

Going to push as commit f6390e5.
Since your change was applied there have been 101 commits pushed to the master branch:

e8d1ba3: 8328228: Missing comma in copyright year for a few JColorChooser tests
be1dd27: 8328130: Remove applet usage from JColorChooser tests Test4759934
fab0edc: 8328121: Remove applet usage from JColorChooser tests Test4759306
7c6fd33: 8327857: Remove applet usage from JColorChooser tests Test4222508
89fb0f8: 8327859: Remove applet usage from JColorChooser tests Test4319113
df909e2: 8328011: Convert java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to main
87bd6ca: 8328021: Convert applet test java/awt/List/SetFontTest/SetFontTest.html to main program
2482a50: 8326898: NSK tests should listen on loopback addresses only
e6a8fdd: 8328135: javax/management/remote/mandatory/loading/MissingClassTest.java fails on libgraal
7cc1965: 8328124: Convert java/awt/Frame/ShownOnPack/ShownOnPack.html applet test to main
... and 91 more: https://git.openjdk.org/jdk/compare/f2b5ffdb8ea3c766f14bab1dfd7c3865cffa2ce8...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-03-15T04:15:02Z

@kumarabhi006 Pushed as commit f6390e5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Automate applet manual test

6dee3d2

openjdk bot added the rfr Pull request is ready for review label Mar 13, 2024

openjdk bot added the client client-libs-dev@openjdk.org label Mar 13, 2024

honkar-jdk suggested changes Mar 13, 2024

View reviewed changes

Review comment fix

b803981

openjdk bot removed the rfr Pull request is ready for review label Mar 13, 2024

honkar-jdk reviewed Mar 13, 2024

View reviewed changes

Whitespace error fix

c251b3f

openjdk bot added the rfr Pull request is ready for review label Mar 13, 2024

honkar-jdk approved these changes Mar 13, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Mar 13, 2024

TejeshR13 reviewed Mar 14, 2024

View reviewed changes

UI init in separate method

d18103e

TejeshR13 approved these changes Mar 14, 2024

View reviewed changes

honkar-jdk approved these changes Mar 15, 2024

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Mar 15, 2024

openjdk bot closed this Mar 15, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8328089: Automate javax/swing/JTable/4222153/bug4222153.java applet test #18275

8328089: Automate javax/swing/JTable/4222153/bug4222153.java applet test #18275

kumarabhi006 commented Mar 13, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Mar 13, 2024

openjdk bot commented Mar 13, 2024

mlbridge bot commented Mar 13, 2024 •

edited

Loading

honkar-jdk Mar 13, 2024

kumarabhi006 Mar 13, 2024 •

edited

Loading

honkar-jdk Mar 13, 2024 •

edited

Loading

honkar-jdk Mar 13, 2024

honkar-jdk Mar 13, 2024

kumarabhi006 Mar 13, 2024

honkar-jdk left a comment •

edited

Loading

openjdk bot commented Mar 13, 2024 •

edited

Loading

TejeshR13 Mar 14, 2024

kumarabhi006 Mar 14, 2024 •

edited

Loading

TejeshR13 left a comment

honkar-jdk left a comment

kumarabhi006 commented Mar 15, 2024

openjdk bot commented Mar 15, 2024

openjdk bot commented Mar 15, 2024

8328089: Automate javax/swing/JTable/4222153/bug4222153.java applet test #18275

8328089: Automate javax/swing/JTable/4222153/bug4222153.java applet test #18275

Conversation

kumarabhi006 commented Mar 13, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Mar 13, 2024

openjdk bot commented Mar 13, 2024

mlbridge bot commented Mar 13, 2024 • edited Loading

Webrevs

honkar-jdk Mar 13, 2024

Choose a reason for hiding this comment

kumarabhi006 Mar 13, 2024 • edited Loading

Choose a reason for hiding this comment

honkar-jdk Mar 13, 2024 • edited Loading

Choose a reason for hiding this comment

honkar-jdk Mar 13, 2024

Choose a reason for hiding this comment

honkar-jdk Mar 13, 2024

Choose a reason for hiding this comment

kumarabhi006 Mar 13, 2024

Choose a reason for hiding this comment

honkar-jdk left a comment • edited Loading

Choose a reason for hiding this comment

openjdk bot commented Mar 13, 2024 • edited Loading

TejeshR13 Mar 14, 2024

Choose a reason for hiding this comment

kumarabhi006 Mar 14, 2024 • edited Loading

Choose a reason for hiding this comment

TejeshR13 left a comment

Choose a reason for hiding this comment

honkar-jdk left a comment

Choose a reason for hiding this comment

kumarabhi006 commented Mar 15, 2024

openjdk bot commented Mar 15, 2024

openjdk bot commented Mar 15, 2024

kumarabhi006 commented Mar 13, 2024 •

edited by openjdk bot

Loading

mlbridge bot commented Mar 13, 2024 •

edited

Loading

kumarabhi006 Mar 13, 2024 •

edited

Loading

honkar-jdk Mar 13, 2024 •

edited

Loading

honkar-jdk left a comment •

edited

Loading

openjdk bot commented Mar 13, 2024 •

edited

Loading

kumarabhi006 Mar 14, 2024 •

edited

Loading