Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8328089: Automate javax/swing/JTable/4222153/bug4222153.java applet test #18275

Closed
wants to merge 4 commits into from

Conversation

kumarabhi006
Copy link
Contributor

@kumarabhi006 kumarabhi006 commented Mar 13, 2024

Conversion of manual applet test to automated test. CI testing is green. Link attached to JBS.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8328089: Automate javax/swing/JTable/4222153/bug4222153.java applet test (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18275/head:pull/18275
$ git checkout pull/18275

Update a local copy of the PR:
$ git checkout pull/18275
$ git pull https://git.openjdk.org/jdk.git pull/18275/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18275

View PR using the GUI difftool:
$ git pr show -t 18275

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18275.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 13, 2024

👋 Welcome back abhiscxk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 13, 2024
@openjdk
Copy link

openjdk bot commented Mar 13, 2024

@kumarabhi006 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 13, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 13, 2024

Webrevs

public static void main(String[] args) throws Exception {
UIManager.setLookAndFeel("javax.swing.plaf.metal.MetalLookAndFeel");
Robot robot = new Robot();
robot.setAutoDelay(100);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delay can be reduced to 50ms

Copy link
Contributor Author

@kumarabhi006 kumarabhi006 Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delay can be reduced to 50ms

AutoDealy has been set to 100ms for many of the PRs. So, kept it as 100. Anyway, I will update to 50.

Comment on lines 90 to 91
robot.delay(100);
robot.waitForIdle();
Copy link
Contributor

@honkar-jdk honkar-jdk Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since autodelay is already set you can remove the additional delay after key release or reduce it to a smaller number.

Suggested change
robot.delay(100);
robot.waitForIdle();
robot.waitForIdle();
robot.delay(20);

Comment on lines 94 to 95
robot.delay(100);
robot.waitForIdle();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here and usually it is waitForIdle() followed by delay().

@openjdk openjdk bot removed the rfr Pull request is ready for review label Mar 13, 2024
robot.keyPress(KeyEvent.VK_TAB);
robot.keyRelease(KeyEvent.VK_TAB);
robot.waitForIdle();
robot.delay(20);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kumarabhi006 whitespace error detected at line#96.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 13, 2024
Copy link
Contributor

@honkar-jdk honkar-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

@kumarabhi006 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328089: Automate javax/swing/JTable/4222153/bug4222153.java applet test

Reviewed-by: honkar, tr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 100 new commits pushed to the master branch:

  • be1dd27: 8328130: Remove applet usage from JColorChooser tests Test4759934
  • fab0edc: 8328121: Remove applet usage from JColorChooser tests Test4759306
  • 7c6fd33: 8327857: Remove applet usage from JColorChooser tests Test4222508
  • 89fb0f8: 8327859: Remove applet usage from JColorChooser tests Test4319113
  • df909e2: 8328011: Convert java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to main
  • 87bd6ca: 8328021: Convert applet test java/awt/List/SetFontTest/SetFontTest.html to main program
  • 2482a50: 8326898: NSK tests should listen on loopback addresses only
  • e6a8fdd: 8328135: javax/management/remote/mandatory/loading/MissingClassTest.java fails on libgraal
  • 7cc1965: 8328124: Convert java/awt/Frame/ShownOnPack/ShownOnPack.html applet test to main
  • d4ec783: 8327873: Convert javax/swing/border/Test4247606.java applet test to main
  • ... and 90 more: https://git.openjdk.org/jdk/compare/f2b5ffdb8ea3c766f14bab1dfd7c3865cffa2ce8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 13, 2024
frame.setSize(200, 200);
frame.setLocationRelativeTo(null);
frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
frame.setVisible(true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it is better to move frame initialization part into a separate method rather here.

Copy link
Contributor Author

@kumarabhi006 kumarabhi006 Mar 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the UI initialization was minimal, I kept it in main. Moved to separate method now.

Copy link
Contributor

@TejeshR13 TejeshR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@honkar-jdk honkar-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated changes look good.

@kumarabhi006
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 15, 2024

Going to push as commit f6390e5.
Since your change was applied there have been 101 commits pushed to the master branch:

  • e8d1ba3: 8328228: Missing comma in copyright year for a few JColorChooser tests
  • be1dd27: 8328130: Remove applet usage from JColorChooser tests Test4759934
  • fab0edc: 8328121: Remove applet usage from JColorChooser tests Test4759306
  • 7c6fd33: 8327857: Remove applet usage from JColorChooser tests Test4222508
  • 89fb0f8: 8327859: Remove applet usage from JColorChooser tests Test4319113
  • df909e2: 8328011: Convert java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to main
  • 87bd6ca: 8328021: Convert applet test java/awt/List/SetFontTest/SetFontTest.html to main program
  • 2482a50: 8326898: NSK tests should listen on loopback addresses only
  • e6a8fdd: 8328135: javax/management/remote/mandatory/loading/MissingClassTest.java fails on libgraal
  • 7cc1965: 8328124: Convert java/awt/Frame/ShownOnPack/ShownOnPack.html applet test to main
  • ... and 91 more: https://git.openjdk.org/jdk/compare/f2b5ffdb8ea3c766f14bab1dfd7c3865cffa2ce8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 15, 2024
@openjdk openjdk bot closed this Mar 15, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 15, 2024
@openjdk
Copy link

openjdk bot commented Mar 15, 2024

@kumarabhi006 Pushed as commit f6390e5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants