Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8327180: Failed: java/io/ObjectStreamClass/ObjectStreamClassCaching.java#G1 #18284

Closed
wants to merge 3 commits into from
Closed

8327180: Failed: java/io/ObjectStreamClass/ObjectStreamClassCaching.java#G1 #18284

wants to merge 3 commits into from

Conversation

RogerRiggs
Copy link
Contributor

@RogerRiggs RogerRiggs commented Mar 13, 2024 •
edited by openjdk bot
Loading

The intermittent failure of ObjectStreamClassCaching is due to an incorrect assumption about GC behavior and a race condition.

Removed test based on incorrect assumptions about simultaneous clearing of WeakReferences.
Added a run of the test using ZGC, (previously omitted)

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8327180: Failed: java/io/ObjectStreamClass/ObjectStreamClassCaching.java#G1 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18284/head:pull/18284
$ git checkout pull/18284

Update a local copy of the PR:
$ git checkout pull/18284
$ git pull https://git.openjdk.org/jdk.git pull/18284/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18284

View PR using the GUI difftool:
$ git pr show -t 18284

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18284.diff

Webrev

Link to Webrev Comment

@RogerRiggs
8327180: Failed: java/io/ObjectStreamClass/ObjectStreamClassCaching.j…
de516a2 
…ava#G1 failed with CONF=release -XX:ReservedCodeCacheSize=8m

Removed test based on incorrect assumptions about simultaneous clearing of WeakReferences
Added a run of the test using ZGC, (previously omitted)
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 13, 2024

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 13, 2024
@openjdk
Copy link

openjdk bot commented Mar 13, 2024

@RogerRiggs The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Mar 13, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 13, 2024 •
edited
Loading

Webrevs

irisclark
irisclark approved these changes Mar 13, 2024
View reviewed changes
test/jdk/java/io/ObjectStreamClass/ObjectStreamClassCaching.java
@@ -50,7 +50,12 @@

/*
* Disabled for ZGC Generational.
* TODO: Find correct appropriate solution to the flakiness of this test.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't you also remove the comment at line 52 since this test is no longer disabled?

@openjdk
Copy link

openjdk bot commented Mar 13, 2024 •
edited
Loading

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327180: Failed: java/io/ObjectStreamClass/ObjectStreamClassCaching.java#G1

Reviewed-by: iris, stefank

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 102 new commits pushed to the master branch:

  • c342188: 8328074: Add jcheck whitespace checking for assembly files
  • 3c70f26: 8328112: Remove CardTable::_guard_region
  • 48717d6: 8326333: jshell completion on arrays is incomplete
  • ece4124: 8328247: Remove redundant dir for tests converted from applet to main
  • d32ce65: 8327651: Rename DictionaryEntry members related to protection domain
  • 0719419: 8328236: module_entry in CDS map file has stale value
  • 0204aac: 8328115: Convert java/awt/font/TextLayout/TestJustification.html applet test to main
  • 9bc1b06: 8328242: Add a log area to the PassFailJFrame
  • 65a84c2: 8328006: refactor large anonymous inner class in HtmlDocletWriter
  • 044f4ed: 8326979: (jdeps) improve the error message for FindException caused by InvalidModuleDescriptorException
  • ... and 92 more: https://git.openjdk.org/jdk/compare/379ad1fbb4432c044912139e3d4e897988a341fa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 13, 2024
stefank
stefank suggested changes Mar 13, 2024
View reviewed changes
test/jdk/java/io/ObjectStreamClass/ObjectStreamClassCaching.java Outdated
* @bug 8277072 8327180
* @library /test/lib/
* @summary ObjectStreamClass caches keep ClassLoaders alive (ZGC)
* @run testng/othervm -Xmx64m -XX:+UseZGC ObjectStreamClassCaching
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is meant to run with Generational ZGC (according to the requires line). It needs to run with -XX:+UseZGC -XX:+ZGenerational to enable Generational ZGC. If you run with -XX:+UseZGC you get the older, non-generational ZGC.

stefank
stefank approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@stefank stefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Make sure that the test has run after the -XX:+ZGenerational flag was added.

@RogerRiggs
Copy link
Contributor Author

CI Tier1-3 successful

@RogerRiggs
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 18, 2024

Going to push as commit 85fc47c.
Since your change was applied there have been 110 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 18, 2024
@openjdk openjdk bot closed this Mar 18, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 18, 2024
@openjdk
Copy link

openjdk bot commented Mar 18, 2024

@RogerRiggs Pushed as commit 85fc47c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RogerRiggs RogerRiggs deleted the 8327180-classcaching branch June 24, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefank stefank stefank approved these changes

@irisclark irisclark irisclark approved these changes

Assignees
No one assigned
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RogerRiggs @stefank @irisclark