Skip to content

Conversation

@alisenchung
Copy link
Contributor

@alisenchung alisenchung commented Mar 13, 2024

Removing applet usage from manual JColorChooser tests


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8328121: Remove applet usage from JColorChooser tests Test4759306 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18286/head:pull/18286
$ git checkout pull/18286

Update a local copy of the PR:
$ git checkout pull/18286
$ git pull https://git.openjdk.org/jdk.git pull/18286/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18286

View PR using the GUI difftool:
$ git pr show -t 18286

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18286.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 13, 2024

👋 Welcome back achung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 13, 2024
@openjdk
Copy link

openjdk bot commented Mar 13, 2024

@alisenchung The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 13, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 13, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

@alisenchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328121: Remove applet usage from JColorChooser tests Test4759306

Reviewed-by: azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 86 new commits pushed to the master branch:

  • df909e2: 8328011: Convert java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to main
  • 87bd6ca: 8328021: Convert applet test java/awt/List/SetFontTest/SetFontTest.html to main program
  • 2482a50: 8326898: NSK tests should listen on loopback addresses only
  • e6a8fdd: 8328135: javax/management/remote/mandatory/loading/MissingClassTest.java fails on libgraal
  • 7cc1965: 8328124: Convert java/awt/Frame/ShownOnPack/ShownOnPack.html applet test to main
  • d4ec783: 8327873: Convert javax/swing/border/Test4247606.java applet test to main
  • debd597: 8327095: (ch) java/nio/channels/AsyncCloseAndInterrupt.java: improve error message when mkfifo fails
  • acfefc6: 8327876: Convert javax/swing/border/Test4252164.java applet test to main
  • 0c3998d: 8286759: TextComponentPrintable: consequent -> consecutive positions
  • d25c452: 8327835: Convert java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest applet test to main
  • ... and 76 more: https://git.openjdk.org/jdk/compare/41450e94059bbdf9ee798a1fc78ef14602319567...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 13, 2024
@alisenchung
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 14, 2024

Going to push as commit fab0edc.
Since your change was applied there have been 88 commits pushed to the master branch:

  • 7c6fd33: 8327857: Remove applet usage from JColorChooser tests Test4222508
  • 89fb0f8: 8327859: Remove applet usage from JColorChooser tests Test4319113
  • df909e2: 8328011: Convert java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to main
  • 87bd6ca: 8328021: Convert applet test java/awt/List/SetFontTest/SetFontTest.html to main program
  • 2482a50: 8326898: NSK tests should listen on loopback addresses only
  • e6a8fdd: 8328135: javax/management/remote/mandatory/loading/MissingClassTest.java fails on libgraal
  • 7cc1965: 8328124: Convert java/awt/Frame/ShownOnPack/ShownOnPack.html applet test to main
  • d4ec783: 8327873: Convert javax/swing/border/Test4247606.java applet test to main
  • debd597: 8327095: (ch) java/nio/channels/AsyncCloseAndInterrupt.java: improve error message when mkfifo fails
  • acfefc6: 8327876: Convert javax/swing/border/Test4252164.java applet test to main
  • ... and 78 more: https://git.openjdk.org/jdk/compare/41450e94059bbdf9ee798a1fc78ef14602319567...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 14, 2024
@openjdk openjdk bot closed this Mar 14, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 14, 2024
@openjdk
Copy link

openjdk bot commented Mar 14, 2024

@alisenchung Pushed as commit fab0edc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants