JDK-8328165: improve assert(idx < _maxlrg) failed: oob

[MBaesken]

The assert in chaitin.hpp
assert(idx < _maxlrg) failed: oob
could be improved, it should show more information.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8328165: improve assert(idx < _maxlrg) failed: oob (Enhancement - P4)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)
• Christian Hagedorn (@chhagedorn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18302/head:pull/18302
$ git checkout pull/18302

Update a local copy of the PR:
$ git checkout pull/18302
$ git pull https://git.openjdk.org/jdk.git pull/18302/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18302

View PR using the GUI difftool:
$ git pr show -t 18302

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18302.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328165: improve assert(idx < _maxlrg) failed: oob

Reviewed-by: mdoerr, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 51381bb: 8328139: Prefer 'override' to 'virtual' in subclasses of 'GCInitLogger'
• 792fc9d: 8320079: The ArabicBox.java test has no control buttons
• a232e8f: 8325621: Improve jspawnhelper version checks

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (7d9c5487)

[TheRealMDoerr]

LGTM.

[chhagedorn]

Looks good.

[MBaesken]

Thanks for the reviews !

/integrate

[openjdk]

Going to push as commit d57bdd8.
Since your change was applied there have been 24 commits pushed to the master branch:

• 128e60a: 8328037: Test java/util/Formatter/Padding.java has unnecessary high heap requirement after JDK-8326718
• 06f4b7f: 8327756: Convert javax/swing/JSlider/4987336/bug4987336.java applet to main
• 605800e: 8203867: Delete test java/awt/TrayIcon/DblClickActionEventTest/DblClickActionEventTest.html
• 0943937: 8328218: Delete test java/awt/Window/FindOwner/FindOwner.html
• f6390e5: 8328089: Automate javax/swing/JTable/4222153/bug4222153.java applet test
• e8d1ba3: 8328228: Missing comma in copyright year for a few JColorChooser tests
• be1dd27: 8328130: Remove applet usage from JColorChooser tests Test4759934
• fab0edc: 8328121: Remove applet usage from JColorChooser tests Test4759306
• 7c6fd33: 8327857: Remove applet usage from JColorChooser tests Test4222508
• 89fb0f8: 8327859: Remove applet usage from JColorChooser tests Test4319113
• ... and 14 more: https://git.openjdk.org/jdk/compare/c879627dbd7e9295d44f19ef237edb5de10805d5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit d57bdd8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.