8326979: (jdeps) improve the error message for FindException caused by InvalidModuleDescriptorException

[mlchung]

Trivial fix. Improve the error message to print the cause of the module resolution failure if present.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8326979: (jdeps) improve the error message for FindException caused by InvalidModuleDescriptorException (Bug - P4)

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18308/head:pull/18308
$ git checkout pull/18308

Update a local copy of the PR:
$ git checkout pull/18308
$ git pull https://git.openjdk.org/jdk.git pull/18308/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18308

View PR using the GUI difftool:
$ git pr show -t 18308

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18308.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mchung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mlchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326979: (jdeps) improve the error message for FindException caused by InvalidModuleDescriptorException

Reviewed-by: jpai, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• 06f4b7f: 8327756: Convert javax/swing/JSlider/4987336/bug4987336.java applet to main
• 605800e: 8203867: Delete test java/awt/TrayIcon/DblClickActionEventTest/DblClickActionEventTest.html
• 0943937: 8328218: Delete test java/awt/Window/FindOwner/FindOwner.html
• f6390e5: 8328089: Automate javax/swing/JTable/4222153/bug4222153.java applet test
• e8d1ba3: 8328228: Missing comma in copyright year for a few JColorChooser tests
• be1dd27: 8328130: Remove applet usage from JColorChooser tests Test4759934
• fab0edc: 8328121: Remove applet usage from JColorChooser tests Test4759306
• 7c6fd33: 8327857: Remove applet usage from JColorChooser tests Test4222508
• 89fb0f8: 8327859: Remove applet usage from JColorChooser tests Test4319113
• df909e2: 8328011: Convert java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to main
• ... and 2 more: https://git.openjdk.org/jdk/compare/e6a8fdd82c2b97f7ae74dfe8fbd3402718c9161c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@mlchung The following labels will be automatically applied to this pull request:

• compiler
• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (9bf99ff4)

[jaikiran]

Hello Mandy, this change to use the underlying cause of ResolutionExcepion and FindException when reporting the error message, appears OK to me.

I didn't know if ResolutionException too wraps the actual cause underneath, so I looked around a few JBS issues where ResolutionException was reported as being thrown and it does appear that the actual cause lies underneath. So I think this change is fine.

[AlanBateman]

Tests that depend on exception messages can be problematic but this one is easy to change if/when the exception message changes.

[mlchung]

/integrate

[openjdk]

Going to push as commit 044f4ed.
Since your change was applied there have been 25 commits pushed to the master branch:

• 71f9c4e: 8320534: fatal error for the NMTBenchmark test run for the mainline build
• bfba489: 8328157: Move C[XX]FLAGS_JDK[LIB/EXE] to JdkNativeCompilation.gmk
• 42aec8c: 8328146: Set LIBCXX automatically
• 90ab52e: 8328166: Epsilon: 'EpsilonHeap::allocate_work' misuses the parameter 'size' as size in bytes
• bf990c8: 8328269: NonFocusablePopupMenuTest.java should be marked as headful
• 80b98c8: 8320503: Print warning if VM reaches MallocLimit during error reporting
• dde519d: 8328066: WhiteBoxResizeTest failure on linux-x86: Could not reserve enough space for 2097152KB object heap
• 80ccc98: 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC
• 5249cc0: 8328087: Automate javax/swing/JTable/TAB/TAB.java applet test
• c05f8c7: 8316388: Opensource five Swing component related regression tests
• ... and 15 more: https://git.openjdk.org/jdk/compare/e6a8fdd82c2b97f7ae74dfe8fbd3402718c9161c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mlchung Pushed as commit 044f4ed.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.