-
Notifications
You must be signed in to change notification settings - Fork 5.8k
JDK-8258645: Bring Jemmy 1.3.11 to JDK test base #1831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Some changes to JSliderDemoTest: set a non-default driver and additional diagnostics
👋 Welcome back shurailine! A progress list of the required criteria for merging this PR into |
@amresh-sahu @akolarkunnu , if you can take a look that would be great |
@shurymury The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@shurymury This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 81 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Some general comments: A little info in JBS task/RFR, better to list all CODETOOLS(jemmy) fixes are integrating as part of this. Changes are looking good. |
LGTM. |
/integrate |
@shurymury Since your change was applied there have been 93 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 6a78b2a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Some changes to JSliderDemoTest: set a non-default driver and additional diagnostics
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/1831/head:pull/1831
$ git checkout pull/1831