Skip to content

JDK-8258645: Bring Jemmy 1.3.11 to JDK test base #1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

shurymury
Copy link
Contributor

@shurymury shurymury commented Dec 17, 2020

Some changes to JSliderDemoTest: set a non-default driver and additional diagnostics


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1831/head:pull/1831
$ git checkout pull/1831

Some changes to JSliderDemoTest: set a non-default driver and additional diagnostics
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 17, 2020

👋 Welcome back shurailine! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 17, 2020
@shurymury
Copy link
Contributor Author

@amresh-sahu @akolarkunnu , if you can take a look that would be great

@openjdk
Copy link

openjdk bot commented Dec 17, 2020

@shurymury The following label will be automatically applied to this pull request:

  • swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the swing client-libs-dev@openjdk.org label Dec 17, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 17, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 18, 2020

@shurymury This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258645: Bring Jemmy 1.3.11 to JDK test base

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 81 new commits pushed to the master branch:

  • 3f77a60: 8258582: HttpClient: the HttpClient doesn't explicitly shutdown its default executor when stopping.
  • f15528e: Merge
  • 30ca0a5: 8247994: Localize javadoc search
  • 47c180d: 8258515: javac should issue an error if an annotation is nested in a local class or interface
  • cb5a6b1: 8258225: compiler/c2/cr6340864/TestIntVect.java runs faster in interpreter
  • 61cbf0f: 8258293: tools/jpackage/share/RuntimePackageTest.java#id0 with RuntimePackageTest.testUsrInstallDir2
  • 7aac4dc: 8257621: JFR StringPool misses cached items across consecutive recordings
  • 61390d8: 8257999: Parallel GC crash in gc/parallel/TestDynShrinkHeap.java: new region is not in covered_region
  • 952dc70: 8257636: Update usage of "type" terminology in java.lang.Class and java.lang.reflect
  • 04a1e5b: 8258505: [TESTBUG] TestDivZeroWithSplitIf.java fails due to missing UnlockDiagnosticVMOptions
  • ... and 71 more: https://git.openjdk.java.net/jdk/compare/2c3ae19a20434f93ccff23175ddaea398d49a0c6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 18, 2020
@akolarkunnu
Copy link
Contributor

akolarkunnu commented Dec 18, 2020

Some general comments:
JBS CODETOOLS tasks are still in NEW status, but corresponding codes are already checkedin
https://bugs.openjdk.java.net/browse/CODETOOLS-7902736
https://bugs.openjdk.java.net/browse/CODETOOLS-7902811

A little info in JBS task/RFR, better to list all CODETOOLS(jemmy) fixes are integrating as part of this.

Changes are looking good.

@amresh-sahu
Copy link
Contributor

LGTM.

@shurymury
Copy link
Contributor Author

shurymury commented Dec 18, 2020 via email

@shurymury
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Dec 18, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 18, 2020
@openjdk
Copy link

openjdk bot commented Dec 18, 2020

@shurymury Since your change was applied there have been 93 commits pushed to the master branch:

  • 7f92d18: 8258553: Limit number of fields in instance to be considered for scalar replacement
  • adf0e23: 8257800: CompileCommand TypedMethodOptionMatcher::parse_method_pattern() may over consume
  • 06c24e1: 8256213: Remove os::split_reserved_memory
  • be41468: 8258696: Temporarily revert use of pattern match instanceof until docs-reference is fixed
  • a4f393c: 8258661: Inner class ResponseCacheEntry could be static
  • 3c48819: 8169086: DTLS tests fail intermittently with too much loops or timeout
  • 71ae05d: 8258061: Improve diagnostic information about errors during class redefinition
  • 68f2acb: 8252055: Use java.util.HexFormat in java.security
  • 1dae45d: 8250523: Remove abortOnException diagnostic option from TestHumongousNonArrayAllocation.java
  • 00d80fd: 8258255: Move PtrQueue active flag to SATBMarkQueue
  • ... and 83 more: https://git.openjdk.java.net/jdk/compare/2c3ae19a20434f93ccff23175ddaea398d49a0c6...master

Your commit was automatically rebased without conflicts.

Pushed as commit 6a78b2a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated swing client-libs-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

4 participants