-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8203867: Delete test java/awt/TrayIcon/DblClickActionEventTest/DblClickActionEventTest.html #18311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back prr! A progress list of the required criteria for merging this PR into |
|
@prrace This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 9 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
honkar-jdk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason to delete the test sounds reasonable.
Moreover the instructions in the test are indeed confusing and not clear.
|
/integrate |
|
Going to push as commit 605800e.
Your commit was automatically rebased without conflicts. |
This test draws the same tray icon, has similar instructions to, and is subsumed by the related test DisposeInActionEventTest.java
And because this test has incomplete instructions not covering macOS it is problem-listed.
The other test explicitly covers macOS.
So the right answer is to remove this manual applet test which adds no valuable coverage and just costs time + effort to run.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18311/head:pull/18311$ git checkout pull/18311Update a local copy of the PR:
$ git checkout pull/18311$ git pull https://git.openjdk.org/jdk.git pull/18311/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18311View PR using the GUI difftool:
$ git pr show -t 18311Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18311.diff
Webrev
Link to Webrev Comment