-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8328227: Remove applet usage from JColorChooser tests Test4887836 #18316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back achung! A progress list of the required criteria for merging this PR into |
|
@alisenchung This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 268 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@alisenchung The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
|
|
||
| public static void main(String[] args) throws Exception { | ||
| String instructions = "If you do not see white area under the \"Swatches\" tab,\n" + | ||
| "then test passed, otherwise it failed."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original instructions seem a bit vague and the test window has a lot going on so probably more details here would add clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original test JDK-4887836 is quite vague so I'm not sure how to add more details other than "white area under 'Swatches' tab"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alisenchung Which "White area" are they referring in Swatches tab? Is it the preview window?
|
/integrate |
|
Going to push as commit cc5b9c6.
Your commit was automatically rebased without conflicts. |
|
@alisenchung Pushed as commit cc5b9c6. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Removing applet usage from manual JColorChooser tests
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18316/head:pull/18316$ git checkout pull/18316Update a local copy of the PR:
$ git checkout pull/18316$ git pull https://git.openjdk.org/jdk.git pull/18316/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18316View PR using the GUI difftool:
$ git pr show -t 18316Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18316.diff
Webrev
Link to Webrev Comment