Skip to content

Conversation

@alisenchung
Copy link
Contributor

@alisenchung alisenchung commented Mar 14, 2024

Removing applet usage from manual JColorChooser tests


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8328227: Remove applet usage from JColorChooser tests Test4887836 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18316/head:pull/18316
$ git checkout pull/18316

Update a local copy of the PR:
$ git checkout pull/18316
$ git pull https://git.openjdk.org/jdk.git pull/18316/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18316

View PR using the GUI difftool:
$ git pr show -t 18316

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18316.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 14, 2024

👋 Welcome back achung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 14, 2024

@alisenchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328227: Remove applet usage from JColorChooser tests Test4887836

Reviewed-by: honkar, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 268 new commits pushed to the master branch:

  • 2725405: 8327991: Improve HttpClient documentation with regard to reclaiming resources
  • db01fcd: 8328827: Convert java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html applet test to main
  • 89e0889: 8328858: More runtime/stack tests fail intermittently on libgraal
  • 153410f: 8328930: [AIX] remove pase related coding
  • da8a095: 8328928: Serial: Use IsGCActiveMark instead of AutoModifyRestore in SerialHeap::do_collection
  • 472fcb6: 8328508: Unify the signatures of the methods address_for_index() and index_for() in BOT implementations
  • cc1800f: 8327998: Enable java/lang/ProcessBuilder/JspawnhelperProtocol.java on Mac
  • b9c76de: 8329074: AIX build fails after JDK-8328824
  • 7b1f2c8: 8327493: Update minimum Xcode version in docs
  • 9d441e3: 8283223: gc/stringdedup/TestStringDeduplicationFullGC.java#Parallel failed with "RuntimeException: String verification failed"
  • ... and 258 more: https://git.openjdk.org/jdk/compare/41450e94059bbdf9ee798a1fc78ef14602319567...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 14, 2024
@openjdk
Copy link

openjdk bot commented Mar 14, 2024

@alisenchung The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 14, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 14, 2024

Webrevs


public static void main(String[] args) throws Exception {
String instructions = "If you do not see white area under the \"Swatches\" tab,\n" +
"then test passed, otherwise it failed.";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original instructions seem a bit vague and the test window has a lot going on so probably more details here would add clarity.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original test JDK-4887836 is quite vague so I'm not sure how to add more details other than "white area under 'Swatches' tab"

Copy link
Contributor

@honkar-jdk honkar-jdk Mar 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alisenchung Which "White area" are they referring in Swatches tab? Is it the preview window?

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 25, 2024
@alisenchung
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 27, 2024

Going to push as commit cc5b9c6.
Since your change was applied there have been 278 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 27, 2024
@openjdk openjdk bot closed this Mar 27, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 27, 2024
@openjdk
Copy link

openjdk bot commented Mar 27, 2024

@alisenchung Pushed as commit cc5b9c6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants