Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8169086: DTLS tests fail intermittently with too much loops or timeout #1832

Closed
wants to merge 2 commits into from

Conversation

@XueleiFan
Copy link
Member

@XueleiFan XueleiFan commented Dec 18, 2020

There are a few intermittent timeout in the DTLS regression test in JDK. In the DTLS implementation, invalid record is not discarded in the ByteBuffers. So, the next unwrap() will repeat the reading and thus there is a potential dead loop. The DTLS test failure cannot reproduced, and I'm not very sure if this is the root cause. Let see if the intermittent failure could be fixed or not with this update.

No new regression, the existing javax/net/ssl/DTLS/PacketLossRetransmission.java test will be used instead.

Bug: https://bugs.openjdk.java.net/browse/JDK-8169086


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8169086: DTLS tests fail intermittently with too much loops or timeout

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1832/head:pull/1832
$ git checkout pull/1832

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 18, 2020

👋 Welcome back xuelei! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 18, 2020

@XueleiFan The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security label Dec 18, 2020
@openjdk openjdk bot added the rfr label Dec 18, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 18, 2020

Webrevs

Copy link
Contributor

@ascarpino ascarpino left a comment

Change looks reasonable and a minimal risk attempt

@openjdk
Copy link

@openjdk openjdk bot commented Dec 18, 2020

@XueleiFan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8169086: DTLS tests fail intermittently with too much loops or timeout

Reviewed-by: ascarpino

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • 71ae05d: 8258061: Improve diagnostic information about errors during class redefinition
  • 68f2acb: 8252055: Use java.util.HexFormat in java.security
  • 1dae45d: 8250523: Remove abortOnException diagnostic option from TestHumongousNonArrayAllocation.java
  • 00d80fd: 8258255: Move PtrQueue active flag to SATBMarkQueue
  • 853c047: 8258469: Cleanup remaining safefetch test coding
  • 1e03ca1: 8258471: "search codecache" clhsdb command does not work
  • 3f77a60: 8258582: HttpClient: the HttpClient doesn't explicitly shutdown its default executor when stopping.
  • f15528e: Merge
  • 30ca0a5: 8247994: Localize javadoc search
  • 47c180d: 8258515: javac should issue an error if an annotation is nested in a local class or interface
  • ... and 11 more: https://git.openjdk.java.net/jdk/compare/9ed0b7640338194365f7d8a53bc2df3b0c96e821...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 18, 2020
@XueleiFan
Copy link
Member Author

@XueleiFan XueleiFan commented Dec 18, 2020

/integrate

@openjdk openjdk bot closed this Dec 18, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 18, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 18, 2020

@XueleiFan Since your change was applied there have been 21 commits pushed to the master branch:

  • 71ae05d: 8258061: Improve diagnostic information about errors during class redefinition
  • 68f2acb: 8252055: Use java.util.HexFormat in java.security
  • 1dae45d: 8250523: Remove abortOnException diagnostic option from TestHumongousNonArrayAllocation.java
  • 00d80fd: 8258255: Move PtrQueue active flag to SATBMarkQueue
  • 853c047: 8258469: Cleanup remaining safefetch test coding
  • 1e03ca1: 8258471: "search codecache" clhsdb command does not work
  • 3f77a60: 8258582: HttpClient: the HttpClient doesn't explicitly shutdown its default executor when stopping.
  • f15528e: Merge
  • 30ca0a5: 8247994: Localize javadoc search
  • 47c180d: 8258515: javac should issue an error if an annotation is nested in a local class or interface
  • ... and 11 more: https://git.openjdk.java.net/jdk/compare/9ed0b7640338194365f7d8a53bc2df3b0c96e821...master

Your commit was automatically rebased without conflicts.

Pushed as commit 3c48819.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@XueleiFan XueleiFan deleted the JDK-8169086 branch Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants