Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8328244: Convert javax/swing/JSlider/6742358/bug6742358.java applet test to main #18321

Closed
wants to merge 5 commits into from

Conversation

kumarabhi006
Copy link
Contributor

@kumarabhi006 kumarabhi006 commented Mar 15, 2024

Conversion of manual applet test to main based using PassFailJFrame manual framework


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8328244: Convert javax/swing/JSlider/6742358/bug6742358.java applet test to main (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18321/head:pull/18321
$ git checkout pull/18321

Update a local copy of the PR:
$ git checkout pull/18321
$ git pull https://git.openjdk.org/jdk.git pull/18321/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18321

View PR using the GUI difftool:
$ git pr show -t 18321

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18321.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 15, 2024

👋 Welcome back abhiscxk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 15, 2024

@kumarabhi006 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328244: Convert javax/swing/JSlider/6742358/bug6742358.java applet test to main

Reviewed-by: psadhukhan, tr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 154 new commits pushed to the master branch:

  • c01095c: 8328262: Convert javax/swing/JSplitPane/8132123/bug8132123.java applet test to main
  • f1c69cc: 8289822: G1: Make concurrent mark code owner of TAMSes
  • 5b6b514: 8325362: Allow to create a simple in-memory input JavaFileObject
  • c59c41a: 8326941: Remove StringUTF16::isBigEndian
  • 6eea5d6: 8325187: JVMTI GetThreadState says virtual thread is JVMTI_THREAD_STATE_INTERRUPTED when it no longer is
  • 053ff76: 8308660: C2 compilation hits 'node must be dead' assert
  • e1b0af2: 8323972: C2 compilation fails with assert(!x->as_Loop()->is_loop_nest_inner_loop()) failed: loop was transformed
  • c0fc956: 8328275: CodeCache::print_internals should not be called in PRODUCT code
  • 4ef591f: 8326964: Remove Eclipse Shared Workspaces
  • ac5b6cb: 8327757: Convert javax/swing/JSlider/6524424/bug6524424.java applet to main
  • ... and 144 more: https://git.openjdk.org/jdk/compare/f2b5ffdb8ea3c766f14bab1dfd7c3865cffa2ce8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 15, 2024
@openjdk
Copy link

openjdk bot commented Mar 15, 2024

@kumarabhi006 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 15, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 15, 2024

Webrevs

@kumarabhi006 kumarabhi006 changed the title 8328244: Convert javax/swing/JSlider/6742358/bug6742358.java.java applet test to main 8328244: Convert javax/swing/JSlider/6742358/bug6742358.java applet test to main Mar 15, 2024
@@ -24,34 +24,41 @@
/* @test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start @test at next line

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 18, 2024
Copy link
Contributor

@TejeshR13 TejeshR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line column limit exceeds in createSlider() method, can correct those.

@@ -21,37 +21,45 @@
* questions.
*/

/* @test
/*
* @test
* @bug 6742358
* @summary MetalSliderUI paint wrong vertical disabled filled JSlider for DefaultMetalTheme
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary sentence could be re-structured.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@kumarabhi006
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 19, 2024

Going to push as commit 5f2a92d.
Since your change was applied there have been 156 commits pushed to the master branch:

  • 2094ff3: 8328279: Convert java/awt/Cursor/CursorOverlappedPanelsTest test to main
  • db4842c: 8328364: Remove redundant fields in 'BOTConstants'
  • c01095c: 8328262: Convert javax/swing/JSplitPane/8132123/bug8132123.java applet test to main
  • f1c69cc: 8289822: G1: Make concurrent mark code owner of TAMSes
  • 5b6b514: 8325362: Allow to create a simple in-memory input JavaFileObject
  • c59c41a: 8326941: Remove StringUTF16::isBigEndian
  • 6eea5d6: 8325187: JVMTI GetThreadState says virtual thread is JVMTI_THREAD_STATE_INTERRUPTED when it no longer is
  • 053ff76: 8308660: C2 compilation hits 'node must be dead' assert
  • e1b0af2: 8323972: C2 compilation fails with assert(!x->as_Loop()->is_loop_nest_inner_loop()) failed: loop was transformed
  • c0fc956: 8328275: CodeCache::print_internals should not be called in PRODUCT code
  • ... and 146 more: https://git.openjdk.org/jdk/compare/f2b5ffdb8ea3c766f14bab1dfd7c3865cffa2ce8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 19, 2024
@openjdk openjdk bot closed this Mar 19, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 19, 2024
@openjdk
Copy link

openjdk bot commented Mar 19, 2024

@kumarabhi006 Pushed as commit 5f2a92d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants