8328248: Convert javax/swing/JSlider/6587742/bug6587742.java applet test to main

[kumarabhi006]

Conversion of manual applet test to main based using PassFailJFrame manual framework

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8328248: Convert javax/swing/JSlider/6587742/bug6587742.java applet test to main (Bug - P4)

Reviewers

• Alexander Zvegintsev (@azvegint - Reviewer) ⚠️ Review applies to ee30cdbb
• Tejesh R (@TejeshR13 - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18323/head:pull/18323
$ git checkout pull/18323

Update a local copy of the PR:
$ git checkout pull/18323
$ git pull https://git.openjdk.org/jdk.git pull/18323/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18323

View PR using the GUI difftool:
$ git pr show -t 18323

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18323.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back abhiscxk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kumarabhi006 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328248: Convert javax/swing/JSlider/6587742/bug6587742.java applet test to main

Reviewed-by: azvegint, tr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 128 new commits pushed to the master branch:

• c342188: 8328074: Add jcheck whitespace checking for assembly files
• 3c70f26: 8328112: Remove CardTable::_guard_region
• 48717d6: 8326333: jshell completion on arrays is incomplete
• ece4124: 8328247: Remove redundant dir for tests converted from applet to main
• d32ce65: 8327651: Rename DictionaryEntry members related to protection domain
• 0719419: 8328236: module_entry in CDS map file has stale value
• 0204aac: 8328115: Convert java/awt/font/TextLayout/TestJustification.html applet test to main
• 9bc1b06: 8328242: Add a log area to the PassFailJFrame
• 65a84c2: 8328006: refactor large anonymous inner class in HtmlDocletWriter
• 044f4ed: 8326979: (jdeps) improve the error message for FindException caused by InvalidModuleDescriptorException
• ... and 118 more: https://git.openjdk.org/jdk/compare/f2b5ffdb8ea3c766f14bab1dfd7c3865cffa2ce8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@kumarabhi006 The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (ef49f3b8)
• 00: Full (ee30cdbb)

[azvegint]

Can be moved to the bug6587742 class declaration for better readability

[kumarabhi006]

There is a discussion going on for "where to put jtreg tags ?". Since there was no final conclusion, I left it as it was before the conversion.

Updated now.

[TejeshR13]

Looks good to me.

[kumarabhi006]

/integrate

[openjdk]

Going to push as commit 86f1744.
Since your change was applied there have been 129 commits pushed to the master branch:

• 7baec66: 8328168: Epsilon: Premature OOM when allocating object larger than uncommitted heap size
• c342188: 8328074: Add jcheck whitespace checking for assembly files
• 3c70f26: 8328112: Remove CardTable::_guard_region
• 48717d6: 8326333: jshell completion on arrays is incomplete
• ece4124: 8328247: Remove redundant dir for tests converted from applet to main
• d32ce65: 8327651: Rename DictionaryEntry members related to protection domain
• 0719419: 8328236: module_entry in CDS map file has stale value
• 0204aac: 8328115: Convert java/awt/font/TextLayout/TestJustification.html applet test to main
• 9bc1b06: 8328242: Add a log area to the PassFailJFrame
• 65a84c2: 8328006: refactor large anonymous inner class in HtmlDocletWriter
• ... and 119 more: https://git.openjdk.org/jdk/compare/f2b5ffdb8ea3c766f14bab1dfd7c3865cffa2ce8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kumarabhi006 Pushed as commit 86f1744.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.