JDK-8328299 : Convert DnDFileGroupDescriptor.html applet test to main

[honkar-jdk]

Following test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.html is converted to main using PassFailJFrame.

This test is currently problem-listed on macOS and linux, but as per the previous JBS bugs [JDK-6242241, JDK-8080185, JDK-7147083] this test was original created for testing DnD of MS Outlook attachments on Windows system.

Based on the test history and JBS details, I believe this should be windows-only test and should NOT be problemlisted on macOS and linux as it is not applicable.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8328299: Convert DnDFileGroupDescriptor.html applet test to main (Bug - P4)

Reviewers

• Prasanta Sadhukhan (@prsadhuk - Reviewer)
• Tejesh R (@TejeshR13 - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18335/head:pull/18335
$ git checkout pull/18335

Update a local copy of the PR:
$ git checkout pull/18335
$ git pull https://git.openjdk.org/jdk.git pull/18335/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18335

View PR using the GUI difftool:
$ git pr show -t 18335

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18335.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back honkar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@honkar-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328299: Convert DnDFileGroupDescriptor.html applet test to main

Reviewed-by: psadhukhan, tr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 62 new commits pushed to the master branch:

• 684678f: 8328633: s390x: Improve vectorization of Match.sqrt() on floats
• 93d1700: 8328589: unify os::breakpoint among posix platforms
• a5a2eca: 8327683: Crash with primitive type pattern and generic expression in instanceof
• 65d9f11: 8328328: Convert javax/swing/JTabbedPane/4666224/bug4666224.java applet test to main
• 481473e: 8328035: Convert javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main
• dea94f4: 8328300: Convert PrintDialogsTest.java from Applet to main program
• d32746e: 8296244: Alternate implementation of user-based authorization Subject APIs that doesn’t depend on Security Manager APIs
• 000f4d8: 8319251: [REDO] Change LockingMode default from LM_LEGACY to LM_LIGHTWEIGHT
• fbeac98: 8328379: Convert URLDragTest.html applet test to main
• 96530bc: 8326521: JFR: CompilerPhase event test fails on windows 32 bit
• ... and 52 more: https://git.openjdk.org/jdk/compare/0204aacb0305e94a7d6d5299a5ae835f3f71b030...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@honkar-jdk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[honkar-jdk]

@prsadhuk While looking into the test history I noticed you had previous worked on it PR #3406, it wasn't integrated though. Any thoughts whether to make this test windows-only or extend the test to other platforms ?

Your previous PR description sounds correct, when I went through the related test bugs it seemed like the test was created for windows-only issue.

[prsadhuk]

The reason it was not integrated was because of this comment wherein it was mentioned to update the test to run without MSOutlook dependancy so that it could be run on all platforms so making it not platform dependant..

[honkar-jdk]

@prsadhuk Since the test still retains the MS Outlook requirement in instructions, should we make the test windows-only then ? Because having a combination of @requires (os.family == "windows") and problem-listing on macOS and linux seems contradicting.

[honkar-jdk]

@prsadhuk When I read it for the 2nd time it makes sense why the @requires check was added. Since it is a manual test there is no way of knowing it has been problem-listed on macOS & linux unless someone explicitly checks the problemlist before running the test.

[prsadhuk]

The @requires was added in JDK-7147083 to ensure the test pass automatically in non-windows platform much before the problemlist was added so I think it was an oversight and we should remove the problemlist and close 8080185 as NA, in my opinion...

[mlbridge]

Webrevs

• 02: Full - Incremental (4a5b234b)
• 01: Full - Incremental (f586cc64)
• 00: Full (0a7745fe)

[honkar-jdk]

@prsadhuk

The @requires was added in JDK-7147083 to ensure the test pass automatically in non-windows platform much before the problemlist was added so I think it was an oversight and we should remove the problemlist and close 8080185 as NA, in my opinion...

I have de-problemlisted this test on non-windows platform as it is not applicable. I have added a note to to close JDK-8080185 when this PR is integrated.

[TejeshR13]

Looks good to me.

[honkar-jdk]

/integrate

[openjdk]

Going to push as commit 75195aa.
Since your change was applied there have been 72 commits pushed to the master branch:

• 725d87b: 8328570: Convert closed JViewport manual applet tests to main
• e41bc42: 8327990: [macosx-aarch64] Various tests fail with -XX:+AssertWXAtThreadSync
• 4308017: 8328631: Convert java/awt/InputMethods/InputMethodsTest/InputMethodsTest.java applet test to manual
• 700d2b9: 8328401: Convert java/awt/Frame/InitialMaximizedTest/InitialMaximizedTest.html applet test to automated
• bb3e84b: 8328592: hprof tests fail with -XX:-CompactStrings
• ac2f8e5: 8327994: Update code gen in CallGeneratorHelper
• c434b79: 8327169: serviceability/dcmd/vm/SystemMapTest.java and SystemDumpMapTest.java may fail after JDK-8326586
• 7006790: 8328628: JDK-8328157 incorrectly sets -MT on all compilers in jdk.jpackage
• 68170ae: 8328238: Convert few closed manual applet tests to main
• 9f5ad43: 8320675: PrinterJob/SecurityDialogTest.java hangs
• ... and 62 more: https://git.openjdk.org/jdk/compare/0204aacb0305e94a7d6d5299a5ae835f3f71b030...master

Your commit was automatically rebased without conflicts.

[openjdk]

@honkar-jdk Pushed as commit 75195aa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.