Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258653: CallJavaNode::_bci is not in use #1834

Closed
wants to merge 2 commits into from

Conversation

@navyxliu
Copy link
Contributor

@navyxliu navyxliu commented Dec 18, 2020

The member variable CallJavaNode::_bci is completely dead in release build.
In debug builds, CallJavaNode::validate_symbolic_info does refer to it, but
the information can obtain from jvms()->bci(). CallJavaNode also copies _bci
to MachCallJavaNode, but CodeGen doesn't use it as well.

/cc hotspot-compiler


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1834/head:pull/1834
$ git checkout pull/1834

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 18, 2020

👋 Welcome back xliu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Dec 18, 2020

@navyxliu
The hotspot-compiler label was successfully added.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 18, 2020

Webrevs

Loading

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Good.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Dec 18, 2020

@navyxliu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258653: CallJavaNode::_bci is not in use

Reviewed-by: kvn, vlivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • a4f393c: 8258661: Inner class ResponseCacheEntry could be static
  • 3c48819: 8169086: DTLS tests fail intermittently with too much loops or timeout
  • 71ae05d: 8258061: Improve diagnostic information about errors during class redefinition
  • 68f2acb: 8252055: Use java.util.HexFormat in java.security
  • 1dae45d: 8250523: Remove abortOnException diagnostic option from TestHumongousNonArrayAllocation.java
  • 00d80fd: 8258255: Move PtrQueue active flag to SATBMarkQueue
  • 853c047: 8258469: Cleanup remaining safefetch test coding
  • 1e03ca1: 8258471: "search codecache" clhsdb command does not work
  • 3f77a60: 8258582: HttpClient: the HttpClient doesn't explicitly shutdown its default executor when stopping.

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov, @iwanowww) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@openjdk openjdk bot added the ready label Dec 18, 2020
Copy link

@iwanowww iwanowww left a comment

Nice catch! Looks good.

Loading

@navyxliu
Copy link
Contributor Author

@navyxliu navyxliu commented Dec 18, 2020

/integrate

Loading

@openjdk openjdk bot added the sponsor label Dec 18, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 18, 2020

@navyxliu
Your change (at version 2bc8211) is now ready to be sponsored by a Committer.

Loading

@navyxliu
Copy link
Contributor Author

@navyxliu navyxliu commented Dec 21, 2020

May I call a sponsor to merge this?

The failure in pre-submit tests set is "java/util/HexFormat/HexFormatTest.java" in x86.

Invalid maximum heap size: -Xmx4G
The specified size exceeds the maximum representable size.
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.

Loading

@navyxliu
Copy link
Contributor Author

@navyxliu navyxliu commented Dec 21, 2020

the HexFormatTest is tracking here: https://bugs.openjdk.java.net/browse/JDK-8258584

Loading

@iwanowww
Copy link

@iwanowww iwanowww commented Dec 21, 2020

I submitted the patch for additional testing.
Will integrate it once the testing is over.

Loading

@iwanowww
Copy link

@iwanowww iwanowww commented Dec 21, 2020

/sponsor

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Dec 21, 2020

@iwanowww @navyxliu Since your change was applied there have been 38 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 30b9ff6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@navyxliu
Copy link
Contributor Author

@navyxliu navyxliu commented Dec 21, 2020

Thanks! @ iwanowww and @vnkozlov.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants