8328328: Convert javax/swing/JTabbedPane/4666224/bug4666224.java applet test to main #18340

kumarabhi006 · 2024-03-18T07:45:42Z

Conversion of manual applet test to main based using PassFailJFrame manual framework.

Tested in macOS where it didn't worked for "key press C to change tab layout" else it worked for other "key press (R, B, L, T) to change tab position. So, test is still in problem list.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8328328: Convert javax/swing/JTabbedPane/4666224/bug4666224.java applet test to main (Bug - P4)

Reviewers

Harshitha Onkar (@honkar-jdk - Reviewer) ⚠️ Review applies to 68ce8dd1
Tejesh R (@TejeshR13 - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18340/head:pull/18340
$ git checkout pull/18340

Update a local copy of the PR:
$ git checkout pull/18340
$ git pull https://git.openjdk.org/jdk.git pull/18340/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18340

View PR using the GUI difftool:
$ git pr show -t 18340

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18340.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-03-18T07:46:13Z

👋 Welcome back abhiscxk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-03-18T07:46:24Z

@kumarabhi006 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328328: Convert javax/swing/JTabbedPane/4666224/bug4666224.java applet test to main

Reviewed-by: honkar, tr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 180 new commits pushed to the master branch:

481473e: 8328035: Convert javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main
dea94f4: 8328300: Convert PrintDialogsTest.java from Applet to main program
d32746e: 8296244: Alternate implementation of user-based authorization Subject APIs that doesn’t depend on Security Manager APIs
000f4d8: 8319251: [REDO] Change LockingMode default from LM_LEGACY to LM_LIGHTWEIGHT
fbeac98: 8328379: Convert URLDragTest.html applet test to main
96530bc: 8326521: JFR: CompilerPhase event test fails on windows 32 bit
a112fc8: 8328225: Convert ImageDecoratedDnD.html applet test to main
4e83f4c: 8328185: Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main
d3f3011: 7036144: GZIPInputStream readTrailer uses faulty available() test for end-of-stream
e5e7cd2: 8328386: Convert java/awt/FileDialog/FileNameOverrideTest test to main
... and 170 more: https://git.openjdk.org/jdk/compare/f2b5ffdb8ea3c766f14bab1dfd7c3865cffa2ce8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-03-18T07:46:44Z

@kumarabhi006 The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-03-18T07:49:37Z

Webrevs

01: Full - Incremental (9c350b0e)
00: Full (68ce8dd1)

honkar-jdk

LGTM, minor changes added inline.

honkar-jdk · 2024-03-20T00:00:14Z

test/jdk/javax/swing/JTabbedPane/bug4666224.java

+ */
+
+public class bug4666224 {
+    final static int placements[] = { JTabbedPane.LEFT, JTabbedPane.RIGHT, JTabbedPane.TOP, JTabbedPane.BOTTOM };


placements isn't used and can be removed.

honkar-jdk · 2024-03-20T00:03:48Z

test/jdk/javax/swing/JTabbedPane/bug4666224.java

+                    1. Click on any of the tabs, focus indicator is visible.
+                    2. Lose focus on the window by clicking on some other window.
+                    3. Focus indicator should disappear
+                    4. Regain focus on the window by pressing the tab,


The regain focus part also doesn't work on macOS along with change layout.

honkar-jdk · 2024-03-20T00:05:04Z

test/jdk/javax/swing/JTabbedPane/bug4666224.java

+    final static int placements[] = { JTabbedPane.LEFT, JTabbedPane.RIGHT, JTabbedPane.TOP, JTabbedPane.BOTTOM };
+    private static JTabbedPane tabPane;
+    private static JFrame frame;
+    private static JPanel mainPanel;


mainPanel can be made local

TejeshR13 · 2024-03-20T06:01:25Z

test/jdk/javax/swing/JTabbedPane/bug4666224.java

+    private static final String INSTRUCTIONS = """
+                ON ALL PLATFORMS
+                    1. Click on any of the tabs, focus indicator is visible.
+                    2. Lose focus on the window by clicking on some other window.


Lose focus?

Yeah, it means the current focused windows should not be focused.

I was getting confused whether it should be lose or loose in this context?

I think Lose is ok.

TejeshR13 · 2024-03-20T06:09:49Z

test/jdk/javax/swing/JTabbedPane/bug4666224.java

+        map.put("top", new RotateAction(JTabbedPane.TOP));
+        map.put("bottom", new RotateAction(JTabbedPane.BOTTOM));
+        map.put("changeLayout", new ChangeLayoutAction());
+        map.put("dump", new DumpAction());


DumpAction can also be mentioned in INSTRUCTIONS I guess, since its been used here.

There is no instruction mentioned in old applet test. Kept it as it is.

I guess you can update it since its there in the test, still not mandatory.

kumarabhi006 · 2024-03-21T07:29:52Z

/integrate

openjdk · 2024-03-21T07:30:50Z

Going to push as commit 65d9f11.
Since your change was applied there have been 180 commits pushed to the master branch:

481473e: 8328035: Convert javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main
dea94f4: 8328300: Convert PrintDialogsTest.java from Applet to main program
d32746e: 8296244: Alternate implementation of user-based authorization Subject APIs that doesn’t depend on Security Manager APIs
000f4d8: 8319251: [REDO] Change LockingMode default from LM_LEGACY to LM_LIGHTWEIGHT
fbeac98: 8328379: Convert URLDragTest.html applet test to main
96530bc: 8326521: JFR: CompilerPhase event test fails on windows 32 bit
a112fc8: 8328225: Convert ImageDecoratedDnD.html applet test to main
4e83f4c: 8328185: Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main
d3f3011: 7036144: GZIPInputStream readTrailer uses faulty available() test for end-of-stream
e5e7cd2: 8328386: Convert java/awt/FileDialog/FileNameOverrideTest test to main
... and 170 more: https://git.openjdk.org/jdk/compare/f2b5ffdb8ea3c766f14bab1dfd7c3865cffa2ce8...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-03-21T07:30:55Z

@kumarabhi006 Pushed as commit 65d9f11.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Applet test converted to maim manual

68ce8dd

openjdk bot added the rfr Pull request is ready for review label Mar 18, 2024

openjdk bot added the client client-libs-dev@openjdk.org label Mar 18, 2024

honkar-jdk approved these changes Mar 20, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Mar 20, 2024

minor fix

9c350b0

TejeshR13 reviewed Mar 20, 2024

View reviewed changes

TejeshR13 approved these changes Mar 21, 2024

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Mar 21, 2024

openjdk bot closed this Mar 21, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8328328: Convert javax/swing/JTabbedPane/4666224/bug4666224.java applet test to main #18340

8328328: Convert javax/swing/JTabbedPane/4666224/bug4666224.java applet test to main #18340

kumarabhi006 commented Mar 18, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Mar 18, 2024

openjdk bot commented Mar 18, 2024 •

edited

Loading

openjdk bot commented Mar 18, 2024

mlbridge bot commented Mar 18, 2024 •

edited

Loading

honkar-jdk left a comment

honkar-jdk Mar 20, 2024

kumarabhi006 Mar 20, 2024

honkar-jdk Mar 20, 2024

honkar-jdk Mar 20, 2024

TejeshR13 Mar 20, 2024

kumarabhi006 Mar 20, 2024

TejeshR13 Mar 20, 2024

kumarabhi006 Mar 20, 2024

TejeshR13 Mar 20, 2024

kumarabhi006 Mar 20, 2024

TejeshR13 Mar 20, 2024

kumarabhi006 commented Mar 21, 2024

openjdk bot commented Mar 21, 2024

openjdk bot commented Mar 21, 2024

8328328: Convert javax/swing/JTabbedPane/4666224/bug4666224.java applet test to main #18340

8328328: Convert javax/swing/JTabbedPane/4666224/bug4666224.java applet test to main #18340

Conversation

kumarabhi006 commented Mar 18, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Mar 18, 2024

openjdk bot commented Mar 18, 2024 • edited Loading

openjdk bot commented Mar 18, 2024

mlbridge bot commented Mar 18, 2024 • edited Loading

Webrevs

honkar-jdk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kumarabhi006 commented Mar 21, 2024

openjdk bot commented Mar 21, 2024

openjdk bot commented Mar 21, 2024

kumarabhi006 commented Mar 18, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Mar 18, 2024 •

edited

Loading

mlbridge bot commented Mar 18, 2024 •

edited

Loading