8328341: Remove deprecated per-thread compiler stats in sun.management

[eirbjo]

Please review this cleanup PR which removes per-thread compiler stats from sun.management

This removes:

• The deprecated interface method HotspotCompilationMBean.getCompilerThreadStats() along with the implementation method in HotspotCompilation
• The class returned by these methods, CompilerThreadStat
• The nested class HotspotCompilation.CompilerThreadInfo which now falls out of use
• The field HotspotCompilation.threads, along with its initialization in initCompilerCounters

This was initially discussed here: https://mail.openjdk.org/pipermail/serviceability-dev/2024-March/054589.html

Testing and verification: As this is purely a removal and cleanup PR of unused code, no updates are made on the testing side. I have verified that the string getCompilerThreadStats is not found in OpenJDK after this PR.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8328341: Remove deprecated per-thread compiler stats in sun.management (Enhancement - P4)

Reviewers

• Kevin Walls (@kevinjwalls - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18344/head:pull/18344
$ git checkout pull/18344

Update a local copy of the PR:
$ git checkout pull/18344
$ git pull https://git.openjdk.org/jdk.git pull/18344/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18344

View PR using the GUI difftool:
$ git pr show -t 18344

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18344.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back eirbjo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@eirbjo The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

@eirbjo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328341: Remove deprecated per-thread compiler stats in sun.management

Reviewed-by: kevinw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 116 new commits pushed to the master branch:

• c0fc956: 8328275: CodeCache::print_internals should not be called in PRODUCT code
• 4ef591f: 8326964: Remove Eclipse Shared Workspaces
• ac5b6cb: 8327757: Convert javax/swing/JSlider/6524424/bug6524424.java applet to main
• 652fb3a: 8328154: Convert sun/java2d/loops/CopyAreaSpeed.java applet test to main
• 9059727: 8327182: Move serverAlias into the loop
• 2dd5fba: 8319889: Vector API tests trigger VM crashes with -XX:+StressIncrementalInlining
• 3f2e849: 8280392: java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java failed with "RuntimeException: Test failed."
• c901da4: 8327098: GTest needs larger combination limit
• 9e32db2: 8328309: Remove malformed masked shift instruction selection patterns
• fc0472b: 8328000: Convert /java/awt/im/8154816/bug8154816.java applet test to main
• ... and 106 more: https://git.openjdk.org/jdk/compare/b9c3dc3b47459890f4abdea2f3367662d3467289...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (149f93fc)

[kevinjwalls]

Yes, looks good.
No problems with testst in test/jdk/javax/management or test/jdk/sun/management.

[eirbjo]

Thanks for reviewing, Kevin!

/integrate

[openjdk]

Going to push as commit 9214a62.
Since your change was applied there have been 129 commits pushed to the master branch:

• 1329216: 8328261: public lookup fails with IllegalAccessException when used while module system is being initialized
• 3b305d5: 8313306: More sensible memory reservation logging
• f140eb4: 8297879: javadoc link to preview JEP 1000 has grouping character comma
• 5f2a92d: 8328244: Convert javax/swing/JSlider/6742358/bug6742358.java applet test to main
• 2094ff3: 8328279: Convert java/awt/Cursor/CursorOverlappedPanelsTest test to main
• db4842c: 8328364: Remove redundant fields in 'BOTConstants'
• c01095c: 8328262: Convert javax/swing/JSplitPane/8132123/bug8132123.java applet test to main
• f1c69cc: 8289822: G1: Make concurrent mark code owner of TAMSes
• 5b6b514: 8325362: Allow to create a simple in-memory input JavaFileObject
• c59c41a: 8326941: Remove StringUTF16::isBigEndian
• ... and 119 more: https://git.openjdk.org/jdk/compare/b9c3dc3b47459890f4abdea2f3367662d3467289...master

Your commit was automatically rebased without conflicts.

[openjdk]

@eirbjo Pushed as commit 9214a62.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.