8328378: Convert java/awt/FileDialog/FileDialogForDirectories test to main #18358
Conversation
… main Convert test to main manual and move to the appropriate folder Remove old files
|
👋 Welcome back kizune! A progress list of the required criteria for merging this PR into |
|
@azuev-java This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 146 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@azuev-java The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
| /* | ||
| * @test | ||
| * @bug 7161437 | ||
| * @summary We should support "apple.awt.fileDialogForDirectories" property. |
There was a problem hiding this comment.
@library is missing...Does it work for you without this? I see most of your latest PRs doesn't have this tag
There was a problem hiding this comment.
I had PassFailJFrame.class in my classpath so i could run these tests easier. I fixed all of the headers now.
| private static Button showBtn; | ||
| private static FileDialog fd; |
There was a problem hiding this comment.
Can be made local in main
There was a problem hiding this comment.
Still could have been made local...
|
/integrate |
|
Going to push as commit e0373e0.
Your commit was automatically rebased without conflicts. |
openjdk
bot
removed
ready
|
@azuev-java Pushed as commit e0373e0. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Convert test to main manual and move to the appropriate folder
Remove old files
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18358/head:pull/18358$ git checkout pull/18358Update a local copy of the PR:
$ git checkout pull/18358$ git pull https://git.openjdk.org/jdk.git pull/18358/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18358View PR using the GUI difftool:
$ git pr show -t 18358Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18358.diff
Webrev
Link to Webrev Comment