Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8328384: Convert java/awt/FileDialog/FileDialogOpenDirTest test to main #18361

Closed
wants to merge 7 commits into from
Closed

8328384: Convert java/awt/FileDialog/FileDialogOpenDirTest test to main #18361

wants to merge 7 commits into from

Conversation

azuev-java
Copy link
Member

@azuev-java azuev-java commented Mar 18, 2024 •
edited by openjdk bot
Loading

Convert test to main manual;
Move test to appropriate folder;
Delete old files;

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8328384: Convert java/awt/FileDialog/FileDialogOpenDirTest test to main (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18361/head:pull/18361
$ git checkout pull/18361

Update a local copy of the PR:
$ git checkout pull/18361
$ git pull https://git.openjdk.org/jdk.git pull/18361/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18361

View PR using the GUI difftool:
$ git pr show -t 18361

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18361.diff

Webrev

Link to Webrev Comment

@azuev-java
8328384: Convert java/awt/FileDialog/FileDialogOpenDirTest test to main
8e81093 
Convert test to main manual;
Move test to appropriate folder;
Delete old files;
@azuev-java
Reorganize imports.
874de3d
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 18, 2024

👋 Welcome back kizune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 18, 2024 •
edited
Loading

@azuev-java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328384: Convert java/awt/FileDialog/FileDialogOpenDirTest test to main

Reviewed-by: azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 211 new commits pushed to the master branch:

  • 13cf070: 8328556: Do not extract large CKO_SECRET_KEY keys from the NSS Software Token
  • 709410d: 8328679: Improve comment for UNSAFE_ENTRY_SCOPED in unsafe.cpp
  • f207aa9: 8326960: GHA: RISC-V sysroot cannot be debootstrapped due to ongoing Debian t64 transition
  • e80619a: 8328680: Introduce JDK_LIB, and clean up module native compilation
  • 638708c: 8328697: SubMenuShowTest and SwallowKeyEvents tests stabilization
  • e06b568: 8328602: Parallel: Incorrect assertion in fill_dense_prefix_end
  • 528efe2: 8328484: Convert and Opensource few JFileChooser applet test to main
  • d379afb: 8328312: runtime/stack/Stack0*.java fails intermittently on libgraal
  • cd534f8: 8328673: Convert closed text/html/CSS manual applet test to main
  • 38e3cda: 8328670: Automate and open source few closed manual applet test
  • ... and 201 more: https://git.openjdk.org/jdk/compare/1f43fa0f8b0f956b41015e0ebc257e15a11ad99b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 18, 2024
@openjdk
Copy link

openjdk bot commented Mar 18, 2024

@azuev-java The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 18, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 18, 2024 •
edited
Loading

Webrevs

azuev-java and others added 3 commits March 19, 2024 07:05
@azuev-java
Adding library and build clauses
5b8216b
@azuev-java @turbanoff
Update test/jdk/java/awt/FileDialog/FileDialogOpenDirTest.java
9c9e8fb 
Co-authored-by: Andrey Turbanov <turbanoff@gmail.com>
@azuev-java
Moving test metadata closer to the class definition for better readab…
6dd4e7f 
…ility;

Making test automatically skip execution on unsuported toolkit;
Eliminated the separate frame, moving button inside the PassFailJFrame;
Corrected test instructions accordingly;
azvegint
azvegint approved these changes Mar 21, 2024
View reviewed changes
test/jdk/java/awt/FileDialog/FileDialogOpenDirTest.java Outdated Show resolved Hide resolved
test/jdk/java/awt/FileDialog/FileDialogOpenDirTest.java Outdated
Comment on lines 65 to 68
String toolkit = Toolkit.getDefaultToolkit().getClass().getName();
if (!toolkit.equals("sun.awt.X11.XToolkit")) {
throw new SkippedException("Test is not designed for toolkit " + toolkit);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cay be moved to the beginning of the main, to bail out early.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 21, 2024
azuev-java and others added 2 commits March 22, 2024 08:37
@azuev-java
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 22, 2024

Going to push as commit 739957c.
Since your change was applied there have been 211 commits pushed to the master branch:

  • 13cf070: 8328556: Do not extract large CKO_SECRET_KEY keys from the NSS Software Token
  • 709410d: 8328679: Improve comment for UNSAFE_ENTRY_SCOPED in unsafe.cpp
  • f207aa9: 8326960: GHA: RISC-V sysroot cannot be debootstrapped due to ongoing Debian t64 transition
  • e80619a: 8328680: Introduce JDK_LIB, and clean up module native compilation
  • 638708c: 8328697: SubMenuShowTest and SwallowKeyEvents tests stabilization
  • e06b568: 8328602: Parallel: Incorrect assertion in fill_dense_prefix_end
  • 528efe2: 8328484: Convert and Opensource few JFileChooser applet test to main
  • d379afb: 8328312: runtime/stack/Stack0*.java fails intermittently on libgraal
  • cd534f8: 8328673: Convert closed text/html/CSS manual applet test to main
  • 38e3cda: 8328670: Automate and open source few closed manual applet test
  • ... and 201 more: https://git.openjdk.org/jdk/compare/1f43fa0f8b0f956b41015e0ebc257e15a11ad99b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 22, 2024
@openjdk openjdk bot closed this Mar 22, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 22, 2024
@openjdk
Copy link

openjdk bot commented Mar 22, 2024

@azuev-java Pushed as commit 739957c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbanoff turbanoff turbanoff left review comments

@azvegint azvegint azvegint approved these changes

Assignees
No one assigned
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azuev-java @turbanoff @azvegint