Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8328379 : Convert URLDragTest.html applet test to main #18364

Closed
wants to merge 3 commits into from

Conversation

honkar-jdk
Copy link
Contributor

@honkar-jdk honkar-jdk commented Mar 18, 2024

Following test - test/jdk/java/awt/dnd/URLDragTest/URLDragTest.html is converted from applet to main using PassFailJFrame.

PassFailJFrame's logArea() is used for logging messages.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8328379: Convert URLDragTest.html applet test to main (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18364/head:pull/18364
$ git checkout pull/18364

Update a local copy of the PR:
$ git checkout pull/18364
$ git pull https://git.openjdk.org/jdk.git pull/18364/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18364

View PR using the GUI difftool:
$ git pr show -t 18364

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18364.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 18, 2024

👋 Welcome back honkar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 18, 2024

@honkar-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328379: Convert URLDragTest.html applet test to main

Reviewed-by: abhiscxk, psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 44 new commits pushed to the master branch:

  • a68f5d7: 8327879: Convert javax/swing/border/Test4760089.java applet test to main
  • 269163d: 8328387: Convert java/awt/Frame/FrameStateTest/FrameStateTest.html applet test to main
  • 7231fd7: 8328350: G1: Remove DO_DISCOVERED_AND_DISCOVERY
  • 4f8f486: 8328012: Convert InputMethod (/java/awt/im) applet tests to main
  • 9ca4ae3: 8328264: AArch64: remove UseNeon condition in CRC32 intrinsic
  • 9214a62: 8328341: Remove deprecated per-thread compiler stats in sun.management
  • 1329216: 8328261: public lookup fails with IllegalAccessException when used while module system is being initialized
  • 3b305d5: 8313306: More sensible memory reservation logging
  • f140eb4: 8297879: javadoc link to preview JEP 1000 has grouping character comma
  • 5f2a92d: 8328244: Convert javax/swing/JSlider/6742358/bug6742358.java applet test to main
  • ... and 34 more: https://git.openjdk.org/jdk/compare/0204aacb0305e94a7d6d5299a5ae835f3f71b030...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 18, 2024
@openjdk
Copy link

openjdk bot commented Mar 18, 2024

@honkar-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 18, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 18, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 20, 2024
@honkar-jdk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 20, 2024

Going to push as commit fbeac98.
Since your change was applied there have been 53 commits pushed to the master branch:

  • 96530bc: 8326521: JFR: CompilerPhase event test fails on windows 32 bit
  • a112fc8: 8328225: Convert ImageDecoratedDnD.html applet test to main
  • 4e83f4c: 8328185: Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main
  • d3f3011: 7036144: GZIPInputStream readTrailer uses faulty available() test for end-of-stream
  • e5e7cd2: 8328386: Convert java/awt/FileDialog/FileNameOverrideTest test to main
  • 1b68c73: 8328377: Convert java/awt/Cursor/MultiResolutionCursorTest test to main
  • e0373e0: 8328378: Convert java/awt/FileDialog/FileDialogForDirectories test to main
  • 03c25b1: 8328367: Convert java/awt/Component/UpdatingBootTime test to main
  • eebcc21: 8328524: [x86] StringRepeat.java failure on linux-x86: Could not reserve enough space for 2097152KB object heap
  • a68f5d7: 8327879: Convert javax/swing/border/Test4760089.java applet test to main
  • ... and 43 more: https://git.openjdk.org/jdk/compare/0204aacb0305e94a7d6d5299a5ae835f3f71b030...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 20, 2024
@openjdk openjdk bot closed this Mar 20, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 20, 2024
@openjdk
Copy link

openjdk bot commented Mar 20, 2024

@honkar-jdk Pushed as commit fbeac98.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants