8328403: Remove applet usage from JColorChooser tests Test6977726

[alisenchung]

Removing applet usage from manual JColorChooser tests

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8328403: Remove applet usage from JColorChooser tests Test6977726 (Bug - P4)

Reviewers

• Tejesh R (@TejeshR13 - Committer) ⚠️ Review applies to d0818756
• Harshitha Onkar (@honkar-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18369/head:pull/18369
$ git checkout pull/18369

Update a local copy of the PR:
$ git checkout pull/18369
$ git pull https://git.openjdk.org/jdk.git pull/18369/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18369

View PR using the GUI difftool:
$ git pr show -t 18369

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18369.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back achung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alisenchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328403: Remove applet usage from JColorChooser tests Test6977726

Reviewed-by: tr, honkar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 213 new commits pushed to the master branch:

• 20cb6e7: 8329337: Problem list BufferStrategyExceptionTest.java on Windows
• d1b51e3: 8321550: Update several runtime/cds tests to use vm flags or mark as flagless
• 8a0ef81: 8326627: Document Double/Float.valueOf(String) behavior for numeric strings with non-ASCII digits
• 5b05f8e: 8329112: Clean up CDS checking of unsupported module options
• 59c2aff: 8323624: ProviderList.ServiceList does not need to be a list
• 418deaf: 8328361: Use memset() in method CardTable::dirty_MemRegion()
• 245514d: 8328953: JEditorPane.read throws ChangedCharSetException
• df01cc5: 8323576: [Windows] Fallthrough to ::abort instead of os::infinite_sleep for noreturn methods
• bf93e77: 8329118: Run MessageFormat additional subformat pattern tests under en_US locale
• 991e04e: 8327383: Clean up _Stalled and _Spinner fields
• ... and 203 more: https://git.openjdk.org/jdk/compare/be1dd275a4b4fcae00e4c3c48b3e8e4b1d84ba2b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@alisenchung The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 05: Full - Incremental (dad92188)
• 04: Full - Incremental (ff6f5e51)
• 03: Full - Incremental (8f03f04c)
• 02: Full - Incremental (39b41d55)
• 01: Full - Incremental (d0818756)
• 00: Full (19fa62e8)

[azvegint]

Check that there is a panel with white text titled "Preview" in the JColorChooser.

I read it as if the text should be titled "Preview", although it should actually refer to the panel(maybe I'm wrong).

Since you modified the original "If you don't see the preview panel" by adding the "white text" check, you should check it on all platforms/LaFs that this text is really white and distinguishable from the background, otherwise it might come back to us one day with a failure of this test.

[alisenchung]

When I wrote it I meant to say "Check that there is a panel (with white text) titled 'Preview'", but now that I read it again it is pretty unclear..
Does
Check that there is a panel with \"Text Preview Panel\" text and with title \"Preview\" in the JColorChooser.
make more sense?

[prrace]

are you going to reduce the timeout as Alexander suggested ?

[alisenchung]

are you going to reduce the timeout as Alexander suggested ?

I've lowered the timeout to 2 minutes

[honkar-jdk]

LGTM

[alisenchung]

/integrate

[openjdk]

Going to push as commit 1e76e1f.
Since your change was applied there have been 216 commits pushed to the master branch:

• 9d052e9: 8329131: Fold libjli_static back into libjli on AIX
• f2e5808: 8329126: No native wrappers generated anymore with -XX:-TieredCompilation after JDK-8251462
• 37c2279: 8329150: Remove CDS support for LatestMethodCache
• 20cb6e7: 8329337: Problem list BufferStrategyExceptionTest.java on Windows
• d1b51e3: 8321550: Update several runtime/cds tests to use vm flags or mark as flagless
• 8a0ef81: 8326627: Document Double/Float.valueOf(String) behavior for numeric strings with non-ASCII digits
• 5b05f8e: 8329112: Clean up CDS checking of unsupported module options
• 59c2aff: 8323624: ProviderList.ServiceList does not need to be a list
• 418deaf: 8328361: Use memset() in method CardTable::dirty_MemRegion()
• 245514d: 8328953: JEditorPane.read throws ChangedCharSetException
• ... and 206 more: https://git.openjdk.org/jdk/compare/be1dd275a4b4fcae00e4c3c48b3e8e4b1d84ba2b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alisenchung Pushed as commit 1e76e1f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.