Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 19, 2024

…rve enough space for 2097152KB object heap

I would like to fix this as the two related issues mentioned in the JBS bug.
We see it currently in most GHA runs.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8328524: [x86] StringRepeat.java failure on linux-x86: Could not reserve enough space for 2097152KB object heap (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18380/head:pull/18380
$ git checkout pull/18380

Update a local copy of the PR:
$ git checkout pull/18380
$ git pull https://git.openjdk.org/jdk.git pull/18380/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18380

View PR using the GUI difftool:
$ git pr show -t 18380

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18380.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 19, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 19, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328524: [x86] StringRepeat.java failure on linux-x86: Could not reserve enough space for 2097152KB object heap

Reviewed-by: rriggs, mdoerr, sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 3b305d5: 8313306: More sensible memory reservation logging
  • f140eb4: 8297879: javadoc link to preview JEP 1000 has grouping character comma
  • 5f2a92d: 8328244: Convert javax/swing/JSlider/6742358/bug6742358.java applet test to main
  • 2094ff3: 8328279: Convert java/awt/Cursor/CursorOverlappedPanelsTest test to main
  • db4842c: 8328364: Remove redundant fields in 'BOTConstants'
  • c01095c: 8328262: Convert javax/swing/JSplitPane/8132123/bug8132123.java applet test to main
  • f1c69cc: 8289822: G1: Make concurrent mark code owner of TAMSes

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8328524: [x86] StringRepeat.java failure on linux-x86: Could not rese… 8328524: [x86] StringRepeat.java failure on linux-x86: Could not reserve enough space for 2097152KB object heap Mar 19, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 19, 2024
@openjdk
Copy link

openjdk bot commented Mar 19, 2024

@GoeLin The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Mar 19, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 19, 2024

Webrevs

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 19, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Mar 20, 2024

GHA failure: known Risc-V build problem.

@GoeLin
Copy link
Member Author

GoeLin commented Mar 20, 2024

/integrate

@GoeLin
Copy link
Member Author

GoeLin commented Mar 20, 2024

Thanks for the reviews!

@openjdk
Copy link

openjdk bot commented Mar 20, 2024

Going to push as commit eebcc21.
Since your change was applied there have been 14 commits pushed to the master branch:

  • a68f5d7: 8327879: Convert javax/swing/border/Test4760089.java applet test to main
  • 269163d: 8328387: Convert java/awt/Frame/FrameStateTest/FrameStateTest.html applet test to main
  • 7231fd7: 8328350: G1: Remove DO_DISCOVERED_AND_DISCOVERY
  • 4f8f486: 8328012: Convert InputMethod (/java/awt/im) applet tests to main
  • 9ca4ae3: 8328264: AArch64: remove UseNeon condition in CRC32 intrinsic
  • 9214a62: 8328341: Remove deprecated per-thread compiler stats in sun.management
  • 1329216: 8328261: public lookup fails with IllegalAccessException when used while module system is being initialized
  • 3b305d5: 8313306: More sensible memory reservation logging
  • f140eb4: 8297879: javadoc link to preview JEP 1000 has grouping character comma
  • 5f2a92d: 8328244: Convert javax/swing/JSlider/6742358/bug6742358.java applet test to main
  • ... and 4 more: https://git.openjdk.org/jdk/compare/5b6b514441fcbbaa210e2cad08ce2704fdf38191...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 20, 2024
@openjdk openjdk bot closed this Mar 20, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 20, 2024
@openjdk
Copy link

openjdk bot commented Mar 20, 2024

@GoeLin Pushed as commit eebcc21.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants