Skip to content

8328560: java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports Applet#18386

Closed
prrace wants to merge 3 commits intoopenjdk:masterfrom
prrace:click
Closed

8328560: java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports Applet#18386
prrace wants to merge 3 commits intoopenjdk:masterfrom
prrace:click

Conversation

@prrace
Copy link
Contributor

@prrace prrace commented Mar 19, 2024

This seems to have been some previous not very complete conversion of a test from applet to main.
It even still had Applet imported and miscellaneous comments. I've cleaned it up.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8328560: java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports Applet (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18386/head:pull/18386
$ git checkout pull/18386

Update a local copy of the PR:
$ git checkout pull/18386
$ git pull https://git.openjdk.org/jdk.git pull/18386/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18386

View PR using the GUI difftool:
$ git pr show -t 18386

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18386.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 19, 2024

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 19, 2024

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328560: java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports Applet

Reviewed-by: azvegint, abhiscxk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 65 new commits pushed to the master branch:

  • 7006790: 8328628: JDK-8328157 incorrectly sets -MT on all compilers in jdk.jpackage
  • 68170ae: 8328238: Convert few closed manual applet tests to main
  • 9f5ad43: 8320675: PrinterJob/SecurityDialogTest.java hangs
  • 684678f: 8328633: s390x: Improve vectorization of Match.sqrt() on floats
  • 93d1700: 8328589: unify os::breakpoint among posix platforms
  • a5a2eca: 8327683: Crash with primitive type pattern and generic expression in instanceof
  • 65d9f11: 8328328: Convert javax/swing/JTabbedPane/4666224/bug4666224.java applet test to main
  • 481473e: 8328035: Convert javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main
  • dea94f4: 8328300: Convert PrintDialogsTest.java from Applet to main program
  • d32746e: 8296244: Alternate implementation of user-based authorization Subject APIs that doesn’t depend on Security Manager APIs
  • ... and 55 more: https://git.openjdk.org/jdk/compare/0204aacb0305e94a7d6d5299a5ae835f3f71b030...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8328560 8328560: java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports Applet Mar 19, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 19, 2024
@openjdk
Copy link

openjdk bot commented Mar 19, 2024

@prrace The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 19, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 19, 2024

Webrevs

robot.waitForIdle();
robot.delay(1000);
if (!ready) {
System.out.println("Not Activated. Test fails");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks redundant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to log, so I think it should stay

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 20, 2024
@prrace
Copy link
Contributor Author

prrace commented Mar 21, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Mar 21, 2024

Going to push as commit e81374e.
Since your change was applied there have been 79 commits pushed to the master branch:

  • cc5cda5: 8328005: Convert java/awt/im/JTextFieldTest.java applet test to main
  • ef2bd57: 8328558: Convert javax/swing/JCheckBox/8032667/bug8032667.java applet test to main
  • e66788c: 8325179: Race in BasicDirectoryModel.validateFileCache
  • 1496b5d: 8327924: Simplify TrayIconScalingTest.java
  • 16ed191: 8328101: Parallel: Obsolete ParallelOldDeadWoodLimiterMean and ParallelOldDeadWoodLimiterStdDev
  • 581b1e2: 8328402: Implement pausing functionality for the PassFailJFrame
  • 75195aa: 8328299: Convert DnDFileGroupDescriptor.html applet test to main
  • 725d87b: 8328570: Convert closed JViewport manual applet tests to main
  • e41bc42: 8327990: [macosx-aarch64] Various tests fail with -XX:+AssertWXAtThreadSync
  • 4308017: 8328631: Convert java/awt/InputMethods/InputMethodsTest/InputMethodsTest.java applet test to manual
  • ... and 69 more: https://git.openjdk.org/jdk/compare/0204aacb0305e94a7d6d5299a5ae835f3f71b030...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 21, 2024
@openjdk openjdk bot closed this Mar 21, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 21, 2024
@openjdk
Copy link

openjdk bot commented Mar 21, 2024

@prrace Pushed as commit e81374e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants