8328560: java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports Applet#18386
8328560: java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports Applet#18386prrace wants to merge 3 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back prr! A progress list of the required criteria for merging this PR into |
|
@prrace This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 65 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java
Show resolved
Hide resolved
test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java
Outdated
Show resolved
Hide resolved
test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java
Outdated
Show resolved
Hide resolved
test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java
Outdated
Show resolved
Hide resolved
test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java
Outdated
Show resolved
Hide resolved
test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java
Outdated
Show resolved
Hide resolved
test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java
Outdated
Show resolved
Hide resolved
test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java
Show resolved
Hide resolved
| robot.waitForIdle(); | ||
| robot.delay(1000); | ||
| if (!ready) { | ||
| System.out.println("Not Activated. Test fails"); |
There was a problem hiding this comment.
good to log, so I think it should stay
test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java
Outdated
Show resolved
Hide resolved
test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java
Show resolved
Hide resolved
test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java
Outdated
Show resolved
Hide resolved
|
/integrate |
|
Going to push as commit e81374e.
Your commit was automatically rebased without conflicts. |
This seems to have been some previous not very complete conversion of a test from applet to main.
It even still had Applet imported and miscellaneous comments. I've cleaned it up.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18386/head:pull/18386$ git checkout pull/18386Update a local copy of the PR:
$ git checkout pull/18386$ git pull https://git.openjdk.org/jdk.git pull/18386/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18386View PR using the GUI difftool:
$ git pr show -t 18386Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18386.diff
Webrev
Link to Webrev Comment