Skip to content

8328562: Convert java/awt/InputMethods/DiacriticsTest/DiacriticsTest.java applet test to main#18388

Closed
azvegint wants to merge 3 commits intoopenjdk:masterfrom
azvegint:testsprint_2024_03/8328562_DiacriticsTest
Closed

8328562: Convert java/awt/InputMethods/DiacriticsTest/DiacriticsTest.java applet test to main#18388
azvegint wants to merge 3 commits intoopenjdk:masterfrom
azvegint:testsprint_2024_03/8328562_DiacriticsTest

Conversation

@azvegint
Copy link
Member

@azvegint azvegint commented Mar 20, 2024

Test converted to main.
Instructions split to Windows and Linux, with some clarifications.
The test runs successfully on Windows and Linux.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8328562: Convert java/awt/InputMethods/DiacriticsTest/DiacriticsTest.java applet test to main (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18388/head:pull/18388
$ git checkout pull/18388

Update a local copy of the PR:
$ git checkout pull/18388
$ git pull https://git.openjdk.org/jdk.git pull/18388/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18388

View PR using the GUI difftool:
$ git pr show -t 18388

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18388.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 20, 2024

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 20, 2024

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328562: Convert java/awt/InputMethods/DiacriticsTest/DiacriticsTest.java applet test to main

Reviewed-by: tr, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 77 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 20, 2024
@openjdk
Copy link

openjdk bot commented Mar 20, 2024

@azvegint The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 20, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 20, 2024

Webrevs

Copy link
Contributor

@prrace prrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test looks to be a good example why we should be considering a new jtreg key like
@key keyboard
or
@key locale

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 23, 2024
@azvegint
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 25, 2024

Going to push as commit fb8f2a0.
Since your change was applied there have been 97 commits pushed to the master branch:

  • 447436e: 8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960
  • c7cf602: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest test to main
  • 78d1b90: 8328380: Remove applet usage from JColorChooser tests Test6348456
  • 907e30f: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket
  • 70a15c7: 8328825: Google CAInterop test failures
  • a1fbbff: 8328717: Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to main
  • 26b2ec4: 8328824: Clean up java.base native compilation
  • af15c68: 8321278: C2: Partial peeling fails with assert "last_peel <- first_not_peeled"
  • 142c311: 8328744: Parallel: Parallel GC throws OOM before heap is fully expanded
  • cb2a671: 8324121: SIGFPE in PhaseIdealLoop::extract_long_range_checks
  • ... and 87 more: https://git.openjdk.org/jdk/compare/7231fd78aada80946b680e10227a356714d5c34b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 25, 2024
@openjdk openjdk bot closed this Mar 25, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 25, 2024
@openjdk
Copy link

openjdk bot commented Mar 25, 2024

@azvegint Pushed as commit fb8f2a0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants