JDK-8328589: unify os::breakpoint among posix platforms

[MBaesken]

Seems we can unify os::breakpoint among the posix platforms supported in OpenJDK.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8328589: unify os::breakpoint among posix platforms (Enhancement - P4)

Reviewers

• Lutz Schmidt (@RealLucy - Reviewer)
• Andreas Steiner (@ansteiner - Author)
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18395/head:pull/18395
$ git checkout pull/18395

Update a local copy of the PR:
$ git checkout pull/18395
$ git pull https://git.openjdk.org/jdk.git pull/18395/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18395

View PR using the GUI difftool:
$ git pr show -t 18395

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18395.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328589: unify os::breakpoint among posix platforms

Reviewed-by: lucy, asteiner, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• 481473e: 8328035: Convert javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main
• dea94f4: 8328300: Convert PrintDialogsTest.java from Applet to main program
• d32746e: 8296244: Alternate implementation of user-based authorization Subject APIs that doesn’t depend on Security Manager APIs
• 000f4d8: 8319251: [REDO] Change LockingMode default from LM_LEGACY to LM_LIGHTWEIGHT
• fbeac98: 8328379: Convert URLDragTest.html applet test to main
• 96530bc: 8326521: JFR: CompilerPhase event test fails on windows 32 bit
• a112fc8: 8328225: Convert ImageDecoratedDnD.html applet test to main
• 4e83f4c: 8328185: Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main
• d3f3011: 7036144: GZIPInputStream readTrailer uses faulty available() test for end-of-stream
• e5e7cd2: 8328386: Convert java/awt/FileDialog/FileNameOverrideTest test to main
• ... and 3 more: https://git.openjdk.org/jdk/compare/eebcc2181fe27f6aa10559233c7c58882a146f56...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (fa80ba1a)

[RealLucy]

LGTM
Nice cleanup.

[ansteiner]

LGTM

[dholmes-ora]

LGTM2

Thanks

[MBaesken]

Thanks for the reviews !

/integrate

[openjdk]

Going to push as commit 93d1700.
Since your change was applied there have been 15 commits pushed to the master branch:

• a5a2eca: 8327683: Crash with primitive type pattern and generic expression in instanceof
• 65d9f11: 8328328: Convert javax/swing/JTabbedPane/4666224/bug4666224.java applet test to main
• 481473e: 8328035: Convert javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main
• dea94f4: 8328300: Convert PrintDialogsTest.java from Applet to main program
• d32746e: 8296244: Alternate implementation of user-based authorization Subject APIs that doesn’t depend on Security Manager APIs
• 000f4d8: 8319251: [REDO] Change LockingMode default from LM_LEGACY to LM_LIGHTWEIGHT
• fbeac98: 8328379: Convert URLDragTest.html applet test to main
• 96530bc: 8326521: JFR: CompilerPhase event test fails on windows 32 bit
• a112fc8: 8328225: Convert ImageDecoratedDnD.html applet test to main
• 4e83f4c: 8328185: Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main
• ... and 5 more: https://git.openjdk.org/jdk/compare/eebcc2181fe27f6aa10559233c7c58882a146f56...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit 93d1700.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.