8324121: SIGFPE in PhaseIdealLoop::extract_long_range_checks #18397

rwestrel · 2024-03-20T12:17:03Z

Both failures occur because ABS(scale * stride_con) overflows (scale
a really large long number). I reworked the test so overflow is no
longer an issue.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8324121: SIGFPE in PhaseIdealLoop::extract_long_range_checks (Bug - P3)

Reviewers

Vladimir Kozlov (@vnkozlov - Reviewer)
Christian Hagedorn (@chhagedorn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18397/head:pull/18397
$ git checkout pull/18397

Update a local copy of the PR:
$ git checkout pull/18397
$ git pull https://git.openjdk.org/jdk.git pull/18397/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18397

View PR using the GUI difftool:
$ git pr show -t 18397

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18397.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-03-20T12:17:55Z

👋 Welcome back roland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-03-20T12:18:56Z

@rwestrel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324121: SIGFPE in PhaseIdealLoop::extract_long_range_checks

Reviewed-by: kvn, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 272 new commits pushed to the master branch:

acc4a82: 8328862: Remove unused GrowableArrayFilterIterator
9f920b9: 8324655: Identify integer minimum and maximum patterns created with if statements
c7b9dc4: 8328404: RISC-V: Fix potential crash in C2_MacroAssembler::arrays_equals
bc73963: 8328303: 3 JDI tests timed out with UT enabled
476421e: 8328370: Convert java/awt/print/Dialog/PrintApplet.java applet test to main
c013fa1: 8328194: Add a test to check default rendering engine
f33a844: 8325536: JVM crash during CDS archive creation with -XX:+AllowArchivingWithJavaAgent
4324e3b: 8328612: AdaptiveSizePolicySpaceOverheadTester::is_exceeded() print max_eden_size twice
c7bbf84: 8328190: Convert AWTPanelSmoothWheel.html applet test to main
23ebd9c: 8328555: hidpi problems for test java/awt/Dialog/DialogAnotherThread/JaWSTest.java
... and 262 more: https://git.openjdk.org/jdk/compare/784f11c35d7f8646c7354c756ac8801a3d685874...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-03-20T12:19:21Z

@rwestrel The following label will be automatically applied to this pull request:

hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-03-20T12:22:33Z

Webrevs

01: Full - Incremental (d4cddf82)
00: Full (6890e385)

vnkozlov · 2024-03-20T18:23:08Z

src/hotspot/share/opto/loopnode.cpp

@@ -1106,7 +1107,8 @@ int PhaseIdealLoop::extract_long_range_checks(const IdealLoopTree* loop, jlong s
        jlong scale = 0;
        if (loop->is_range_check_if(if_proj, this, T_LONG, phi, range, offset, scale) &&
            loop->is_invariant(range) && loop->is_invariant(offset) &&
-            original_iters_limit / ABS(scale * stride_con) >= min_iters) {
+            original_iters_limit / ABS(scale) >= min_iters * ABS(stride_con)) {


I assume there is check somewhere that stride_con is not MIN_INT.

In my opinion ABS() should assert that it has legal input (not MIN_INT) and output (non-negative value) in debug builds.

Thanks for reviewing this.
We can't get to this code if stride_con is MIN_INT because some other condition (that doesn't explicitly check that stride_con is not MIN_INT) causes a bail out from the transformation. I added an explicit bail out in that case in a new commit anyway to make the code more robust.

In my opinion ABS() should assert that it has legal input (not MIN_INT) and output (non-negative value) in debug builds.

I agree and filed JDK-8328934 for that.

Unfortunately, there is still an overflow here when scale is min_jlong.

Right but isn't it harmless in this particular case?

No, if it's undefined behavior, we can't be sure what result the C++ compiler will give. And if we test with -ftrapv it will crash.

Ok. I filed https://bugs.openjdk.org/browse/JDK-8329163 to track it.

vnkozlov

Good.

chhagedorn

Looks good!

rwestrel · 2024-03-25T12:52:49Z

@vnkozlov @chhagedorn for the reviews

rwestrel · 2024-03-25T12:52:56Z

/integrate

openjdk · 2024-03-25T12:55:10Z

Going to push as commit cb2a671.
Since your change was applied there have been 279 commits pushed to the master branch:

0c1b254: 8326438: C2: assert(ld->in(1)->Opcode() == Op_LoadN) failed: Assumption invalid: input to DecodeN is not LoadN
29ba4b7: 8328705: GHA: Cross-compilation jobs do not require build JDK
f67ec19: 8079786: [macosx] Test java/awt/Frame/DisposeParentGC/DisposeParentGC.java fails for Mac only
93579c2: 8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment
b235682: 8328709: AIX os::get_summary_cpu_info support Power 10
19a0151: 8328700: Unused import and variable should be deleted in regex package
cf9b5a7: 8328776: [AIX] remove checked_vmgetinfo, use vmgetinfo directly
acc4a82: 8328862: Remove unused GrowableArrayFilterIterator
9f920b9: 8324655: Identify integer minimum and maximum patterns created with if statements
c7b9dc4: 8328404: RISC-V: Fix potential crash in C2_MacroAssembler::arrays_equals
... and 269 more: https://git.openjdk.org/jdk/compare/784f11c35d7f8646c7354c756ac8801a3d685874...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-03-25T12:55:17Z

@rwestrel Pushed as commit cb2a671.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

fix & test

6890e38

openjdk bot added the rfr Pull request is ready for review label Mar 20, 2024

openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Mar 20, 2024

vnkozlov reviewed Mar 20, 2024

View reviewed changes

review

d4cddf8

vnkozlov approved these changes Mar 22, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Mar 22, 2024

chhagedorn approved these changes Mar 25, 2024

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Mar 25, 2024

openjdk bot closed this Mar 25, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8324121: SIGFPE in PhaseIdealLoop::extract_long_range_checks #18397

8324121: SIGFPE in PhaseIdealLoop::extract_long_range_checks #18397

rwestrel commented Mar 20, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Mar 20, 2024

openjdk bot commented Mar 20, 2024 •

edited

Loading

openjdk bot commented Mar 20, 2024

mlbridge bot commented Mar 20, 2024 •

edited

Loading

vnkozlov Mar 20, 2024

dean-long Mar 20, 2024

rwestrel Mar 22, 2024

TobiHartmann Mar 25, 2024

dean-long Mar 25, 2024

rwestrel Mar 26, 2024

dean-long Mar 26, 2024

rwestrel Mar 27, 2024

vnkozlov left a comment

chhagedorn left a comment

rwestrel commented Mar 25, 2024

rwestrel commented Mar 25, 2024

openjdk bot commented Mar 25, 2024

openjdk bot commented Mar 25, 2024

8324121: SIGFPE in PhaseIdealLoop::extract_long_range_checks #18397

8324121: SIGFPE in PhaseIdealLoop::extract_long_range_checks #18397

Conversation

rwestrel commented Mar 20, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Mar 20, 2024

openjdk bot commented Mar 20, 2024 • edited Loading

openjdk bot commented Mar 20, 2024

mlbridge bot commented Mar 20, 2024 • edited Loading

Webrevs

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vnkozlov left a comment

Choose a reason for hiding this comment

chhagedorn left a comment

Choose a reason for hiding this comment

rwestrel commented Mar 25, 2024

rwestrel commented Mar 25, 2024

openjdk bot commented Mar 25, 2024

openjdk bot commented Mar 25, 2024

rwestrel commented Mar 20, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Mar 20, 2024 •

edited

Loading

mlbridge bot commented Mar 20, 2024 •

edited

Loading