8258682: compiler/intrinsics/mathexact/sanity tests fail with RepeatCompilation

[robcasloz]

Normalize match and suspect counts in the verify() method by the number of compilation repetitions, if the RepeatCompilation option is used.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8258682: compiler/intrinsics/mathexact/sanity tests fail with RepeatCompilation

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Christian Hagedorn (@chhagedorn - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1840/head:pull/1840
$ git checkout pull/1840

[bridgekeeper]

👋 Welcome back rcastanedalo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@robcasloz The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[robcasloz]

/summary
Normalize match and suspect counts in the verify() method by the number of
compilation repetitions, if the RepeatCompilation option is used.

[openjdk]

@robcasloz Setting summary to:

Normalize match and suspect counts in the verify() method by the number of
compilation repetitions, if the RepeatCompilation option is used.

[robcasloz]

Tested by running all compiler/intrinsics tests, with and without -XX:+UnlockDiagnosticVMOptions -XX:RepeatCompilation=42, on windows-x64, linux-x64, linux-aarch64, and macosx-x64 (both debug and release).

[mlbridge]

Webrevs

• 00: Full (2e9d771)

[vnkozlov]

Good.

[openjdk]

@robcasloz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258682: compiler/intrinsics/mathexact/sanity tests fail with RepeatCompilation

Normalize match and suspect counts in the verify() method by the number of
compilation repetitions, if the RepeatCompilation option is used.

Reviewed-by: kvn, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

• 1594372: 8258584: java/util/HexFormat/HexFormatTest.java fails on x86_32
• 30b9ff6: 8258653: CallJavaNode::_bci is not in use
• 12297a0: 8258736: No break in the loop
• 01d51a1: 8231622: SuppressWarning("serial") ignored on field serialVersionUID
• a06cea5: 8258396: SIGILL in jdk.jfr.internal.PlatformRecorder.rotateDisk()
• d234388: Merge
• e680ebe: 8258007: Add instrumentation to NativeLibraryTest
• c04c7e1: 8258002: Update "type" terminology in generated docs
• 45bd3b9: 8223607: --override-methods=summary ignores some signature changes
• 59ae054: 8258687: Build broken on Windows after fix for JDK-8258134
• ... and 27 more: https://git.openjdk.java.net/jdk/compare/853c04712d24788b6d30d54443ac9277a898311b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov, @chhagedorn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[robcasloz]

Good.

Thanks for reviewing, Vladimir!

[chhagedorn]

Looks good!

[robcasloz]

Looks good!

Thanks Christian!

[robcasloz]

/integrate
This change is ready for integration, please sponsor.

[openjdk]

@robcasloz
Your change (at version 2e9d771) is now ready to be sponsored by a Committer.

[chhagedorn]

/sponsor

[openjdk]

@chhagedorn @robcasloz Since your change was applied there have been 37 commits pushed to the master branch:

• 1594372: 8258584: java/util/HexFormat/HexFormatTest.java fails on x86_32
• 30b9ff6: 8258653: CallJavaNode::_bci is not in use
• 12297a0: 8258736: No break in the loop
• 01d51a1: 8231622: SuppressWarning("serial") ignored on field serialVersionUID
• a06cea5: 8258396: SIGILL in jdk.jfr.internal.PlatformRecorder.rotateDisk()
• d234388: Merge
• e680ebe: 8258007: Add instrumentation to NativeLibraryTest
• c04c7e1: 8258002: Update "type" terminology in generated docs
• 45bd3b9: 8223607: --override-methods=summary ignores some signature changes
• 59ae054: 8258687: Build broken on Windows after fix for JDK-8258134
• ... and 27 more: https://git.openjdk.java.net/jdk/compare/853c04712d24788b6d30d54443ac9277a898311b...master

Your commit was automatically rebased without conflicts.

Pushed as commit 3df6ec2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.