Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258682: compiler/intrinsics/mathexact/sanity tests fail with RepeatCompilation #1840

Closed
wants to merge 1 commit into from

Conversation

robcasloz
Copy link
Contributor

@robcasloz robcasloz commented Dec 18, 2020

Normalize match and suspect counts in the verify() method by the number of compilation repetitions, if the RepeatCompilation option is used.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258682: compiler/intrinsics/mathexact/sanity tests fail with RepeatCompilation

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1840/head:pull/1840
$ git checkout pull/1840

…ompilation

Normalize match and suspect counts in the verify() method by the number of
compilation repetitions, if the RepeatCompilation option is used.
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 18, 2020

👋 Welcome back rcastanedalo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 18, 2020

@robcasloz The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Dec 18, 2020
@robcasloz
Copy link
Contributor Author

/summary
Normalize match and suspect counts in the verify() method by the number of
compilation repetitions, if the RepeatCompilation option is used.

@openjdk
Copy link

openjdk bot commented Dec 18, 2020

@robcasloz Setting summary to:

Normalize match and suspect counts in the verify() method by the number of
compilation repetitions, if the RepeatCompilation option is used.

@robcasloz
Copy link
Contributor Author

Tested by running all compiler/intrinsics tests, with and without -XX:+UnlockDiagnosticVMOptions -XX:RepeatCompilation=42, on windows-x64, linux-x64, linux-aarch64, and macosx-x64 (both debug and release).

@robcasloz robcasloz marked this pull request as ready for review December 21, 2020 07:30
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 21, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 21, 2020

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@openjdk
Copy link

openjdk bot commented Dec 21, 2020

@robcasloz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258682: compiler/intrinsics/mathexact/sanity tests fail with RepeatCompilation

Normalize match and suspect counts in the verify() method by the number of
compilation repetitions, if the RepeatCompilation option is used.

Reviewed-by: kvn, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov, @chhagedorn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 21, 2020
@robcasloz
Copy link
Contributor Author

Good.

Thanks for reviewing, Vladimir!

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@robcasloz
Copy link
Contributor Author

Looks good!

Thanks Christian!

@robcasloz
Copy link
Contributor Author

/integrate
This change is ready for integration, please sponsor.

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 22, 2020
@openjdk
Copy link

openjdk bot commented Dec 22, 2020

@robcasloz
Your change (at version 2e9d771) is now ready to be sponsored by a Committer.

@chhagedorn
Copy link
Member

/sponsor

@openjdk openjdk bot closed this Dec 22, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 22, 2020
@openjdk
Copy link

openjdk bot commented Dec 22, 2020

@chhagedorn @robcasloz Since your change was applied there have been 37 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 3df6ec2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants