Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8328631: Convert java/awt/InputMethods/InputMethodsTest/InputMethodsTest.java applet test to manual #18412

Conversation

azvegint
Copy link
Member

@azvegint azvegint commented Mar 20, 2024

Test converted to main. Tested on Linux with Japanese ibus-anthy input method.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8328631: Convert java/awt/InputMethods/InputMethodsTest/InputMethodsTest.java applet test to manual (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18412/head:pull/18412
$ git checkout pull/18412

Update a local copy of the PR:
$ git checkout pull/18412
$ git pull https://git.openjdk.org/jdk.git pull/18412/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18412

View PR using the GUI difftool:
$ git pr show -t 18412

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18412.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 20, 2024

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 20, 2024

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328631: Convert java/awt/InputMethods/InputMethodsTest/InputMethodsTest.java applet test to manual

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • d32746e: 8296244: Alternate implementation of user-based authorization Subject APIs that doesn’t depend on Security Manager APIs
  • 000f4d8: 8319251: [REDO] Change LockingMode default from LM_LEGACY to LM_LIGHTWEIGHT
  • fbeac98: 8328379: Convert URLDragTest.html applet test to main
  • 96530bc: 8326521: JFR: CompilerPhase event test fails on windows 32 bit
  • a112fc8: 8328225: Convert ImageDecoratedDnD.html applet test to main
  • 4e83f4c: 8328185: Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 20, 2024
@openjdk
Copy link

openjdk bot commented Mar 20, 2024

@azvegint The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 20, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 20, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 20, 2024
@azvegint
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 21, 2024

Going to push as commit 4308017.
Since your change was applied there have been 19 commits pushed to the master branch:

  • 700d2b9: 8328401: Convert java/awt/Frame/InitialMaximizedTest/InitialMaximizedTest.html applet test to automated
  • bb3e84b: 8328592: hprof tests fail with -XX:-CompactStrings
  • ac2f8e5: 8327994: Update code gen in CallGeneratorHelper
  • c434b79: 8327169: serviceability/dcmd/vm/SystemMapTest.java and SystemDumpMapTest.java may fail after JDK-8326586
  • 7006790: 8328628: JDK-8328157 incorrectly sets -MT on all compilers in jdk.jpackage
  • 68170ae: 8328238: Convert few closed manual applet tests to main
  • 9f5ad43: 8320675: PrinterJob/SecurityDialogTest.java hangs
  • 684678f: 8328633: s390x: Improve vectorization of Match.sqrt() on floats
  • 93d1700: 8328589: unify os::breakpoint among posix platforms
  • a5a2eca: 8327683: Crash with primitive type pattern and generic expression in instanceof
  • ... and 9 more: https://git.openjdk.org/jdk/compare/d3f3011d56267360d65841da3550eca79cf1575b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 21, 2024
@openjdk openjdk bot closed this Mar 21, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 21, 2024
@openjdk
Copy link

openjdk bot commented Mar 21, 2024

@azvegint Pushed as commit 4308017.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants