8328648: Remove applet usage from JFileChooser tests bug4150029

[alisenchung]

Removing applet usage from manual JFileChooser tests

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8328648: Remove applet usage from JFileChooser tests bug4150029 (Bug - P4)

Reviewers

• Damon Nguyen (@DamonGuy - Committer) ⚠️ Review applies to ed8ed220
• Abhishek Kumar (@kumarabhi006 - Committer) ⚠️ Review applies to ed8ed220
• Harshitha Onkar (@honkar-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18415/head:pull/18415
$ git checkout pull/18415

Update a local copy of the PR:
$ git checkout pull/18415
$ git pull https://git.openjdk.org/jdk.git pull/18415/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18415

View PR using the GUI difftool:
$ git pr show -t 18415

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18415.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back achung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alisenchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328648: Remove applet usage from JFileChooser tests bug4150029

Reviewed-by: dnguyen, abhiscxk, honkar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

• 3057dde: 8329421: Native methods can not be selectively printed
• db15914: 8328753: Open source few Undecorated Frame tests
• 925d829: 8329013: StackOverflowError when starting Apache Tomcat with signed jar
• dd5d7d0: 8327002: (fs) java/nio/file/Files/CopyMoveVariations.java should be able to test across file systems
• 6ae1cf1: 8329368: Generational ZGC: Remove the unnecessary friend classes in ZAllocator
• 7eb78e3: 8320676: Manual printer tests have no Pass/Fail buttons, instructions close set 1
• 5ac067f: 8329289: Unify SetupJdkExecutable and SetupJdkLibrary
• 5ae849d: 8329292: Fix missing cleanups in java.management and jdk.management
• ed821cb: 8324807: Manual printer tests have no Pass/Fail buttons, instructions close set 2
• 5cf457b: 8329320: Simplify awt/print/PageFormat/NullPaper.java test
• ... and 28 more: https://git.openjdk.org/jdk/compare/df01cc528d3b6e52925b92119e43caee54ec86e8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@alisenchung The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 08: Full - Incremental (358da224)
• 07: Full - Incremental (ed8ed220)
• 06: Full - Incremental (29486a10)
• 05: Full - Incremental (0de40f87)
• 04: Full - Incremental (eb58531e)
• 03: Full - Incremental (5a05f64b)
• 02: Full - Incremental (0126af35)
• 01: Full - Incremental (630d78c9)
• 00: Full (4ed3d97e)

[kumarabhi006]

This test can be converted to automated. Similar issue was resolved for GTK LAF. You can refer #11291.

[DamonGuy]

Looks like the test needs a headful tag as well. Was this ran via CI?

[kumarabhi006]

Looks good now. Only point is "should we move this test outside folder as html file is deleted now?".
Hope you have tested in CI for all platform.

[alisenchung]

Looks good now. Only point is "should we move this test outside folder as html file is deleted now?". Hope you have tested in CI for all platform.

Clientlibs is green, also I'll keep this inside the folder for bookkeeping

[alisenchung]

/integrate

[openjdk]

@alisenchung This pull request has not yet been marked as ready for integration.

[kumarabhi006]

/integrate

You need a "Reviewer" approval to integrate.

[DamonGuy]

Agreed. Looks good now, especially if CI is green. Still need "R"eviewer approval.

[honkar-jdk]

LGTM

[alisenchung]

/integrate

[openjdk]

Going to push as commit 021ed6a.
Since your change was applied there have been 38 commits pushed to the master branch:

• 3057dde: 8329421: Native methods can not be selectively printed
• db15914: 8328753: Open source few Undecorated Frame tests
• 925d829: 8329013: StackOverflowError when starting Apache Tomcat with signed jar
• dd5d7d0: 8327002: (fs) java/nio/file/Files/CopyMoveVariations.java should be able to test across file systems
• 6ae1cf1: 8329368: Generational ZGC: Remove the unnecessary friend classes in ZAllocator
• 7eb78e3: 8320676: Manual printer tests have no Pass/Fail buttons, instructions close set 1
• 5ac067f: 8329289: Unify SetupJdkExecutable and SetupJdkLibrary
• 5ae849d: 8329292: Fix missing cleanups in java.management and jdk.management
• ed821cb: 8324807: Manual printer tests have no Pass/Fail buttons, instructions close set 2
• 5cf457b: 8329320: Simplify awt/print/PageFormat/NullPaper.java test
• ... and 28 more: https://git.openjdk.org/jdk/compare/df01cc528d3b6e52925b92119e43caee54ec86e8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alisenchung Pushed as commit 021ed6a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.