8328570: Convert closed JViewport manual applet tests to main #18418

prsadhuk · 2024-03-21T03:44:01Z

Few closed manual applet JViewport tests are converted to main based and opensourced

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8328570: Convert closed JViewport manual applet tests to main (Bug - P4)

Reviewers

Abhishek Kumar (@kumarabhi006 - Committer) ⚠️ Review applies to 395730f3
Alexander Zuev (@azuev-java - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18418/head:pull/18418
$ git checkout pull/18418

Update a local copy of the PR:
$ git checkout pull/18418
$ git pull https://git.openjdk.org/jdk.git pull/18418/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18418

View PR using the GUI difftool:
$ git pr show -t 18418

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18418.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-03-21T03:44:31Z

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-03-21T03:45:18Z

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328570: Convert closed JViewport manual applet tests to main

Reviewed-by: abhiscxk, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

e41bc42: 8327990: [macosx-aarch64] Various tests fail with -XX:+AssertWXAtThreadSync
4308017: 8328631: Convert java/awt/InputMethods/InputMethodsTest/InputMethodsTest.java applet test to manual
700d2b9: 8328401: Convert java/awt/Frame/InitialMaximizedTest/InitialMaximizedTest.html applet test to automated
bb3e84b: 8328592: hprof tests fail with -XX:-CompactStrings
ac2f8e5: 8327994: Update code gen in CallGeneratorHelper
c434b79: 8327169: serviceability/dcmd/vm/SystemMapTest.java and SystemDumpMapTest.java may fail after JDK-8326586
7006790: 8328628: JDK-8328157 incorrectly sets -MT on all compilers in jdk.jpackage
68170ae: 8328238: Convert few closed manual applet tests to main
9f5ad43: 8320675: PrinterJob/SecurityDialogTest.java hangs
684678f: 8328633: s390x: Improve vectorization of Match.sqrt() on floats
... and 17 more: https://git.openjdk.org/jdk/compare/a68f5d7331c2e6c4bc51eee95abcbabb5a19b484...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-03-21T03:45:55Z

@prsadhuk The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-03-21T03:48:52Z

Webrevs

kumarabhi006

Minor suggestion

kumarabhi006 · 2024-03-21T11:05:47Z

test/jdk/javax/swing/JViewport/bug4137282.java

+ * @library /java/awt/regtesthelpers
+ * @build PassFailJFrame
+ * @run main/manual bug4137282
+*/


Suggested change

*/

*/

kumarabhi006 · 2024-03-21T11:06:33Z

test/jdk/javax/swing/JViewport/bug4217252.java

+ * @library /java/awt/regtesthelpers
+ * @build PassFailJFrame
+ * @run main/manual bug4217252
+*/


Suggested change

*/

*/

kumarabhi006 · 2024-03-21T11:07:49Z

test/jdk/javax/swing/JViewport/bug4243479.java

+ * @library /java/awt/regtesthelpers
+ * @build PassFailJFrame
+   @run main/manual bug4243479
+*/


Suggested change

*/

*/

kumarabhi006 · 2024-03-21T11:08:09Z

test/jdk/javax/swing/JViewport/bug4750421.java

+ * @library /java/awt/regtesthelpers
+ * @build PassFailJFrame
+ * @run main/manual bug4750421
+*/


Suggested change

*/

*/

azuev-java · 2024-03-21T14:31:41Z

test/jdk/javax/swing/JViewport/bug4243479.java

+ * @summary Tests that JViewport do not blit when not visible
+ * @library /java/awt/regtesthelpers
+ * @build PassFailJFrame
+   @run main/manual bug4243479


Suggested change

@run main/manual bug4243479

* @run main/manual bug4243479

azuev-java · 2024-03-21T14:40:30Z

test/jdk/javax/swing/JViewport/bug4137282.java

+        return frame;
+    }
+
+    static void setPaneSize(int w, int h) {


Do we even need this method? It is used twice and if we just do setSize and setPreferredSize in these two places we could drop this method and make panel variable local. That will make it more compact and in my opinion more readable.

Yes, I considered that but it has 2 lines and used in 2 places...if it had been 1 line I would have done it but since it was more than 1 line I kept it and I dont think its affecting readability so much, is it?

prsadhuk · 2024-03-21T14:45:54Z

/integrate

openjdk · 2024-03-21T14:46:22Z

Going to push as commit 725d87b.
Since your change was applied there have been 27 commits pushed to the master branch:

e41bc42: 8327990: [macosx-aarch64] Various tests fail with -XX:+AssertWXAtThreadSync
4308017: 8328631: Convert java/awt/InputMethods/InputMethodsTest/InputMethodsTest.java applet test to manual
700d2b9: 8328401: Convert java/awt/Frame/InitialMaximizedTest/InitialMaximizedTest.html applet test to automated
bb3e84b: 8328592: hprof tests fail with -XX:-CompactStrings
ac2f8e5: 8327994: Update code gen in CallGeneratorHelper
c434b79: 8327169: serviceability/dcmd/vm/SystemMapTest.java and SystemDumpMapTest.java may fail after JDK-8326586
7006790: 8328628: JDK-8328157 incorrectly sets -MT on all compilers in jdk.jpackage
68170ae: 8328238: Convert few closed manual applet tests to main
9f5ad43: 8320675: PrinterJob/SecurityDialogTest.java hangs
684678f: 8328633: s390x: Improve vectorization of Match.sqrt() on floats
... and 17 more: https://git.openjdk.org/jdk/compare/a68f5d7331c2e6c4bc51eee95abcbabb5a19b484...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-03-21T14:46:28Z

@prsadhuk Pushed as commit 725d87b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8328570: Convert closed JViewport manual applet tests to main

7783bf9

openjdk bot added the rfr Pull request is ready for review label Mar 21, 2024

openjdk bot added the client client-libs-dev@openjdk.org label Mar 21, 2024

getCOntentPane removed

395730f

kumarabhi006 approved these changes Mar 21, 2024

View reviewed changes

formatting

8e177fa

azuev-java reviewed Mar 21, 2024

View reviewed changes

formatting

d588adc

azuev-java reviewed Mar 21, 2024

View reviewed changes

azuev-java approved these changes Mar 21, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Mar 21, 2024

openjdk bot added the integrated Pull request has been integrated label Mar 21, 2024

openjdk bot closed this Mar 21, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 21, 2024

prsadhuk deleted the manual-swing-fix branch March 21, 2024 14:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8328570: Convert closed JViewport manual applet tests to main #18418

8328570: Convert closed JViewport manual applet tests to main #18418

prsadhuk commented Mar 21, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Mar 21, 2024

openjdk bot commented Mar 21, 2024 •

edited

Loading

openjdk bot commented Mar 21, 2024

mlbridge bot commented Mar 21, 2024 •

edited

Loading

kumarabhi006 left a comment

kumarabhi006 Mar 21, 2024

kumarabhi006 Mar 21, 2024

kumarabhi006 Mar 21, 2024

kumarabhi006 Mar 21, 2024

azuev-java Mar 21, 2024

prsadhuk Mar 21, 2024

azuev-java Mar 21, 2024

prsadhuk Mar 21, 2024

prsadhuk commented Mar 21, 2024

openjdk bot commented Mar 21, 2024

openjdk bot commented Mar 21, 2024

8328570: Convert closed JViewport manual applet tests to main #18418

8328570: Convert closed JViewport manual applet tests to main #18418

Conversation

prsadhuk commented Mar 21, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Mar 21, 2024

openjdk bot commented Mar 21, 2024 • edited Loading

openjdk bot commented Mar 21, 2024

mlbridge bot commented Mar 21, 2024 • edited Loading

Webrevs

kumarabhi006 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prsadhuk commented Mar 21, 2024

openjdk bot commented Mar 21, 2024

openjdk bot commented Mar 21, 2024

prsadhuk commented Mar 21, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Mar 21, 2024 •

edited

Loading

mlbridge bot commented Mar 21, 2024 •

edited

Loading