8328665: serviceability/jvmti/vthread/PopFrameTest failed with a timeout

[sspitsyn]

This PR fixes a synchronization issue in the test:
test/hotspot/jtreg/serviceability/jvmti/vthread/PopFrameTest

The method notifyAtBreakpoint() can notify the TestTask thread when it has not reached an expected breakpoint yet.
The fix is to add a call to the method ensureAtBreakpoint() one more time in the B2 sub-test. It is needed after the top-most frame was popped with the JVMTI PopFrame, and the target thread needs to reach the breakpoint again after its execution was resumed.

The time is very intermittent. At least, I was not able to reproduce the timeout failure in thousands of mach5 runs with the -Xcomp option.

Testing:

• Run the test test/hotspot/jtreg/serviceability/jvmti/vthread/PopFrameTest thousands times in mach5

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8328665: serviceability/jvmti/vthread/PopFrameTest failed with a timeout (Bug - P4)

Reviewers

• Leonid Mesnik (@lmesnik - Reviewer) ⚠️ Review applies to 1502492f
• Chris Plummer (@plummercj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18419/head:pull/18419
$ git checkout pull/18419

Update a local copy of the PR:
$ git checkout pull/18419
$ git pull https://git.openjdk.org/jdk.git pull/18419/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18419

View PR using the GUI difftool:
$ git pr show -t 18419

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18419.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back sspitsyn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sspitsyn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328665: serviceability/jvmti/vthread/PopFrameTest failed with a timeout

Reviewed-by: lmesnik, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

• 5698f7a: 8329134: Reconsider TLAB zapping
• 4a14cba: 8329213: Better validation for com.sun.security.ocsp.useget option
• 9f5464e: 8329353: ResolvedReferencesNotNullTest.java failed with Incorrect resolved references array, quxString should not be archived
• 3f5b75a: 8328541: Remove or update obsolete comment in JRootPane
• 1e76e1f: 8328403: Remove applet usage from JColorChooser tests Test6977726
• 9d052e9: 8329131: Fold libjli_static back into libjli on AIX
• f2e5808: 8329126: No native wrappers generated anymore with -XX:-TieredCompilation after JDK-8251462
• 37c2279: 8329150: Remove CDS support for LatestMethodCache
• 20cb6e7: 8329337: Problem list BufferStrategyExceptionTest.java on Windows
• d1b51e3: 8321550: Update several runtime/cds tests to use vm flags or mark as flagless
• ... and 32 more: https://git.openjdk.org/jdk/compare/8fc9097b3720314ef7efaf1f3ac31898c8d6ca19...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@sspitsyn The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 06: Full - Incremental (21c57eae)
• 05: Full - Incremental (f8344149)
• 04: Full - Incremental (14e0e60f)
• 03: Full - Incremental (f4f92e92)
• 02: Full - Incremental (1502492f)
• 01: Full - Incremental (7843111d)
• 00: Full (3ac5c496)

[sspitsyn]

Thank you for review, Chris.

[sspitsyn]

/integrate

[openjdk]

Going to push as commit 70c8ff1.
Since your change was applied there have been 44 commits pushed to the master branch:

• ecd2b71: 8329354: java/text/Format/MessageFormat/CompactSubFormats.java fails
• c2979c1: 8329425: ProblemList containers/docker/TestJFREvents.java on linux-x64
• 5698f7a: 8329134: Reconsider TLAB zapping
• 4a14cba: 8329213: Better validation for com.sun.security.ocsp.useget option
• 9f5464e: 8329353: ResolvedReferencesNotNullTest.java failed with Incorrect resolved references array, quxString should not be archived
• 3f5b75a: 8328541: Remove or update obsolete comment in JRootPane
• 1e76e1f: 8328403: Remove applet usage from JColorChooser tests Test6977726
• 9d052e9: 8329131: Fold libjli_static back into libjli on AIX
• f2e5808: 8329126: No native wrappers generated anymore with -XX:-TieredCompilation after JDK-8251462
• 37c2279: 8329150: Remove CDS support for LatestMethodCache
• ... and 34 more: https://git.openjdk.org/jdk/compare/8fc9097b3720314ef7efaf1f3ac31898c8d6ca19...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sspitsyn Pushed as commit 70c8ff1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.