8328673: Convert closed text/html/CSS manual applet test to main #18424

prsadhuk · 2024-03-21T09:04:19Z

Couple closed manual applet text/html/CSS tests are converted to main based and opensourced

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8328673: Convert closed text/html/CSS manual applet test to main (Bug - P4)

Reviewers

Abhishek Kumar (@kumarabhi006 - Committer) ⚠️ Review applies to 8ff80bbb
Alexey Ivanov (@aivanov-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18424/head:pull/18424
$ git checkout pull/18424

Update a local copy of the PR:
$ git checkout pull/18424
$ git pull https://git.openjdk.org/jdk.git pull/18424/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18424

View PR using the GUI difftool:
$ git pr show -t 18424

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18424.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-03-21T09:04:58Z

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-03-21T09:05:28Z

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328673: Convert closed text/html/CSS manual applet test to main

Reviewed-by: abhiscxk, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

725d87b: 8328570: Convert closed JViewport manual applet tests to main
e41bc42: 8327990: [macosx-aarch64] Various tests fail with -XX:+AssertWXAtThreadSync
4308017: 8328631: Convert java/awt/InputMethods/InputMethodsTest/InputMethodsTest.java applet test to manual
700d2b9: 8328401: Convert java/awt/Frame/InitialMaximizedTest/InitialMaximizedTest.html applet test to automated
bb3e84b: 8328592: hprof tests fail with -XX:-CompactStrings
ac2f8e5: 8327994: Update code gen in CallGeneratorHelper
c434b79: 8327169: serviceability/dcmd/vm/SystemMapTest.java and SystemDumpMapTest.java may fail after JDK-8326586
7006790: 8328628: JDK-8328157 incorrectly sets -MT on all compilers in jdk.jpackage
68170ae: 8328238: Convert few closed manual applet tests to main
9f5ad43: 8320675: PrinterJob/SecurityDialogTest.java hangs
... and 18 more: https://git.openjdk.org/jdk/compare/a68f5d7331c2e6c4bc51eee95abcbabb5a19b484...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-03-21T09:05:50Z

@prsadhuk The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-03-21T09:08:32Z

Webrevs

kumarabhi006

Please update the library path.

kumarabhi006 · 2024-03-21T11:01:55Z

test/jdk/javax/swing/text/html/CSS/bug4271058.java

+ * @test
+ * @bug 4270889 4271058 4285098
+ * @summary Tests that <table border>, <table align> and <td width> tags work
+ * @library /open/test/jdk/java/awt/regtesthelpers


Need to remove "/open/test/jdk" here and in other test also.

Good catch...forgot to modify while copying...

aivanov-jdk · 2024-03-21T13:56:38Z

test/jdk/javax/swing/text/html/CSS/bug4271058.java

+
+    public static void main(String[] args) throws Exception {
+         PassFailJFrame.builder()
+                .title("CSS tag Instructions")


A more specific title?

aivanov-jdk · 2024-03-21T14:00:17Z

test/jdk/javax/swing/text/html/CSS/bug4271058.java

+                .testUI(bug4271058::createTestUI)
+                .build()


I guess the test will benefit from a screenshot feature to capture how the table is rendered.

Suggested change

.testUI(bug4271058::createTestUI)

.build()

.testUI(bug4271058::createTestUI)

.screenCapture()

.build()

The feature to take a screenshot automatically, when Fail button is pressed, hasn't been implemented yet. It's tracked under JDK-8317114.

aivanov-jdk · 2024-03-21T14:02:38Z

test/jdk/javax/swing/text/html/CSS/bug4286458.java

+        JEditorPane jep = new JEditorPane();
+        jep.setEditorKit(new HTMLEditorKit());
+        jep.setEditable(false);
+        jep.setText(text);


Suggested change

JEditorPane jep = new JEditorPane();

jep.setEditorKit(new HTMLEditorKit());

jep.setEditable(false);

jep.setText(text);

JEditorPane jep = new JEditorPane("text/html", text);

jep.setEditable(false);

Could be reduced to.

aivanov-jdk · 2024-03-21T14:03:28Z

test/jdk/javax/swing/text/html/CSS/bug4286458.java

+    private static JFrame createTestUI() {
+
+        String text =
+            "</html><body><table border=\"1\" cellpadding=\"-10\">" +


Suggested change

"</html><body><table border=\"1\" cellpadding=\"-10\">" +

"<html><body><table border=\"1\" cellpadding=\"-10\">" +

It should start with an opening tag.

prsadhuk · 2024-03-22T10:24:37Z

/integrate

openjdk · 2024-03-22T10:25:15Z

Going to push as commit cd534f8.
Since your change was applied there have been 55 commits pushed to the master branch:

38e3cda: 8328670: Automate and open source few closed manual applet test
b334a8e: 8328272: [AIX] Use flag kind "diagnostic" for platform specific flags
e669d14: 8328671: Mark allocate_new_tlab and unsafe_max_tlab_alloc of CollectedHeap as pure virtual
940d196: 8328604: remove on_aix() function
d44aaa3: 8326643: JDK server does not send a dummy change_cipher_spec record after HelloRetryRequest message
9bc741d: 8328339: Static import prevents source launcher from finding class with main method
256d48b: 8327980: Convert javax/swing/JToggleButton/4128979/bug4128979.java applet test to main
177b8a2: 8327840: Automate javax/swing/border/Test4129681.java
da00921: 8320404: Double whitespace in SubTypeCheckNode::dump_spec output
4d36c4a: 8328285: GetOwnedMonitorInfo functions should use JvmtiHandshake
... and 45 more: https://git.openjdk.org/jdk/compare/a68f5d7331c2e6c4bc51eee95abcbabb5a19b484...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-03-22T10:25:21Z

@prsadhuk Pushed as commit cd534f8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8328673: Convert closed text/html/CSS manual applet test to main

8ff80bb

openjdk bot added the rfr Pull request is ready for review label Mar 21, 2024

openjdk bot added the client client-libs-dev@openjdk.org label Mar 21, 2024

kumarabhi006 approved these changes Mar 21, 2024

View reviewed changes

library path fix

d846e61

aivanov-jdk suggested changes Mar 21, 2024

View reviewed changes

Review comment update

fbc0b82

aivanov-jdk approved these changes Mar 21, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Mar 21, 2024

openjdk bot added the integrated Pull request has been integrated label Mar 22, 2024

openjdk bot closed this Mar 22, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 22, 2024

prsadhuk deleted the manual-css-fix branch March 22, 2024 11:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8328673: Convert closed text/html/CSS manual applet test to main #18424

8328673: Convert closed text/html/CSS manual applet test to main #18424

prsadhuk commented Mar 21, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Mar 21, 2024

openjdk bot commented Mar 21, 2024 •

edited

Loading

openjdk bot commented Mar 21, 2024

mlbridge bot commented Mar 21, 2024 •

edited

Loading

kumarabhi006 left a comment

kumarabhi006 Mar 21, 2024

prsadhuk Mar 21, 2024

aivanov-jdk Mar 21, 2024

aivanov-jdk Mar 21, 2024

prsadhuk Mar 21, 2024

aivanov-jdk Mar 21, 2024

prsadhuk Mar 21, 2024

aivanov-jdk Mar 21, 2024

prsadhuk Mar 21, 2024

prsadhuk commented Mar 22, 2024

openjdk bot commented Mar 22, 2024

openjdk bot commented Mar 22, 2024

	"</html><body><table border=\"1\" cellpadding=\"-10\">" +
	"<html><body><table border=\"1\" cellpadding=\"-10\">" +

8328673: Convert closed text/html/CSS manual applet test to main #18424

8328673: Convert closed text/html/CSS manual applet test to main #18424

Conversation

prsadhuk commented Mar 21, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Mar 21, 2024

openjdk bot commented Mar 21, 2024 • edited Loading

openjdk bot commented Mar 21, 2024

mlbridge bot commented Mar 21, 2024 • edited Loading

Webrevs

kumarabhi006 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prsadhuk commented Mar 22, 2024

openjdk bot commented Mar 22, 2024

openjdk bot commented Mar 22, 2024

prsadhuk commented Mar 21, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Mar 21, 2024 •

edited

Loading

mlbridge bot commented Mar 21, 2024 •

edited

Loading