JDK-8328604: remove on_aix() function

[MBaesken]

The on_aix() function was added to distinguish "real" AIX and os400 PASE mode. But the os400 PASE was never supported in OpenJDK and there are no plans to do so.
So we can clean this up a bit and simplify the AIX coding.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8328604: remove on_aix() function (Bug - P4)

Reviewers

• Christoph Langer (@RealCLanger - Reviewer)
• Thomas Stuefe (@tstuefe - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18427/head:pull/18427
$ git checkout pull/18427

Update a local copy of the PR:
$ git checkout pull/18427
$ git pull https://git.openjdk.org/jdk.git pull/18427/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18427

View PR using the GUI difftool:
$ git pr show -t 18427

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18427.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328604: remove on_aix() function

Reviewed-by: clanger, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 7006790: 8328628: JDK-8328157 incorrectly sets -MT on all compilers in jdk.jpackage
• 68170ae: 8328238: Convert few closed manual applet tests to main
• 9f5ad43: 8320675: PrinterJob/SecurityDialogTest.java hangs
• 684678f: 8328633: s390x: Improve vectorization of Match.sqrt() on floats

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (53b5957a)

[tstuefe]

But the PASE port in OpenJDK is functional, right? If it was functional, someone may be using it. (I remember talking to IBMers who used OpenJDK on AS/400, but cannot remember if they built it themselves)

[MBaesken]

But the PASE port in OpenJDK is functional, right? If it was functional, someone may be using it.

Never tested it, so I think it is unlikely that it is functional.

[RealCLanger]

No, the OpenJDK port to AS/400 is not functional and I'm not aware of plans, e.g. from IBM, to change that. This cleanup is welcome, I'd say.

[tstuefe]

Okay then.

[MBaesken]

/integrate

[openjdk]

Going to push as commit 940d196.
Since your change was applied there have been 34 commits pushed to the master branch:

• d44aaa3: 8326643: JDK server does not send a dummy change_cipher_spec record after HelloRetryRequest message
• 9bc741d: 8328339: Static import prevents source launcher from finding class with main method
• 256d48b: 8327980: Convert javax/swing/JToggleButton/4128979/bug4128979.java applet test to main
• 177b8a2: 8327840: Automate javax/swing/border/Test4129681.java
• da00921: 8320404: Double whitespace in SubTypeCheckNode::dump_spec output
• 4d36c4a: 8328285: GetOwnedMonitorInfo functions should use JvmtiHandshake
• 0efd9dc: 8328398: Convert java/awt/im/4490692/bug4490692.html applet test to main
• 46809b3: 8324736: Invalid end positions for EMPTY_STATEMENT
• f7f291c: 8328301: Convert Applet test ManualHTMLDataFlavorTest.java to main program
• 771f6a2: 8327704: Update nsk/jdi tests to use driver instead of othervm
• ... and 24 more: https://git.openjdk.org/jdk/compare/93d1700f23d42cb35b6028c5d7d029c035711acf...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit 940d196.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.