Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8328555: hidpi problems for test java/awt/Dialog/DialogAnotherThread/JaWSTest.java #18438

Closed
wants to merge 1 commit into from

Conversation

prrace
Copy link
Contributor

@prrace prrace commented Mar 21, 2024

This previously closed test is cleaned up, opened and fixed to work on hidpi at fractional scales.
It has unrelated problems on macOS 14 and is problem listed there (as it was when it was a closed test).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8328555: hidpi problems for test java/awt/Dialog/DialogAnotherThread/JaWSTest.java (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18438/head:pull/18438
$ git checkout pull/18438

Update a local copy of the PR:
$ git checkout pull/18438
$ git pull https://git.openjdk.org/jdk.git pull/18438/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18438

View PR using the GUI difftool:
$ git pr show -t 18438

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18438.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 21, 2024

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 21, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title 8328555 8328555: hidpi problems for test java/awt/Dialog/DialogAnotherThread/JaWSTest.java Mar 21, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 21, 2024
@openjdk
Copy link

openjdk bot commented Mar 21, 2024

@prrace The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 21, 2024
@prrace prrace closed this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant