8328555: hidpi problems for test java/awt/Dialog/DialogAnotherThread/JaWSTest.java

[prrace]

This previously closed test is cleaned up, opened and fixed to work on hidpi at fractional scales.
It has unrelated problems on macOS 14 and is problem listed there (as it was when it was a closed test).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8328555: hidpi problems for test java/awt/Dialog/DialogAnotherThread/JaWSTest.java (Bug - P4)

Reviewers

• Alexey Ivanov (@aivanov-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18439/head:pull/18439
$ git checkout pull/18439

Update a local copy of the PR:
$ git checkout pull/18439
$ git pull https://git.openjdk.org/jdk.git pull/18439/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18439

View PR using the GUI difftool:
$ git pr show -t 18439

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18439.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328555: hidpi problems for test java/awt/Dialog/DialogAnotherThread/JaWSTest.java

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

• 4d932d6: 8326853: Missing @since tags for Charset related methods added in Java 10
• ce7ebaa: 8328812: Update and move siphash license
• b7a51dd: 8328382: Convert java/awt/FileDialog/FileDialogForPackages test to main
• 739957c: 8328384: Convert java/awt/FileDialog/FileDialogOpenDirTest test to main
• 13cf070: 8328556: Do not extract large CKO_SECRET_KEY keys from the NSS Software Token
• 709410d: 8328679: Improve comment for UNSAFE_ENTRY_SCOPED in unsafe.cpp
• f207aa9: 8326960: GHA: RISC-V sysroot cannot be debootstrapped due to ongoing Debian t64 transition
• e80619a: 8328680: Introduce JDK_LIB, and clean up module native compilation
• 638708c: 8328697: SubMenuShowTest and SwallowKeyEvents tests stabilization
• e06b568: 8328602: Parallel: Incorrect assertion in fill_dense_prefix_end
• ... and 20 more: https://git.openjdk.org/jdk/compare/ba05c6d0b6955a0c5110b75e709e2206961f9fec...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@prrace The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (434ea601)
• 00: Full (5aaef6f8)

[honkar-jdk]

@prrace This test passes on macOS 14.2. Earlier the test was problemlisted on mac because the mouse click was not being triggered on the edge of Frame or Buttons. Since you have changed the button click location for fix hi-dpi problem, as a side-effect it to passes on macOS. So problemlisting is not required on macOS.

Test log on macOS 14.2

Action Performed
Before First Modal
handler is started
Running
Before Hiding 1
Before Synchronized
After First Modal
In Synchronized
After Notify
Stop Running
Show Something
STATUS:Passed.

[honkar-jdk]

Problemlist on macOS no longer required due to the updated test changes.

[aivanov-jdk]

Looks good to me.

I agree with @honkar-jdk, the test passes on macOS 14.3.1 for me. The original test couldn't click the button, now that the mouse cursor is position at the centre of the button, robot clicks it and the test passes.

[prrace]

OK, I've removed the problem listing.

[prrace]

/integrate

[openjdk]

Going to push as commit 23ebd9c.
Since your change was applied there have been 30 commits pushed to the master branch:

• 4d932d6: 8326853: Missing @since tags for Charset related methods added in Java 10
• ce7ebaa: 8328812: Update and move siphash license
• b7a51dd: 8328382: Convert java/awt/FileDialog/FileDialogForPackages test to main
• 739957c: 8328384: Convert java/awt/FileDialog/FileDialogOpenDirTest test to main
• 13cf070: 8328556: Do not extract large CKO_SECRET_KEY keys from the NSS Software Token
• 709410d: 8328679: Improve comment for UNSAFE_ENTRY_SCOPED in unsafe.cpp
• f207aa9: 8326960: GHA: RISC-V sysroot cannot be debootstrapped due to ongoing Debian t64 transition
• e80619a: 8328680: Introduce JDK_LIB, and clean up module native compilation
• 638708c: 8328697: SubMenuShowTest and SwallowKeyEvents tests stabilization
• e06b568: 8328602: Parallel: Incorrect assertion in fill_dense_prefix_end
• ... and 20 more: https://git.openjdk.org/jdk/compare/ba05c6d0b6955a0c5110b75e709e2206961f9fec...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prrace Pushed as commit 23ebd9c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.