-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8328776: [AIX] remove checked_vmgetinfo, use vmgetinfo directly #18446
Conversation
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
@MBaesken This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 16 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. BTW, I guess we can remove every occurence of os::Aix::on_pase() to cleanup the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for cleaning up.
/integrate |
Going to push as commit cf9b5a7.
Your commit was automatically rebased without conflicts. |
The subroutine vmgetinfo
https://www.ibm.com/docs/es/aix/7.2?topic=v-vmgetinfo-subroutine
https://www.ibm.com/docs/es/aix/7.1?topic=v-vmgetinfo-subroutine
was not available on very old OS releases; but we do not support / run on those old releases anyway these days so the helper checked_vmgetinfo can be removed.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18446/head:pull/18446
$ git checkout pull/18446
Update a local copy of the PR:
$ git checkout pull/18446
$ git pull https://git.openjdk.org/jdk.git pull/18446/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18446
View PR using the GUI difftool:
$ git pr show -t 18446
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18446.diff
Webrev
Link to Webrev Comment