Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8328776: [AIX] remove checked_vmgetinfo, use vmgetinfo directly #18446

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Mar 22, 2024

The subroutine vmgetinfo
https://www.ibm.com/docs/es/aix/7.2?topic=v-vmgetinfo-subroutine
https://www.ibm.com/docs/es/aix/7.1?topic=v-vmgetinfo-subroutine
was not available on very old OS releases; but we do not support / run on those old releases anyway these days so the helper checked_vmgetinfo can be removed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8328776: [AIX] remove checked_vmgetinfo, use vmgetinfo directly (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18446/head:pull/18446
$ git checkout pull/18446

Update a local copy of the PR:
$ git checkout pull/18446
$ git pull https://git.openjdk.org/jdk.git pull/18446/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18446

View PR using the GUI difftool:
$ git pr show -t 18446

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18446.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 22, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 22, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328776: [AIX] remove checked_vmgetinfo, use vmgetinfo directly

Reviewed-by: clanger, lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • 4d932d6: 8326853: Missing @since tags for Charset related methods added in Java 10
  • ce7ebaa: 8328812: Update and move siphash license
  • b7a51dd: 8328382: Convert java/awt/FileDialog/FileDialogForPackages test to main
  • 739957c: 8328384: Convert java/awt/FileDialog/FileDialogOpenDirTest test to main
  • 13cf070: 8328556: Do not extract large CKO_SECRET_KEY keys from the NSS Software Token
  • 709410d: 8328679: Improve comment for UNSAFE_ENTRY_SCOPED in unsafe.cpp
  • f207aa9: 8326960: GHA: RISC-V sysroot cannot be debootstrapped due to ongoing Debian t64 transition
  • e80619a: 8328680: Introduce JDK_LIB, and clean up module native compilation
  • 638708c: 8328697: SubMenuShowTest and SwallowKeyEvents tests stabilization
  • e06b568: 8328602: Parallel: Incorrect assertion in fill_dense_prefix_end
  • ... and 6 more: https://git.openjdk.org/jdk/compare/940d1965f831a9f7e4f1ce34e381c038827c7ca2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 22, 2024
@openjdk
Copy link

openjdk bot commented Mar 22, 2024

@MBaesken The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Mar 22, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 22, 2024

Webrevs

Copy link
Contributor

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. BTW, I guess we can remove every occurence of os::Aix::on_pase() to cleanup the code.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 22, 2024
Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks for cleaning up.

@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 25, 2024

Going to push as commit cf9b5a7.
Since your change was applied there have been 26 commits pushed to the master branch:

  • acc4a82: 8328862: Remove unused GrowableArrayFilterIterator
  • 9f920b9: 8324655: Identify integer minimum and maximum patterns created with if statements
  • c7b9dc4: 8328404: RISC-V: Fix potential crash in C2_MacroAssembler::arrays_equals
  • bc73963: 8328303: 3 JDI tests timed out with UT enabled
  • 476421e: 8328370: Convert java/awt/print/Dialog/PrintApplet.java applet test to main
  • c013fa1: 8328194: Add a test to check default rendering engine
  • f33a844: 8325536: JVM crash during CDS archive creation with -XX:+AllowArchivingWithJavaAgent
  • 4324e3b: 8328612: AdaptiveSizePolicySpaceOverheadTester::is_exceeded() print max_eden_size twice
  • c7bbf84: 8328190: Convert AWTPanelSmoothWheel.html applet test to main
  • 23ebd9c: 8328555: hidpi problems for test java/awt/Dialog/DialogAnotherThread/JaWSTest.java
  • ... and 16 more: https://git.openjdk.org/jdk/compare/940d1965f831a9f7e4f1ce34e381c038827c7ca2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 25, 2024
@openjdk openjdk bot closed this Mar 25, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 25, 2024
@openjdk
Copy link

openjdk bot commented Mar 25, 2024

@MBaesken Pushed as commit cf9b5a7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants